From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4D57A0C43; Fri, 22 Oct 2021 13:54:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 957534114A; Fri, 22 Oct 2021 13:54:36 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 33DF041149 for ; Fri, 22 Oct 2021 13:54:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="229558596" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="229558596" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 04:54:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="445259978" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 22 Oct 2021 04:54:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 04:54:31 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 04:54:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 04:54:30 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 04:54:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a3blvhRtcqItyTGcHx7t606OVmaREuK5uRBFFUMoY/1t8H+8N0TOoprUbuSaUqeIHEQTPaUdy4k1vd1q2jOxqBPoWTsbdrDLBDHLvX1RtLBa0Y5lMWJp1SgLhVOqosYgR+IybVi7rRm1aObhas8q4Q/wNZOcLlhDctKzFAlA581X+kM599exYE7JCa/SylP01s3lYocJO0oa7YT6uPiAoZXXpiLO4lc33TA/AFDw6uymEO0T5yHmkAlkAvshyijafbVpbfDD45qV/lH8XEf7U8DsAj1TZNAQKHT6uCRZeGgH5Yl9OejT2kBVB4iuxX9vZfy0ik3BWlJv0vuRi7hCVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6flkpbDHhJnlgIQa95cjvwUttYuO3AXwVZtRdC19z0o=; b=ZilnpaS6OkG0AXXgPAMIDosZzE2LHO17A2kRlBjGXYI2HICOnk+pt7eJwLqik6IC/246jxTAEDEDoGC9LxmPGeI8ZiTA96OPYj7S/rwU/7DkqItkIBkPclbO9Rou8WmF7RZWteBxq+g1/874BzDLGAn3AWBHBWCYtueWSe2fHpx/qbycbSy0jpD5DKFUsSZZOeCuhPM8L3i3TnMw6j3KXm5VN00HHiAn1/6CQ/7ddYXVcO6xO5J10n707RH2DfENclhZKZ2zTd0NoKNGzMa/7eu06pn1UIZbNco7hMb+i+jMvqVrE4R+zaEFnALxsGm9npovn2t9Rm8Nqq0vPR/UdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6flkpbDHhJnlgIQa95cjvwUttYuO3AXwVZtRdC19z0o=; b=vnKeSOPQ7He+4tmX8SO0FairOlTSjI5fyKD8alzIzxk/H8/jBo2y59lBkpPdfsFS1q5ACfI0WgzM+JTIzyuMihhBxOAGPiKGgTdcc5eQYtMuEK3gJHKDtQHb08fy880MO+4mTiUupVxppkcQ60YxVF1LutXYsEmVtJcmiCZSqx8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Fri, 22 Oct 2021 11:54:30 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::f1a0:809a:3d2e:e13c]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::f1a0:809a:3d2e:e13c%9]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 11:54:30 +0000 To: Ferruh Yigit , Miao Li , CC: , , Anatoly Burakov References: <20211015170911.478394-1-miao.li@intel.com> <20211018141638.5916-1-miao.li@intel.com> <20211018141638.5916-5-miao.li@intel.com> <6adee6a3-2b20-a7cd-761a-4e9662d430ee@intel.com> From: David Hunt Message-ID: <513845c7-30c4-1206-15b3-9560a5fad9f1@intel.com> Date: Fri, 22 Oct 2021 12:54:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <6adee6a3-2b20-a7cd-761a-4e9662d430ee@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: DU2PR04CA0253.eurprd04.prod.outlook.com (2603:10a6:10:28e::18) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 Received: from [10.4.11.161] (95.45.23.115) by DU2PR04CA0253.eurprd04.prod.outlook.com (2603:10a6:10:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 22 Oct 2021 11:54:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5169ba62-5167-4bc0-7358-08d99552b47b X-MS-TrafficTypeDiagnostic: PH0PR11MB5093: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x/+pq5PcdJKNOoolex7vpwq9NQF4ppmkcyQOaH7pkjI7HcQ7bdiiyUKMueElO+DHBYnlxOK12YCoOifKTAJYS6mPbmj5glf10g80HAcZQl/kGsF5NFrSPD7APJLR1HwSuNZRHnyCVyxoP1ActBBOuwl00efO5UWJRnyd5PMqESt9gv9oRX42jIopBU5CUPpHnJvEZYGhh259HCb8mmNbbXR1Ytu34mY0g84TlwdY0+bZECQBoOfN87cu+VRt5TP9NeORjBlSUoiBgaYFz9BG10y9g6UYq18ucCWwNRoSWcZpE9SBqftQAueGTDMFHFRC5DRsjkR8yrgEEREfHIB4Afn/kW8RTg2oD+a/W50jmEOCm1MMfV2Be2PXjXYe25nzboji08Mgk10SnReHAuGzbsv5EeAFQ53v4DUjWLYPiQdd0MOvGVFfLh73XD3NiM0+yFS0+/EzTsSWq+u8gaafhMQl/Cls654DH6uixn9zOL2Z6AJTjQsyy/Htc8ES862Vs0xOdXrtB1emWPVdQxMq72efYI/7tCSpUoFhiWJkEPlMmCU0O6Shw0sglgZayZwxX4UD/IxqZrxjem8NtT+PChzh0zxGzOBOyHQwz/F/W7PbCAZlQaFjfd9MWSKQgR/7xZsNEYgsfjM1yJsaYJwdOrqoxrcOFDaJKZ64QXrUj4EnF8uCq9vfyCjLwFNl/r4ZSX1tibQnfWxmBz2xahR1h5ZyaSL/QUU1D4j9HA1rUJo4mFcOrhRUGFagtzrpeY8b X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(26005)(31696002)(2906002)(16576012)(508600001)(8676002)(53546011)(8936002)(5660300002)(36756003)(38100700002)(4326008)(66946007)(6486002)(86362001)(31686004)(110136005)(956004)(6666004)(107886003)(66476007)(2616005)(82960400001)(44832011)(316002)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1hoblFjbzRhNVhVTC9nY2d1MTgxOVBjNTF0dmI3a3RXbFo3WHRkWkFqd01I?= =?utf-8?B?am5VQ28vbnliU05uODNzZGJNTnRwVGlLSGVZak9CbzU5a0o2S2hlQUFaaXhr?= =?utf-8?B?KzE5ZW1mOW5SZ2NoamFtcHZTWGFqRGV4UHBlZ0krSDlqbnBlZE5OWHljeDNU?= =?utf-8?B?eXQ0VS8xakdKNlVEV1lLM2pyaWRjRGFvYXQ3NExKeG85RlBsME1SZW1kdVJa?= =?utf-8?B?dlQ4ZEJLdmRFeHpKZDZuR2NKTlVhMm8xNmpKaFJFYTd0VHJmdms4eVJrT3p0?= =?utf-8?B?T2cxMUxxbnRKbmRUcUNVZjdsOW1uTlVySEFaZXN2a3RDcVc3T0VWVmwrb3Uw?= =?utf-8?B?cy85b1EwVnV0WkJTUGVHSFI5Sy85czYzWDNHdzVmTVZNVVVHejlKN2VrSldS?= =?utf-8?B?M0x1elExUVdXdUFoWEpnVFFod0pXZDU4UTZXeTZ6TUFWZ3J3NFZVakhjakxM?= =?utf-8?B?em82NmhnTTFqUEduUCt5MXlaN1pZZVNGVVRWU3dZR3RPRE4wbytkNTcyN2xu?= =?utf-8?B?V3lub0hYSG5ndjFva2xpTFZMNWRmV0RxS2RjSjdMTG5mQWtqek8yZzUzbnR3?= =?utf-8?B?NExPK0pmNHJXUFVLRmlGNmtOZ3ZacmtPU2NJODRyWUdaMWVpRW1yZGJna1cx?= =?utf-8?B?QU5zRFJJY0ZGY2xLVDZKL0RjYmJZSE1IYVZnbFhhZXB4QTBLNXhNZmFleW9h?= =?utf-8?B?d3VKeW13QVBpblZva2dTUzhTdWp0bUNoU2ZlY25GQkJNdVo0TktTWUVBRnFy?= =?utf-8?B?STdaa1BJSGJ5L0JvYmFUeE53ZDlyeEp5UnVPdzdEbVp1Tk40ZzkvTzJTRDJZ?= =?utf-8?B?TDBHMFR0K3I3V3NFNjgrNXplRVN5K0w3emN3RWlJWEZIay9SODdEcXoxYTkr?= =?utf-8?B?NU40OUx6cVJ2VkJWMERQZnl1bjBxa2d5OTFMTzVyZng2TzFCUVY4alRaclRI?= =?utf-8?B?R01OMnN0enJyb2dqSDVIN3ZoRDJabXVjWXBrWlJyUUVUeHpIZXdacktGa2tT?= =?utf-8?B?MDlvTHkrUzlZV0NrYStLcGVQVmZNYWFoeFp6MjN4SDRyVVRRa1dBMEZXU3dP?= =?utf-8?B?YlBrNnZJQkU0cE9rN3RiaVpwREVQNWFQRU9MTWIvZndER1QwZ2cyVmdRbzdF?= =?utf-8?B?enI4OEd5U080aEZyWFQrZkIyZzlJSDB4Q3Z3SHhSc0V5OWlCZlljdC9EZFhM?= =?utf-8?B?Y1l2T0hna3FvSjlTaVpKNk44Z3g2L1VsNENZREk1RTVueU5MdXd6T2lOOFhz?= =?utf-8?B?cVR6YUtZeXI3ay90N2lUS0Z1b3VNdElxTWswZDFkaFBlZkRoVWg5N3k0Witz?= =?utf-8?B?T3Z5TzNmZ281K2dZRVRXNnN5R21waUJRVm1qL01QK2NrRkhJVSs3c0p1RGdR?= =?utf-8?B?KzUxNGU3dEpZZURkSHJ3bnV4NFhUdVpERFhDeUZxc3owb1B3aDZRR0pKNURL?= =?utf-8?B?SVErMDJlaVN1RUhqOEVMUGNiNEVYWkwvRC9LSWdKUWJhUVV6UGcvRG9uNTh1?= =?utf-8?B?WUZaeEJwOGtBc3pSWDFSYlhvRWs4czE0WTlKeExEV3pwdmpLZWxMZnQ3VzZD?= =?utf-8?B?WFNhSWswbHgzZUliT2xUM1R3QUJkLzRmQkt5RU56QWpDZzJPMVBFbkpjSGpR?= =?utf-8?B?OWVmRTZCbDlkNWNiYXlxUDg5R09qcGpwVTR6L2kyS0diS0J0RnhYMWwwSGth?= =?utf-8?B?WUtYWTNHY2tvNmJROFRVR1dEaEVaajFwc29WTy8yMEorNS93ek4xaUxUK1Zj?= =?utf-8?B?VHo2WU80QXBEZGR2R01ERU92STUyaWJSelVRWGIvY2VMSDluV2t4TDc1QmRi?= =?utf-8?B?U2RhTUpmeDZxS2VZMzJlWDIvMTF1KzRRMnROL1U2cmUzRjNNTm5zNDNCTzA0?= =?utf-8?B?S2VzUlNkV24xM3dvSUI0dm5KT2tPUGN3Y1E4MnFSVmxtSEFpY002UWYrR2h1?= =?utf-8?Q?fg5gs7mruH4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5169ba62-5167-4bc0-7358-08d99552b47b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 11:54:29.8706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: david.hunt@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5093 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21/10/2021 5:48 PM, Ferruh Yigit wrote: > On 10/18/2021 3:16 PM, Miao Li wrote: >> Since some vdevs like virtio and vhost do not support rxq_info_get and >> queue state inquiry, the error return value -ENOTSUP need to be ignored >> when queue_stopped cannot get rx queue information and rx queue state. >> This patch changes the return value of queue_stopped when >> rte_eth_rx_queue_info_get return -ENOTSUP to support vdevs which cannot >> provide rx queue information and rx queue state enable power management. >> > > Don't we want to backport this patch? In case later a patch in the main > repo relies on this return type and that needs to be merged to LTS... > > Also need to clarify if this is a fix or not. > >> Signed-off-by: Miao Li >> Acked-by: Anatoly Burakov >> Reviewed-by: Chenbo Xia > > power library maintainer ack/review is missing. Hi Ferruh,   Anatoly's Ack is good on this, he's very familiar with this code. Rgds, Dave. --snip--