From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 848E5A00E6 for ; Mon, 8 Jul 2019 11:07:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 422CA3195; Mon, 8 Jul 2019 11:07:33 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 1ED3A2E81 for ; Mon, 8 Jul 2019 11:07:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 72B2A62E; Mon, 8 Jul 2019 05:07:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 08 Jul 2019 05:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LZqTXeKz3LsUyq6GjURbKqyjYHoQ1tKTZ39/2VZ7L6Y=; b=EKt37M4yufHF /ds5+n0nFcx/S/yDaiGLXBueORMmAaK2ICxQ0stLmyf0eNYkZbDPR879ljyeP6FC H6z9YjQIetpCyVGMcy9d/iLpqYPys5U7urFCI2OYTmfo4ZafEqaYtUUxFYFrDx3M eCULhTfL11rhvT21MlBocyJf+Q6+RR0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=LZqTXeKz3LsUyq6GjURbKqyjYHoQ1tKTZ39/2VZ7L 6Y=; b=WxwwdTjLQaFxyPGfEGDro+T+mus8cq8qbPRGM+83yPpVSqEz552FFREhk EifMekF83T4zRCSdbuu3RQ5+hl37EkuLSVHr8qbnTH9NOqgAmhpnMgCy1odb1ECQ azFZS8KiL2A0tVs7xqcXQawBH6f7F3KVzRgoJbsLMjuom3zBCDWWDJwLAjAwUbQ0 F1ziwPSTFbf5n+gWxUoGY8y76UQlhhSO1AeM5/JxFjfMSNfM3bkwBjPiam8B7cet +TcVFTcqydcHsugCa4lz6nAgeDdgIIk0T4SZnpN68RUJlMRN0z4R5EHs2t6foyCE mDHdolxr2+dw2nQ2sSz2f5Mp2PnDA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgedtgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DD3A58005B; Mon, 8 Jul 2019 05:07:28 -0400 (EDT) From: Thomas Monjalon To: jerinj@marvell.com, Sunil Kumar Kori Cc: dev@dpdk.org, John McNamara , Marko Kovacevic , Konstantin Ananyev Date: Mon, 08 Jul 2019 11:07:27 +0200 Message-ID: <5141529.7f7qfYg9RR@xps> In-Reply-To: <20190708043300.44295-1-jerinj@marvell.com> References: <1558349992-12237-1-git-send-email-skori@marvell.com> <20190708043300.44295-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2019 06:32, jerinj@marvell.com: > From: Sunil Kumar Kori > > Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags > during fragmentation and reassemble operation implicitly. > Because of this, application is forced to use checksum offload > whether it is supported by platform or not. > > Also documentation does not provide any expected value of ol_flags > in returned mbuf (reassembled or fragmented) so application will never > come to know that which offloads are enabled. So transmission may be failed > for the platforms which does not support checksum offload. > > Also, IPv6 does not contain any checksum field in header so setting > mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid. > > So removing mentioned flag from the library. > > Signed-off-by: Sunil Kumar Kori > Acked-by: Konstantin Ananyev Applied, thanks PS: I move the release notes from ABI to API changes as it is an API behaviour change.