From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 128CDA034C; Tue, 30 Aug 2022 09:44:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A21FA40F18; Tue, 30 Aug 2022 09:44:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D7D8940F17 for ; Tue, 30 Aug 2022 09:44:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661845496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fspDnbm95/X67FTUMfhsqgrltwUzqLB7UsbURvcTz40=; b=HCRr0MzWNFIFK9KnSySQ/F2PgQ1sFOPM2Ix3z5bB2oylKuXaSVY6jKEPGSQroB3XJBQ1fL x3sWTmtxuORxhLXV++eCfHiEmx3fsNDhkvx0ajM7w1Vy4Ik8ADCp7VR6DD+PbuX3DozGgD YA+ECf4IqeekiFFzzRo3LeemmSTWvHY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-120-tzFhl0woNP-crHkZ6uANAw-1; Tue, 30 Aug 2022 03:44:53 -0400 X-MC-Unique: tzFhl0woNP-crHkZ6uANAw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3353101A5AD; Tue, 30 Aug 2022 07:44:52 +0000 (UTC) Received: from [10.39.208.27] (unknown [10.39.208.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A88429458A; Tue, 30 Aug 2022 07:44:50 +0000 (UTC) Message-ID: <5144a909-7e19-bcda-7bae-89b42fff100c@redhat.com> Date: Tue, 30 Aug 2022 09:44:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 00/10] baseband/acc200 From: Maxime Coquelin To: Nicolas Chautru , dev@dpdk.org, thomas@monjalon.net, gakhil@marvell.com, hemant.agrawal@nxp.com, trix@redhat.com, "Vargas, Hernan" Cc: mdr@ashroe.eu, bruce.richardson@intel.com, david.marchand@redhat.com, stephen@networkplumber.org References: <1657238503-143836-1-git-send-email-nicolas.chautru@intel.com> <9087aa5a-6ba8-5df2-8a68-63926843ff7e@redhat.com> In-Reply-To: <9087aa5a-6ba8-5df2-8a68-63926843ff7e@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, On 7/12/22 15:48, Maxime Coquelin wrote: > Hi Nicolas, Hernan, > > (Adding Hernan in the recipients list) > > On 7/8/22 02:01, Nicolas Chautru wrote: >> This is targeting 22.11 and includes the PMD for the >> integrated accelerator on Intel Xeon SPR-EEC. >> There is a dependency on that parallel serie still in-flight >> which extends the bbdev api >> https://patches.dpdk.org/project/dpdk/list/?series=23894 >> >> I will be offline for a few weeks for the summer break but >> Hernan will cover for me during that time if required. >> >> Thanks >> Nic >> >> Nicolas Chautru (10): >>    baseband/acc200: introduce PMD for ACC200 >>    baseband/acc200: add HW register definitions >>    baseband/acc200: add info get function >>    baseband/acc200: add queue configuration >>    baseband/acc200: add LDPC processing functions >>    baseband/acc200: add LTE processing functions >>    baseband/acc200: add support for FFT operations >>    baseband/acc200: support interrupt >>    baseband/acc200: add device status and vf2pf comms >>    baseband/acc200: add PF configure companion function >> >>   MAINTAINERS                              |    3 + >>   app/test-bbdev/meson.build               |    3 + >>   app/test-bbdev/test_bbdev_perf.c         |   76 + >>   doc/guides/bbdevs/acc200.rst             |  244 ++ >>   doc/guides/bbdevs/index.rst              |    1 + >>   drivers/baseband/acc200/acc200_pf_enum.h |  468 +++ >>   drivers/baseband/acc200/acc200_pmd.h     |  690 ++++ >>   drivers/baseband/acc200/acc200_vf_enum.h |   89 + >>   drivers/baseband/acc200/meson.build      |    8 + >>   drivers/baseband/acc200/rte_acc200_cfg.h |  115 + >>   drivers/baseband/acc200/rte_acc200_pmd.c | 5403 >> ++++++++++++++++++++++++++++++ >>   drivers/baseband/acc200/version.map      |   10 + >>   drivers/baseband/meson.build             |    1 + >>   13 files changed, 7111 insertions(+) >>   create mode 100644 doc/guides/bbdevs/acc200.rst >>   create mode 100644 drivers/baseband/acc200/acc200_pf_enum.h >>   create mode 100644 drivers/baseband/acc200/acc200_pmd.h >>   create mode 100644 drivers/baseband/acc200/acc200_vf_enum.h >>   create mode 100644 drivers/baseband/acc200/meson.build >>   create mode 100644 drivers/baseband/acc200/rte_acc200_cfg.h >>   create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c >>   create mode 100644 drivers/baseband/acc200/version.map >> > > Comparing ACC200 & ACC100 header files, I understand ACC200 is an > evolution of the ACC10x family. The FEC bits are really close, ACC200 > main addition seems to be FFT acceleration which could be handled in > ACC10x driver based on device ID. > > I think both drivers have to be merged in order to avoid code > duplication. That's how other families of devices (e.g. i40e) are > handled. I haven't seen your reply on this point. Do you confirm you are working on a single driver for ACC family in order to avoid code duplication? Maxime > Thanks, > Maxime