From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 800FBA00C4; Fri, 18 Nov 2022 00:37:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EDFA4067B; Fri, 18 Nov 2022 00:37:05 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2070.outbound.protection.outlook.com [40.107.92.70]) by mails.dpdk.org (Postfix) with ESMTP id EA5714021F for ; Fri, 18 Nov 2022 00:37:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A59EViGhVdYF1PjZtKFp3dte1jZj/mRo6tKdY/KmFQ3xl5a1xNr7Bx0+js0pJtl5RaMYAdHoHXzkPQbMKLqGcrhKGoun55RsrUle4mXSZcRp0vy/AjUdNzeoXhKJCfy1IkrUqXFf3m8V0Ddvtxoex8iKyx+/gjw/t3P9OV3IopYXDqIbSM5+/tohvYpN0nzfwYiUEiu+SHyEmV5bdCymyAaMdcjLD1JU8w3bToYMGUhUMP8owNNLai+vZhGQpRdJ4xdjMA4BlBgXU9WLTUW7J2de+Y/UQYs9Nvnqs5CrjkWWfaZfk6M2EtjsT+GQU7UwGrSpKsZZFJ7nqD9vsdYNog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdBLb/Qmq+16SRnt3kTMaZdbK3Rfkoyw0j+MoULEIxk=; b=l5D8KRp9eBYDNmQqkEsHFesVy2QLML4F6kt01AM0v3wCDqPlGC8vHwaTx4olstTbiEsI4SMdB4PNI8mTbXMj/X8Qd9qWBIBDO8RG+hK/cGHpom0OLW0T+IAVbDJVk6PG5RmaJcxrmea2EGpZa9xxEupXQdONn0DCvK4eiSlNLLnMwtNJZFJcQVlaDRK2psmXv+m1azezf8GhKQcGqe1OGzypLYQlXIvWw84ZGxhlKk2+C0Zhct1hgPMdyn61uAH4Ag74G7SjHj3PMi91C/yN0oD1zghiKW83DsquxQDzvExq1T81bi0XjbEMQEcO/YxWN7TpD/h+k+QqR8m/TU73mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GdBLb/Qmq+16SRnt3kTMaZdbK3Rfkoyw0j+MoULEIxk=; b=MGWtMKc/yCFlXB3/rEqzxVSP2CtB0Y1L7jmgMeme1POoBdhtUotZPVWZEJNxZMj/ohPBGUILQHXoLwIOPvmvE5IB1a51Sonns00rDoYnip3Eo62EyT63J71ws2GQsetRZHjv45vF2VgRCfQQYSiOKh+YH7otzgSSvL7gTbl2wcc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB7632.namprd12.prod.outlook.com (2603:10b6:8:11f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov 2022 23:37:01 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5813.020; Thu, 17 Nov 2022 23:37:00 +0000 Message-ID: <51487d0b-6e85-bfe6-f76b-dc61aaea8d14@amd.com> Date: Thu, 17 Nov 2022 23:36:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/1] app/testpmd: add valid check to verify multi mempool feature To: Hanumanth Pothula , Aman Singh , Yuying Zhang , yingyax.han@intel.com, yux.jiang@intel.com Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net, jerinj@marvell.com, ndabilpuram@marvell.com References: <20221117125542.3091224-1-hpothula@marvell.com> <20221117160305.3361415-1-hpothula@marvell.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20221117160305.3361415-1-hpothula@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0352.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::28) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB7632:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ce181eb-2dba-4468-b025-08dac8f49f96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X+LSbY8dKMtpwNWljDYEzRsukIs2UDrOwjXt8QAuhIz5EvECEaGV/S0an+VF42Lr5F0R2VxeJIXppsjPdnC96/MCiZ7Lr53Y7wFoBz3KxGI/uM58GOujFlLYHcTq9JW3doD8T26x/Ua6faVda8m2bBV5bO4ON7MjV5Oc3OsP75mXbegOD/Fv1V8lsn7OaiM5/77fNq88F6SqlEMcZyf2hP4i+exhy61562xjaIBFNuGj1CnccwZC/xY2NftlPd/de95Wn16sZWfxNDD/TlqHyVoE9kjfIaxII/zLq2VkqF0E6uwCCXjk5VtbND6aiQRPibvKvdSbflCTSqgxiPbGrG1Wsc+4Bu8fXz69yv56+sB73Y3dUC9XZgxFs6KARtJ3ShZJrNLZM0lcYo9APDCXEZyM9ImfiDAYEHN8TF3b3PYRQwVTCEZQRZM3sAHBLmB2TaV/O3+PwkkGjggO32q8yuVqcnz7c45h8xwQ1uIG6+0MfPh9teAWzGgnlr8xSp33vgWzxlwCy2wHdIq1trPLUxWaGwYv//CrnAv0CI0QIU9u05auxNTarBjxrgvSJQJhhUh7SUkEcbs62ro3FMVaa0229bZE7YQADkISc/6f6vGMt1MninWNocpfAV/yfd0yffvIm8V8QaI67JXOX2bWorBpMh4fy+B02ChVE3QNOjpymi2jdJOZVv35matVmRsyBdNaCbh6Qe/0VFVKOMC9HYjYozoQSeP+UgcBxBpmuGA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(366004)(396003)(39860400002)(136003)(346002)(451199015)(2906002)(15650500001)(31686004)(316002)(83380400001)(41300700001)(66556008)(8676002)(36756003)(478600001)(66476007)(5660300002)(110136005)(6486002)(7416002)(8936002)(4326008)(44832011)(66946007)(2616005)(6506007)(186003)(6512007)(26005)(38100700002)(31696002)(86362001)(53546011)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWgrYUtEaFJkWnplQnhaWURXS09ydEtkN05nMDJBZ3A1bzF6VDd5T1hsVjly?= =?utf-8?B?dTJXbnQ2a2pMRjlmSkZYaTBSbUxCN3k4RWl3dmlDRHZUMXc2SDRtRGVBSWJa?= =?utf-8?B?dFU4bVAwQ1cxRjY2Y3ZUNnJETUt3WUt5RmhSSGRGdlQ1Tmh3eDdKQUlqRlRl?= =?utf-8?B?a3IzaklmZE9wL3VwU1BaY1lTRUFxYWtqVmVTMVo2RlJ2ODFuZmEwNEZPRjFu?= =?utf-8?B?aEI3cjRQWktZUHo4dFpFUkdjdGc1bnRDQ3pFcG1UOU5ndElJLzB2QXBQa0VJ?= =?utf-8?B?M3BHRERLYlBnZ2JzL1BydzkxUnhDRisxbEdzeDdKdkR0ODE0WWxQRHFPV2li?= =?utf-8?B?RG8vd1ZCT0hlZ0dPbjhBN2UrQ0VEN1JqT29TeWdaY2poOGxNZnphUjMvcG1a?= =?utf-8?B?OUV4S1h5b2xBUTZBNjdtcFc4RjcySXcxK2tPcnh1QmlpN2JPWDQ5Q3hNcHp0?= =?utf-8?B?NEFnVjh4STFVUjN4RVpMQVNNRUFDV0F3ZEQ3ZjBwWDZlNG4rbUsxNFRPT0x6?= =?utf-8?B?c1FrY1JrTG42RFY4YmkxdG55WWtMRG5yaUl6cSsxMk82UlpINkZ1Q0dQNW1o?= =?utf-8?B?N2hWWVJmdlN2M0VGVkZIL0Q0bWwxaVc4cGFvZWVUSWdHU1JzbXRtREVRb3lX?= =?utf-8?B?dWxmWkdFQXlJY2twUGVTUVRMMXFDK2R3VVdnQmo1ODFOVFFONTBTQldLZGc3?= =?utf-8?B?dVppMHo3SjN2WWUvcXE3M0MxUFhaL2RpZnlUVjRoYzZGRkNFL0hTMElsdDJM?= =?utf-8?B?ZHM3VnJnUjJ4S0R2QS9CdVpyMllnQVI0VHIrYzg0ZlBhZEJFd1kzWDZIblp5?= =?utf-8?B?N1lZVlpiOTFPbi9XRTN5M1pmMWJ2OGVjM1JyZzRTcVpNQ0k4T3VEYWlLbm9X?= =?utf-8?B?UDNpZGpIZjU2VkNFQ3FDTUcvT2grbDVlOFlqcTBMNmhPdERkTWF3N2pRVmN3?= =?utf-8?B?dE9Ya1J2WjRScXBVODhaOGREUzFmTkcyOXhKTVVjc1IxNnY3cVdCUVZRdkE2?= =?utf-8?B?MlBSUTI0ZllvL2hLT3hRZ1pQS2NBQWVscWRib01aT094Vm5qRFJLMjNDZG1R?= =?utf-8?B?Q2VmVmZFSVNnTHBSWFVjeEhkNjNqdXVRalFNOGtESVdjZGJqWE1WOXVMWkNN?= =?utf-8?B?emFxbmlEQ0xFSXNqQ1VnMEptNDZrZldoNFpob2hmelJSNTJMVS9RQS83L2Nn?= =?utf-8?B?SlRqNndYZXpQam16a3lmcFd1bkFaNDk5NGM1Q2c5K3RPVk9QSjhQRytPelll?= =?utf-8?B?amtpT0tGdmFHZHZCYnFpNzQrbG5UT0JWUEJhK2V0MjF0UEEzaE10bnRlR1lN?= =?utf-8?B?TC9IR012Nmh3WXVIcjVObkd1bEFCa3AzRHRKTlRFZGVjVnpiMlF6M1hYUTVJ?= =?utf-8?B?TXFKQ3VRYXhsbzdjdzB0UWplc1lhVVVvQ2xqZG15MStIWUwwdk9XYSthSGE2?= =?utf-8?B?dStFQUloT1FwNzZVdG16aGs0WWxnZXo5ck5ZbVhTRnZqQkpsUVg3MnE5S0pG?= =?utf-8?B?VlU5eHQ3bklwVFdsZmtzMTBRRWJKRTJxNy94ZWhab3AwS2pRb0tLT3VlNVk2?= =?utf-8?B?a1lOYjQzTitJNmk4ZGt0NlZhZ0lRZEtuUi85ZzJNdG5ORGdFNytpa0hGNytv?= =?utf-8?B?S1ZiYWZjVllRUWREcW1IeU14eWJLM1M0ZGdCQnpyWjV3bnlDUlI3N3hiVTZW?= =?utf-8?B?ZWtMSzNrT0xVc3V1L3dzVE9HOVovRVgyVmtIQTJnRUlrRGpSMXdsWWd2UXlG?= =?utf-8?B?WENOMm9KRGx1RWJZeFFPTVAvQnZocEdRa2E1Vmx5OTVsTGZDSTdhQXNrdDNo?= =?utf-8?B?VDhwdnVBSWxoUDNERUVBVVQwek84Ykp2TWNOTkZ4aHJrOXVYZ2xRUXJNNHEw?= =?utf-8?B?dXBVb21NaGdmWTdLYzJGcVN0MlVFZnZBRURma3YrSmhLc0pjLzNNQndIOE91?= =?utf-8?B?bjZvMithbDErNjllU1EyRVZDa2kremNNbmZodXNjNGl2eDdJNkkvNUNyQ2ZS?= =?utf-8?B?KzZOcXdpbDYxYVMraWc3ck1JQUpBdUpLSUFsWmZ1RzBFeS9EbUQ3RTYwMFhU?= =?utf-8?B?eXJnRjFVTkJlYXovMEcxaWRreGNPTmZ1QWxPcExqd1VaMDJpYk8rMjhEZGtI?= =?utf-8?Q?+4uWAKQhoQ15CRcU2ToJwtDmB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce181eb-2dba-4468-b025-08dac8f49f96 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 23:37:00.6842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iXx0g2lm4M4WFyQH8qsgVdjN58p2K/GdTqMchzgsW3nQcKNb9mFQsHgrurpVhZcf X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7632 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2022 4:03 PM, Hanumanth Pothula wrote: > Validate ethdev parameter 'max_rx_mempools' to know whether > device supports multi-mempool feature or not. > > Bugzilla ID: 1128 > > Signed-off-by: Hanumanth Pothula > v3: > - Simplified conditional check. > - Corrected spell, whether. > v2: > - Rebased on tip of next-net/main. > --- > app/test-pmd/testpmd.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 4e25f77c6a..6c3d0948ec 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2655,16 +2655,22 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > union rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {}; > struct rte_mempool *rx_mempool[MAX_MEMPOOL] = {}; > struct rte_mempool *mpx; > + struct rte_eth_dev_info dev_info; > unsigned int i, mp_n; > uint32_t prev_hdrs = 0; > int ret; > > + ret = rte_eth_dev_info_get(port_id, &dev_info); > + if (ret != 0) > + return ret; > + > /* Verify Rx queue configuration is single pool and segment or > * multiple pool/segment. > + * @see rte_eth_dev_info::max_rx_mempools > * @see rte_eth_rxconf::rx_mempools > * @see rte_eth_rxconf::rx_seg > */ > - if (!(mbuf_data_size_n > 1) && !(rx_pkt_nb_segs > 1 || > + if ((dev_info.max_rx_mempools == 0) && !(rx_pkt_nb_segs > 1 || > ((rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0))) { > /* Single pool/segment configuration */ > rx_conf->rx_seg = NULL; Hi Yingya, Yu, Can you please verify this patch? Thanks, ferruh