DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Hunt <david.hunt@intel.com>
To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/1] test/distributor: prevent return buffer overload
Date: Thu, 28 Jan 2021 16:46:14 +0000
Message-ID: <51558b31-018f-98ae-53e6-9494ebe02b7a@intel.com> (raw)
In-Reply-To: <20210119035910.8324-2-l.wojciechow@partner.samsung.com>

Hi Lukasz,

On 19/1/2021 3:59 AM, Lukasz Wojciechowski wrote:
> The distributor library implementation uses a cyclic queue to store
> packets returned from workers. These packets can be later collected
> with rte_distributor_returned_pkts() call.
> However the queue has limited capacity. It is able to contain only
> 127 packets (RTE_DISTRIB_RETURNS_MASK).
>
> Big burst tests sent 1024 packets in 32 packets bursts without waiting
> until they are processed by the distributor. In case when tests were
> run with big number of worker threads, it happened that more than
> 127 packets were returned from workers and put into cyclic queue.
> This caused packets to be dropped by the queue, making them impossible
> to be collected later with rte_distributor_returned_pkts() calls.
> However the test waited for all packets to be returned infinitely.
>
> This patch fixes the big burst test by not allowing more than
> queue capacity packets to be processed at the same time, making
> impossible to drop any packets.
> It also cleans up duplicated code in the same test.
>
> Bugzilla ID: 612
> Fixes: c0de0eb82e40 ("distributor: switch over to new API")
> Cc: david.hunt@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
> ---


This patch cleans up the code nicely, and it makes sense to return 
packets in the do..while. LGTM.


Reviewed-by: David Hunt <david.hunt@intel.com>




  parent reply	other threads:[~2021-01-28 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210119035920eucas1p15da5a04b73d19e63287dc14905d765f2@eucas1p1.samsung.com>
2021-01-19  3:59 ` [dpdk-dev] [PATCH v1 0/1] distributor test fix Lukasz Wojciechowski
     [not found]   ` <CGME20210119035921eucas1p1aaea0d68975ba9481f200912eb10a40e@eucas1p1.samsung.com>
2021-01-19  3:59     ` [dpdk-dev] [PATCH v1 1/1] test/distributor: prevent return buffer overload Lukasz Wojciechowski
2021-01-28 14:10       ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-01-29  8:03         ` David Marchand
2021-01-29 12:36           ` Lukasz Wojciechowski
2021-01-28 16:46       ` David Hunt [this message]
2021-01-19  8:44   ` [dpdk-dev] [PATCH v1 0/1] distributor test fix David Marchand
2021-01-19 13:06     ` Lukasz Wojciechowski
2021-01-28 13:34       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51558b31-018f-98ae-53e6-9494ebe02b7a@intel.com \
    --to=david.hunt@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=l.wojciechow@partner.samsung.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git