From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 757D5A0A02; Wed, 24 Mar 2021 18:39:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 290ED140F61; Wed, 24 Mar 2021 18:39:28 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id AD796140F57; Wed, 24 Mar 2021 18:39:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5197A5C0166; Wed, 24 Mar 2021 13:39:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 24 Mar 2021 13:39:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Px7UJ3SdSjCB55zHRAnbgQRxcsa75w+ed7V+GQrv0QA=; b=m83dn6nFfPhLxVm8 y5ryCK9x33FXKCXYWyAdzZdi4fxLSYJxWiPO1pJEjBjbKMpEL8boe+vPyz+42o5q GYAKoWApxMqzpkgsodgeR9GYSthv3+m5/0p4DmMaeLd0ju89lEbuXNrGNsVXMOWE PB5IWaoqWFrt25COgB7tSMirGf5f//nB8F6sMheO/qlTHKpcA7YExamHJQVARfc+ DHxs2M8UTJJj0+0xVP+Db2atZybqjk89FKShz25bj7k3eaKud8TeuaW4U2B76Cr7 wry8lV+CQXlHmZ5YvE244V023auETFKGFqsnXyo6fvH3JVhJatNWpI884oP3TsZz AIqvsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Px7UJ3SdSjCB55zHRAnbgQRxcsa75w+ed7V+GQrv0 QA=; b=BaKgJk7yvNe47f6vfX6ULRQ5sbivR5/51zI/zN6fowXJHuSfDTdY9tZui hyUBMvJVjQq/UOmW5xoz1wqdQRE/6A4zM9MabHuTPW133ovdx3vKhEJ5qvWf61vj vnn68SFBkbDeW2q5RN31UrGLgLwZJRmGhEkQKZFpB+8DcFuWt5L9jo/v6TAOrbII tJlW9QpoG1mXGXkHC+r0fX1i8RWjXlvvu6nWeujzAbTMdzsni5wc0YoBfNUR+Y8b GOSOAimuO8LnIoQ7V0yCIdSJz989i2HUXtM1g6jcLxLeO0pj+kOiEcIBYNWGuvuR f5HAXki+ZDo7srme4h5xbcVTP/OOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegkedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3DC6E24041F; Wed, 24 Mar 2021 13:39:25 -0400 (EDT) From: Thomas Monjalon To: Cristian Dumitrescu Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 24 Mar 2021 18:39:23 +0100 Message-ID: <5162052.h4inGi1Upy@thomas> In-Reply-To: <20210324113603.56624-1-cristian.dumitrescu@intel.com> References: <20210319143625.78445-1-cristian.dumitrescu@intel.com> <20210324113603.56624-1-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] pipeline: fix instruction translation for table and mailbox fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/03/2021 12:36, Cristian Dumitrescu: > The SWX pipeline instructions work with operands of different types: > header fields (h.header.field), packet meta-data (m.field), extern > object mailbox field (e.obj.field), extern function (f.field), action > data read from table entries (t.field), or immediate values; hence the > HMEFTI acronym. > > For some pipeline instructions (add/sub, srl/shr, jmplt/jmpgt), only > the H, M and I cases were handled, while the E, F and T cases were > disregarded. This is what we fix here. > > Fixes: baf7999303d0 ("pipeline: introduce SWX add instruction") > Fixes: c88c62943818 ("pipeline: introduce SWX subtract instruction") > Fixes: b09ba6d0a3c2 ("pipeline: introduce SWX SHL instruction") > Fixes: e0f51638b715 ("pipeline: introduce SWX SHR instruction") > Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions") > Cc: stable@dpdk.org > > Signed-off-by: Cristian Dumitrescu Applied, thanks