From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9A69A0548; Fri, 9 Jul 2021 15:46:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B1274068A; Fri, 9 Jul 2021 15:46:35 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id BEDDA4014D for ; Fri, 9 Jul 2021 15:46:33 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 2A5EB5802AF; Fri, 9 Jul 2021 09:46:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 09 Jul 2021 09:46:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= aISJrKe6z9cjxOsKcxgChHiOz3I0fIu8PCb0likSXkk=; b=Yc0h7dY9pwKv9sk1 R/Nh/RxPZP2YjgcEh8MJ59dSknoyRgA+k8FpK+sxQJhdqhR+mPUNxoWFvW4exNSt cJmFjEkoLDT/L0sHdy8iC9V/ODQSUJxwge06vRUsFhHYOf8A6ICny2hbLBB6YrFL gZM0Kc81STPtkLlkiiWRcYQx3c+phVDz3MQb9+gdvx5gCixeTeBaJFosu+qtL64/ XrUVwCyGzipyO45nanEkRxIgRXJQ0iop5obKh4bOhk5PIpadhG0yns+7JGjkS3KI Kqem1/0QfuaQF6lwUHM31mQBbMtHdENbY4h/0i+ZHZw6butTbAM5CXQkZ6tOqLRp AlXldA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=aISJrKe6z9cjxOsKcxgChHiOz3I0fIu8PCb0likSX kk=; b=SC84SpxhNJCNzwothK+wArn/5CPNxpbj+2bpDyczJHfdf/T5ZnybxobV3 2RxYSqKLTUSjr0Yp1bo4jdhoJV0RTXeodTBbJpHGBkvSu0B0JN+f7EX9iE/rhF4s bXcNt+ZDEkMH0prjcGmR9DtK0npMEp3rfZcOQbiUNArxM9nMWUf1M5YtkkfD8WQP UHPnPwMySmJ8lPk4FZB97kfvKJYdkb1YON8HLlK35ZhzacCb1fKtB7L16lh/zIlN fPZ78EDBAPUBJDkKAdiMTVhYSwnvX+579aDdTwAXlba0r85DGgFuTe40iR67uz7x Gk6uyKpe7xw0HGnfM56Q3M6KUiI1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdeigdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Jul 2021 09:46:30 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Timothy McDaniel , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Haiyue Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Bruce Richardson , Konstantin Ananyev , ciara.loftus@intel.com, david.hunt@intel.com, david.marchand@redhat.com Date: Fri, 09 Jul 2021 15:46:29 +0200 Message-ID: <5163386.RdNQYCoiaA@thomas> In-Reply-To: <7cfbd9da3abb3bfda399f5ea4de6a04233bf2ef2.1625753585.git.anatoly.burakov@intel.com> References: <7cfbd9da3abb3bfda399f5ea4de6a04233bf2ef2.1625753585.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/7] power_intrinsics: use callbacks for comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2021 16:13, Anatoly Burakov: > doc/guides/rel_notes/release_21_08.rst | 2 ++ > drivers/event/dlb2/dlb2.c | 17 ++++++++-- > drivers/net/i40e/i40e_rxtx.c | 20 +++++++---- > drivers/net/iavf/iavf_rxtx.c | 20 +++++++---- > drivers/net/ice/ice_rxtx.c | 20 +++++++---- > drivers/net/ixgbe/ixgbe_rxtx.c | 20 +++++++---- > drivers/net/mlx5/mlx5_rx.c | 17 ++++++++-- > .../include/generic/rte_power_intrinsics.h | 33 +++++++++++++++---- > lib/eal/x86/rte_power_intrinsics.c | 17 +++++----- > 9 files changed, 122 insertions(+), 44 deletions(-) About the title, it is introducing a new prefix "power_intrinsics:" with is not so much descriptive. Probably better to formulate with "eal:" prefix. > --- a/drivers/net/mlx5/mlx5_rx.c > +++ b/drivers/net/mlx5/mlx5_rx.c > @@ -269,6 +269,18 @@ mlx5_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id) > return rx_queue_count(rxq); > } > > +#define CLB_VAL_IDX 0 > +#define CLB_MSK_IDX 1 > +static int > +mlx_monitor_callback(const uint64_t value, > + const uint64_t opaque[RTE_POWER_MONITOR_OPAQUE_SZ]) Everything is prefixed with mlx5, let's be consistent. Please replace mlx_ with mlx5_