DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jiawei Wang <jiaweiw@nvidia.com>,
	viacheslavo@nvidia.com, matan@nvidia.com, orika@nvidia.com,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org,
	Kevin Traynor <ktraynor@redhat.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/mlx5: use global default miss for E-Switch sampling
Date: Wed, 27 Jan 2021 13:54:26 +0100	[thread overview]
Message-ID: <5166983.dj9CPtWFBN@thomas> (raw)
In-Reply-To: <11002ac2-1a6c-4be8-76ea-acdb25785e8a@intel.com>

27/01/2021 13:50, Ferruh Yigit:
> On 1/26/2021 12:53 PM, Jiawei Wang wrote:
> > In E-Switch steering domain there was dedicated default miss action
> > created for every sampling flow.
> > The patch replaces this one with the global default miss action.
> > 
> 
> Hi Jiawei,
> 
> The impact of the patch is not clear, what was the problem using action per 
> flow? What will change when global action is used? Is this fixing some problem 
> or is it optimization by preventing per flow action?
> 
> > Cc: stable@dpdk.org
> > 
> 
> Since this looks like optimization, I am removing the stable tag for now.
> 
> If it is a fix, please reply with a fixes line, I can update it in next-net.

Yes please we must avoid "Cc: stable" without a "Fixes:" line.




  reply	other threads:[~2021-01-27 12:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 12:53 [dpdk-dev] [PATCH 0/2] " Jiawei Wang
2021-01-26 12:53 ` [dpdk-dev] [PATCH 1/2] net/mlx5: fix the E-Switch sample action creation failure Jiawei Wang
2021-01-26 12:53 ` [dpdk-dev] [PATCH 2/2] net/mlx5: use global default miss for E-Switch sampling Jiawei Wang
2021-01-27 12:50   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-01-27 12:54     ` Thomas Monjalon [this message]
2021-01-27 15:25     ` Jiawei(Jonny) Wang
2021-01-27 12:29 ` [dpdk-dev] [PATCH 0/2] " Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5166983.dj9CPtWFBN@thomas \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jiaweiw@nvidia.com \
    --cc=ktraynor@redhat.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).