From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 90056A0093;
	Thu, 23 Jun 2022 12:52:33 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 32B9540042;
	Thu, 23 Jun 2022 12:52:33 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id B09B44003F
 for <dev@dpdk.org>; Thu, 23 Jun 2022 12:52:31 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 1B325A5;
 Thu, 23 Jun 2022 13:52:31 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1B325A5
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1655981551;
 bh=DyaF1mr9QDMe8/UpILj0yxkJvESbFn0sKZqMCmUt5xE=;
 h=Date:Subject:To:References:From:In-Reply-To:From;
 b=LSth4Y2fJ7iSu54kSlcu0+iauBMs3+orKA0qYPYmn4kROOAhxYZxzmCWTH77Ykfp3
 NTH/WumPBAn7bcjBktlWK037FMp5gveQN5TZJjY3zsBPBi9thGQD0EpuBnxQUift+P
 tWXXxFG9kbO9WqnsOsh21JgoqqEh7yo9u80a6pQ8=
Message-ID: <51743412-f3d2-7cfe-b2a7-8c3460fd0a45@oktetlabs.ru>
Date: Thu, 23 Jun 2022 13:52:30 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2] net/af_xdp: allow using copy mode in XSK
Content-Language: en-US
To: Xiaoyun Li <xiaoyun.li@intel.com>, ciara.loftus@intel.com,
 qi.z.zhang@intel.com, dev@dpdk.org
References: <20220613151231.1359592-1-xiaoyun.li@intel.com>
 <20220614091013.1407008-1-xiaoyun.li@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220614091013.1407008-1-xiaoyun.li@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 6/14/22 12:10, Xiaoyun Li wrote:
> DPDK assumes that users only want AF_XDP socket (XSK) into zero copy
> mode when the kernel supports it. However, sometimes kernel driver
> doesn't support it well and copy mode is more stable and preferred.
> 
> This patch allows using devarg "-a xx:xx.x,force_copy=1" to force the
> AF_XDP socket into copy mode.
> 
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
> v2:
> * Change name from no_zerocopy to force_copy.
> ---

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied to dpdk-next-net/main, thanks.