From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F1F2A053D; Wed, 5 Aug 2020 19:40:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC14E2C23; Wed, 5 Aug 2020 19:40:48 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D02702BB5 for ; Wed, 5 Aug 2020 19:40:47 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 547385C013E; Wed, 5 Aug 2020 13:40:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 13:40:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 8Ygh84VFg/Uzd3xx1mwO+h6zcBnXXYxUO8UzkQ6LJSg=; b=U43Qz8g/Yfiwfhjt PSLpPZfvzs0XIQUapr540rgaFHwehqSe13VnwSkUc3eXcuRQfOpud93A3WQ6Kdjy dFZt2yrJIDMvc5xTzqk3ysuwaq+ntUVuyaJsxYsjlsmbXDP5+IuCapPfiaayzRGP lKmmLGeTr5EXq4d8lfO4gSaiHMyjtpahpYEiaGOaCbd3szBF/IekX6HyKilcZDjH vpRN1ZrOpW4/8zVDTMq9p94VbjG7yKwFOabfXynXmmx0ft5hjFfbt7t8kD6NieR3 stwdvA7necfHE92GCFkkzXMskghiyVzddlvL2b3zQgXCM3qFBxd+IhD8m3xt6JSr jUiTnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=8Ygh84VFg/Uzd3xx1mwO+h6zcBnXXYxUO8UzkQ6LJ Sg=; b=Hr9PbeVNLGSsaCyzxENSNqZHUMxLIKw8lB/Snswpof3IChQpCiEyt8jti hcO932JxR4PuQiYINGGIpdGhgL3PApDIneMkFbSIYuSU0ksmPm9RAm2QrU4hhoIT WbkpA5cGX/QogNghPSyNnsbsSlzfEyhIKuJs2MN53oxm5MM0hJMHwADB6i1P7iEQ oEFTqIMjZDIVFKWih/GrTBKAeMjrd0eB7fgCydLdvrsML2R3CyRsVmaF2/ZO38Ew WjDYGXkSm64Ybh6O+3axq+pTA9ovMD9HeNGBTVEeRQl1xp8PaxMKXEIir4aTLUP3 P2YUBQ4z9SyjKCSeRX3WJxS5kQrWw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F10F5306005F; Wed, 5 Aug 2020 13:40:45 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: "Guo, Jia" , "Wu, Jingjing" , "Xing, Beilei" , dev@dpdk.org, "Guo, Junfeng" , "Su, Simei" Date: Wed, 05 Aug 2020 19:40:44 +0200 Message-ID: <5178903.5kADOQs6Yg@thomas> In-Reply-To: <039ED4275CED7440929022BC67E7061154873F82@SHSMSX103.ccr.corp.intel.com> References: <20200804025831.99919-1-jia.guo@intel.com> <039ED4275CED7440929022BC67E7061154873F82@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] net/iavf: fix hash default set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/08/2020 06:36, Zhang, Qi Z: > From: Guo, Jia > > > > Different device has different hash capability, it should not be expected that all > > hash set would be successful to set into all devices by default. So remove the > > return checking when hash default set. And remove gtpu hash default set, iavf > > only enable hash for general protocols. > > > > Fixes: c94366cfc641 ("net/iavf: add GTPU in default hash") > > Signed-off-by: Jeff Guo > > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. It looks it should be 2 separate patches: - revert/remove GTPU from default RSS hash - ignore error in adding protocols to RSS Please be more careful in patch reviews. PS: fixing name in Tested-by: Wei Xie