From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43])
 by dpdk.org (Postfix) with ESMTP id B5B6E256
 for <dev@dpdk.org>; Thu,  2 May 2013 11:18:52 +0200 (CEST)
Received: by mail-ee0-f43.google.com with SMTP id b15so165302eek.16
 for <dev@dpdk.org>; Thu, 02 May 2013 02:18:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=x-received:message-id:date:from:user-agent:mime-version:to:cc
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding:x-gm-message-state;
 bh=Vl7r6+hqcw5Nzx6nfHrEElEaQhKUcQkkNeOPZ3T1dJg=;
 b=PJJaiAUDBqBYgzxnziSrpZQ5E9bSpYDZ8zZpL3RdauNuV/5W2e6dXhJ5hTpsS4JWl7
 06vrhSDy63XRLR66mncv+fh/tZZx/X1OMGoNmyJAa30iAnl80RE9ahowIBTvQc7cuOW2
 6cZSVpIsNGSjj1WVdtNKpOsNV6W6syAgmzNKNg84WI/1D44b5nnFf5YOBJa5Z+2YLGa/
 PF92Tu3ijGtTuqhjG7s5QqrXTOSYq0KJ8f3lWwGLXftuXsDEZHh4OjjhldIoYmHOHh0e
 rgXb/l9aKu3koKRBsjFPzgOhPQiO9KnmNMSiqTLzcHqrm8C5x0ZzsMMJt7dAKd02AdP9
 ovtw==
X-Received: by 10.14.203.73 with SMTP id e49mr17454444eeo.20.1367486281087;
 Thu, 02 May 2013 02:18:01 -0700 (PDT)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id k43sm8424937een.2.2013.05.02.02.17.59
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Thu, 02 May 2013 02:18:00 -0700 (PDT)
Message-ID: <51822F49.5040406@6wind.com>
Date: Thu, 02 May 2013 11:18:01 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:10.0.6esrpre) Gecko/20120817 Icedove/10.0.6
MIME-Version: 1.0
To: dev@dpdk.org
References: <CAAYH+dX-4W-ZbmVEogRLMdy0KtT7iG249m18S7inp5TNW0j67g@mail.gmail.com>
 <518222B1.9050003@6wind.com>
In-Reply-To: <518222B1.9050003@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQl6YxW5PuzojuHmBnf8lnvkEXDxwNATL4k3e3rMf2gcWdPBst+kTtqduYNGN0qBrDJf8d1A
Cc: "Han, Dongsu" <dongsuh@cs.cmu.edu>
Subject: Re: [dpdk-dev] [PATCH] fixed buffer overrun in handling log messages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 May 2013 09:18:53 -0000

We can even do better, please see my next email (indeed we should not
send patch as attachment).

Olivier

On 05/02/2013 10:24 AM, Olivier MATZ wrote:
> Hi,
>
> Thank you for this patch. You are right, the '\0' is written
> outside the bounds of the buffer. I would suggest a minor modification
> to your patch, please see attachment.
>
> Regards,
> Olivier
>
>
> On 05/01/2013 08:50 PM, Han, Dongsu wrote:
>> I'm sending a proposed patch to fix the buffer overrun problem in
>> handling log messages.
>>
>> Dongsu Han
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@dpdk.org
>> http://dpdk.org/ml/listinfo/dev
>
>