From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 263108E7B for ; Fri, 11 Dec 2015 14:05:18 +0100 (CET) Received: by wmnn186 with SMTP id n186so30575155wmn.0 for ; Fri, 11 Dec 2015 05:05:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=ugn9bVgX7e9DaiUSy5Fo1Uo92KqwEll9BeOAc/6H+Fk=; b=eV9mDWTQKxcDDYJPT876HsS3hCOxJn9mZO2si0XX2/RcJUf7X/KH/5pW74TO1Q4ZQg fX5pSdWlEco9dVgXsAgcQieQCBZ17x1WflMyJv2akv7Va5+d5TdkvWYaAn8KfadcYZJc pXgkQPK0Tyzn1evIn0IiL9S28ajIZeDQ0fjXR0bn9bHzt2KnNIHW13s83HGIZWBhL659 6ayTaGn5Tb9JHTy6TImWSGeSA18+ZRFiXtU5uEJNC8bfB3oCLnRnMjO089GbTd8jPPz5 KDUEHwx40khPJyaqcvJpQqodwO7purc/jnZdPvFZImktirikM3JavRCQqiquDFwtBPEV vZvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ugn9bVgX7e9DaiUSy5Fo1Uo92KqwEll9BeOAc/6H+Fk=; b=WJPUyKsMqSWoVsE8jtcq2q4eDoZ43qajgdX7vLzAkPkNLggXlKU0zS4UX7r6bUyKav G13qKZyPbErZdeyaA4/68I0vbRAZKSo0FRUaDvEpC8u8eju/fnn6V/K8/zDLI0/k9L/h RwqTYQ4t5d1slQC/ewwiLdILYW9pWuioXde28YzP2Hf0+hk8DOnZl8ztMbzTJNwA9qdJ SRrrYjXU84dbNbI8BJKxPBREVXsioTe6i0MxM8HI7OiUyBrATddmcyxtPRyvyO6jbdN+ qZ1iRkp5nbip34C3GHT81vgEUfE0Kirek8IA7XBZlHHTIxRIimM6NykpNrWeQlJbLI55 yZFg== X-Gm-Message-State: ALoCoQkIAFCvdvUHTtqMIW6uNzn8H3wKCwduuc3oCz0FzENSSvdsEJjANkT1J1Gn9An1UrgIco+iUNT/BAIX4RqdBMwE74cs/g== X-Received: by 10.194.23.201 with SMTP id o9mr19572172wjf.30.1449839117783; Fri, 11 Dec 2015 05:05:17 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id jz1sm16906104wjc.27.2015.12.11.05.05.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Dec 2015 05:05:16 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Fri, 11 Dec 2015 14:04:01 +0100 Message-ID: <5188347.04ruq6Yd6l@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <37b46e91bdb51e6116df9a7edc2eb79206237f1c.1449837863.git.pmatilai@redhat.com> References: <37b46e91bdb51e6116df9a7edc2eb79206237f1c.1449837863.git.pmatilai@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] scripts: fix relpath.sh output when $prefix is set in environment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2015 13:05:18 -0000 2015-12-11 14:44, Panu Matilainen: > When relpath.sh is called from install target with prefix set, eg > "make install DESTDIR=/tmp/dpdk-root prefix=/usr", the prefix > from the environment leaks to relpath.sh internal helper variable and > causes incorrect symlinks to be generated in sdk $(targetdir): > > include -> /usr../../../include/dpdk > lib -> /usr../../../lib > > Initialize the local variable to empty to avoid side-effects from > environment. > > Signed-off-by: Panu Matilainen Good catch! Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree") Applied, thanks