From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 588F8DED for ; Tue, 21 Aug 2018 08:57:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Aug 2018 23:57:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,268,1531810800"; d="scan'208";a="83541002" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.71]) ([10.67.68.71]) by orsmga001.jf.intel.com with ESMTP; 20 Aug 2018 23:56:57 -0700 To: Andrew Rybchenko , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1534503091-31910-3-git-send-email-jia.guo@intel.com> <55ba4160-33e4-86a3-d5e3-4a414d9c5a8b@solarflare.com> Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com From: Jeff Guo Message-ID: <518f0c92-0faf-4791-2737-c764e20bba7c@intel.com> Date: Tue, 21 Aug 2018 14:56:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <55ba4160-33e4-86a3-d5e3-4a414d9c5a8b@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 2/5] eal: add a new req event to device event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 06:57:08 -0000 hi, andrew On 8/20/2018 6:37 PM, Andrew Rybchenko wrote: > On 17.08.2018 13:51, Jeff Guo wrote: >> Add a new req event in eal device event for vfio hotplug. When the req >> request send from the vfio kernel module be detected, vfio userpace >> driver could use this event to notify the app to handler it. >> >> Signed-off-by: Jeff Guo >> --- >> lib/librte_eal/common/include/rte_dev.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_eal/common/include/rte_dev.h >> b/lib/librte_eal/common/include/rte_dev.h >> index ff580a0..0324c84 100644 >> --- a/lib/librte_eal/common/include/rte_dev.h >> +++ b/lib/librte_eal/common/include/rte_dev.h >> @@ -30,6 +30,7 @@ extern "C" { >> enum rte_dev_event_type { >> RTE_DEV_EVENT_ADD, /**< device being added */ >> RTE_DEV_EVENT_REMOVE, /**< device being removed */ >> + RTE_DEV_EVENT_REQ, /**< device being removed */ > > Comment is the copy of previous one. > You are right here, even we process these type in the same way but should be considered it as the different type if we exactly want to add new one. so base on the interpret from the vfio kernel driver, this req event is used to require the user space to release the device resources, so it should be interpret it by "device release request". If you object and have other better idea, let me know. >> RTE_DEV_EVENT_MAX /**< max value of this enum */ >> }; >