From: Olivier MATZ <olivier.matz@6wind.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] mk: rule showconfigs for configs listing
Date: Fri, 17 May 2013 11:05:54 +0200 [thread overview]
Message-ID: <5195F2F2.60107@6wind.com> (raw)
In-Reply-To: <43533094849ffdacde83cad14c59364caa39d595.1367939814.git.thomas.monjalon@6wind.com>
Hi Thomas,
I wonder if this new rule is really needed: I think you can already
do a "make config" without argument to list the supported
configurations.
Olivier
On 05/07/2013 05:17 PM, Thomas Monjalon wrote:
> Allow to list configs in config/ directory with a simple make rule.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> mk/rte.sdkconfig.mk | 4 ++++
> mk/rte.sdkroot.mk | 4 ++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index ed81c47..179089e 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -36,6 +36,10 @@ INSTALL_CONFIGS := $(filter-out %~,\
> $(wildcard $(RTE_SRCDIR)/config/defconfig_*)))
> INSTALL_TARGETS := $(addsuffix _install,$(INSTALL_CONFIGS))
>
> +.PHONY: showconfigs
> +showconfigs:
> + @$(foreach CONFIG, $(INSTALL_CONFIGS), echo $(CONFIG);)
> +
> .PHONY: config
> ifeq ($(RTE_CONFIG_TEMPLATE),)
> config:
> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
> index f555e33..6bbbd54 100644
> --- a/mk/rte.sdkroot.mk
> +++ b/mk/rte.sdkroot.mk
> @@ -87,8 +87,8 @@ export ROOTDIRS-y ROOTDIRS- ROOTDIRS-n
> .PHONY: default
> default: all
>
> -.PHONY: config
> -config:
> +.PHONY: config showconfigs
> +config showconfigs:
> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@
>
> .PHONY: test fast_test ring_test mempool_test
next prev parent reply other threads:[~2013-05-17 9:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 15:17 [dpdk-dev] [PATCH 0/3] make help Thomas Monjalon
2013-05-07 15:17 ` [dpdk-dev] [PATCH 1/3] mk: rule showconfigs for configs listing Thomas Monjalon
2013-05-17 9:05 ` Olivier MATZ [this message]
2013-05-17 14:53 ` Thomas Monjalon
2013-05-07 15:17 ` [dpdk-dev] [PATCH 2/3] doc: how to build Thomas Monjalon
2013-05-17 9:06 ` Olivier MATZ
2013-05-17 15:20 ` Thomas Monjalon
2013-05-07 15:17 ` [dpdk-dev] [PATCH 3/3] mk: rule help Thomas Monjalon
2013-05-17 9:06 ` Olivier MATZ
2013-05-17 15:27 ` Thomas Monjalon
2013-05-28 22:15 ` [dpdk-dev] [PATCH v2 0/3] make help Thomas Monjalon
2013-05-28 22:15 ` [dpdk-dev] [PATCH v2 1/3] doc: how to build Thomas Monjalon
2013-05-28 22:15 ` [dpdk-dev] [PATCH v2 2/3] mk: rule showconfigs for configs listing Thomas Monjalon
2013-05-28 22:15 ` [dpdk-dev] [PATCH v2 3/3] mk: rule help Thomas Monjalon
2013-05-30 14:55 ` [dpdk-dev] [PATCH v2 0/3] make help Olivier MATZ
2013-05-30 22:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195F2F2.60107@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).