From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id AF3D921D for ; Fri, 17 May 2013 11:03:10 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.11]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1UdGa6-00051I-DS for dev@dpdk.org; Fri, 17 May 2013 11:04:10 +0200 Message-ID: <5195F2F2.60107@6wind.com> Date: Fri, 17 May 2013 11:05:54 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: dev@dpdk.org References: <43533094849ffdacde83cad14c59364caa39d595.1367939814.git.thomas.monjalon@6wind.com> In-Reply-To: <43533094849ffdacde83cad14c59364caa39d595.1367939814.git.thomas.monjalon@6wind.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] mk: rule showconfigs for configs listing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2013 09:03:10 -0000 Hi Thomas, I wonder if this new rule is really needed: I think you can already do a "make config" without argument to list the supported configurations. Olivier On 05/07/2013 05:17 PM, Thomas Monjalon wrote: > Allow to list configs in config/ directory with a simple make rule. > > Signed-off-by: Thomas Monjalon > --- > mk/rte.sdkconfig.mk | 4 ++++ > mk/rte.sdkroot.mk | 4 ++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk > index ed81c47..179089e 100644 > --- a/mk/rte.sdkconfig.mk > +++ b/mk/rte.sdkconfig.mk > @@ -36,6 +36,10 @@ INSTALL_CONFIGS := $(filter-out %~,\ > $(wildcard $(RTE_SRCDIR)/config/defconfig_*))) > INSTALL_TARGETS := $(addsuffix _install,$(INSTALL_CONFIGS)) > > +.PHONY: showconfigs > +showconfigs: > + @$(foreach CONFIG, $(INSTALL_CONFIGS), echo $(CONFIG);) > + > .PHONY: config > ifeq ($(RTE_CONFIG_TEMPLATE),) > config: > diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk > index f555e33..6bbbd54 100644 > --- a/mk/rte.sdkroot.mk > +++ b/mk/rte.sdkroot.mk > @@ -87,8 +87,8 @@ export ROOTDIRS-y ROOTDIRS- ROOTDIRS-n > .PHONY: default > default: all > > -.PHONY: config > -config: > +.PHONY: config showconfigs > +config showconfigs: > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ > > .PHONY: test fast_test ring_test mempool_test