From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 300FD21D
 for <dev@dpdk.org>; Fri, 17 May 2013 11:09:40 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.11]) by mail.droids-corp.org with esmtpsa
 (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80)
 (envelope-from <olivier.matz@6wind.com>) id 1UdGgO-00051b-7B
 for dev@dpdk.org; Fri, 17 May 2013 11:10:39 +0200
Message-ID: <5195F477.1050501@6wind.com>
Date: Fri, 17 May 2013 11:12:23 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:10.0.12) Gecko/20130116 Icedove/10.0.12
MIME-Version: 1.0
To: dev@dpdk.org
References: <1367940644-13357-1-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1367940644-13357-1-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] lib: set version 1.2.3r2 and more helper
	macros
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 May 2013 09:09:40 -0000

Hi Thomas,

> @@ -75,7 +87,8 @@ rte_version(void) {
>  	return RTE_VER_PREFIX" "
>  			RTE_STR(RTE_VER_MAJOR)"."
>  			RTE_STR(RTE_VER_MINOR)"."
> -			RTE_STR(RTE_VER_PATCH_LEVEL);
> +			RTE_STR(RTE_VER_PATCH_LEVEL)"r"
> +			RTE_STR(RTE_VER_PATCH_RELEASE);
>  }
>  
>  #ifdef __cplusplus

In this patch, do you think it could be useful to add
a #ifdef RTE_VER_PATCH_RELEASE ? The idea is to return
"1.2.3" if there is no patch release and "1.2.3r4" in
the dpdk.org case. As a result this patch would be integrable
in Intel DPDK mainline.

The other lines of the patch look good to me.

Olivier