DPDK patches and discussions
 help / color / mirror / Atom feed
From: Juraj Linkeš <juraj.linkes@pantheon.tech>
To: Thierry Herbelot <thierry.herbelot@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>, oulijun <oulijun@huawei.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	"linuxarm@openeuler.org" <linuxarm@openeuler.org>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
Date: Wed, 24 Feb 2021 11:44:37 +0000
Message-ID: <5199b057da7d41f3bdd187008ea869a9@pantheon.tech> (raw)
In-Reply-To: <70792902-0237-0a45-9479-5e97bf3d02c7@6wind.com>



> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Wednesday, February 24, 2021 12:02 PM
> To: dev@dpdk.org; oulijun <oulijun@huawei.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>; Bruce Richardson
> <bruce.richardson@intel.com>; linuxarm@openeuler.org;
> ferruh.yigit@intel.com
> Subject: Re: [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
> 
> > Message: 4
> > Date: Wed, 24 Feb 2021 11:24:27 +0100
> > From: Thomas Monjalon <thomas@monjalon.net>
> > To: oulijun <oulijun@huawei.com>
> > Cc: ferruh.yigit@intel.com, dev@dpdk.org, linuxarm@openeuler.org,
> > 	juraj.linkes@pantheon.tech, bruce.richardson@intel.com
> > Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon
> > 	kunpeng920 SoC build
> > Message-ID: <5309744.5Ik2CEZAj8@thomas>
> > Content-Type: text/plain; charset="UTF-8"
> >
> > 24/02/2021 10:17, oulijun:
> >>
> >> ? 2021/2/24 15:41, Thomas Monjalon ??:
> >>> 24/02/2021 02:34, oulijun:
> >>>>
> >>>> ? 2021/2/10 17:41, Thomas Monjalon ??:
> >>>>> 03/02/2021 13:46, Lijun Ou:
> >>>>>> From: Chengchang Tang <tangchengchang@huawei.com>
> >>>>>>
> >>>>>> Because of the '9ca2f16' have merged, the current hns3 pmd driver
> >>>>>> can not be directly complied on the kunpeng920 server board.
> >>>>>> Therefore, we need to fix the meson build.
> >>>>>> Besides, add kunpeng 920 SoC meson cross compile target.
> >>>>>>
> >>>>>> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> >>>>>
> >>>>> Why do you think this patch is fixing the one above?
> >>>>> It looks just a new config, not a fix. Am I missing something?
> >>>>>
> >>>> I'm sorry to see you so late. In the meantime, we are celebrating
> >>>> the Spring Festival. This patch fixes the problem. If the patch is
> >>>> not added, the latest version cannot be directly compiled on the
> >>>> Kunpeng 930 server board.In addition, the cross compilation configuration
> file is added.
> >>>
> >>> Please can you explain what was removed which breaks your compilation?
> >>>
> >> I understand that implementation_id is identified in 9ca2f16. If the
> >> configuration file does not contain implementation_id, it will be
> >> displayed as unsupported.
> >>
> >> The error as follows:
> >> config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported
> >> Arm implementer: 0x48. Please add support for it or use the generic
> >> (-Dmachine=generic) build.
> >>
> >> Besides, we use the -Dmachine=generic, the bug is not resolved.
> >> the cmd as:
> >>    meson build or meson -Dmachine=generic build
> >
> > What is the result of a generic build?
> 
> Hello,
> 
> Following dpdk commit 91c730fd4e093cd, the generic compilation for Arm is
> selected with '-Dmachine=default'
> 
> The comments in config/arm/meson.build should be updated to follow the
> change in default machine name:
> https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n241
> https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n256
> 

Good catch, this is because http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email-juraj.linkes@pantheon.tech/ was part of the same patch series as 9ca2f16faa7f. When the former patch was removed from the series, not everything in the series got properly updated.

Lijun, please try "meson -Dmachine=default build". This should result in the same behavior as before 9ca2f16faa7f.

> 	Regards
> 
> 	Thierry
> >
> >


  reply	other threads:[~2021-02-24 11:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.4282.1614163031.25471.dev@dpdk.org>
2021-02-24 11:02 ` Thierry Herbelot
2021-02-24 11:44   ` Juraj Linkeš [this message]
2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
2021-02-10  9:41   ` Thomas Monjalon
2021-02-24  1:34     ` oulijun
2021-02-24  7:41       ` Thomas Monjalon
2021-02-24  9:17         ` oulijun
2021-02-24 10:24           ` Thomas Monjalon
2021-02-24 11:55         ` Juraj Linkeš
2021-02-24 12:09           ` Thomas Monjalon
2021-03-01 10:46             ` Juraj Linkeš
2021-03-05  1:36               ` oulijun
2021-03-22  1:01                 ` Min Hu (Connor)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5199b057da7d41f3bdd187008ea869a9@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=linuxarm@openeuler.org \
    --cc=oulijun@huawei.com \
    --cc=thierry.herbelot@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git