From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-x22a.google.com (mail-ee0-x22a.google.com [IPv6:2a00:1450:4013:c00::22a]) by dpdk.org (Postfix) with ESMTP id DDB3D532D for ; Wed, 5 Jun 2013 20:05:52 +0200 (CEST) Received: by mail-ee0-f42.google.com with SMTP id c4so559675eek.15 for ; Wed, 05 Jun 2013 11:06:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:organization:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding:x-gm-message-state; bh=O6fVShSscgkEMzEQ2Q8cuFQXiLlRnVVTL31JFrE1dEc=; b=DHaRsLc80z5p4M7IXJMCF+GDg4X6tILjxvUMJzVLoLoSw5tqRC5DX7nwq+g+PqNTRE xXj6441HIgRw+2Yo4DGak68vyn+3dPpJreA8tsdWxUv19Qv5JUVab0JJKS8DTZj/zppz TXpxuV+lR4GrPLp41ceZVyY2/s02fOi1kmN/Dn1ZKi5B1P48c6uAN2GlRYf8a7dJeOei 5mVrpsAuRJgBIfEyqvRFQdWLglmjvuf/EoVwlCzca1YiQ0DCUQXjHw+LuvFaqZ3v4gqx jGGNky0k5Kw9DpZn1dXb4NTcg23jxeUR76tT8sa2zWBI3dpt2ZcdNdgECszIQ4cwJx+s aH2g== X-Received: by 10.14.203.7 with SMTP id e7mr11918367eeo.118.1370455560373; Wed, 05 Jun 2013 11:06:00 -0700 (PDT) Received: from [192.168.0.11] (mic92-3-81-56-67-82.fbx.proxad.net. [81.56.67.82]) by mx.google.com with ESMTPSA id g7sm99531179eew.15.2013.06.05.11.05.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 05 Jun 2013 11:05:59 -0700 (PDT) Message-ID: <51AF7DDB.1070005@6wind.com> Date: Wed, 05 Jun 2013 20:05:15 +0200 From: Damien Millescamps Organization: 6WIND S.A. User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: dev@dpdk.org References: <20130530171234.301927271@vyatta.com> <20130530171627.005239011@vyatta.com> <51AF501B.5060306@6wind.com> <20130605084927.34f138c1@nehalam.linuxnetplumber.net> In-Reply-To: <20130605084927.34f138c1@nehalam.linuxnetplumber.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQnn8b7X/wCMmwfUOj5c1xAfArXXoRfEpjlE+e+S22qutGuA/qlegqH+gossnauS0cYEyuUN Subject: Re: [dpdk-dev] [PATCH 5/7] pci: support multiple PCI regions per device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2013 18:05:53 -0000 On 06/05/2013 05:49 PM, Stephen Hemminger wrote: > On Wed, 05 Jun 2013 16:50:03 +0200 > Damien Millescamps wrote: > >> Hi Stephen, >> >> Overall this patch is very nice. My only comment on this one is why do >> you limit the max number of memory resources to 5 ? >> The PCI configuration space permits to store up to 6 base addresses. >> >>> +#define PCI_MEM_RESOURCE 5 >> Please, can you add a log/comment with your patch, too ? >> >> >> Cheers, > Only because I was trying to save some space, and I didn't see any hardware > with that many useful regions. Also the kernel UIO driver has some control > over which regions get exposed. I agree that hardware generally don't use that much BAR for the PCIe. However, this is only a matter of 20 to 24 Bytes, so I don't see any reason not defining this macro as per the PCI standard value. Could you add a commit log and change that so it can be ack'd and pushed in the DPDK repository ? Thanks, -- Damien Millescamps