From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-bk0-x235.google.com (mail-bk0-x235.google.com
 [IPv6:2a00:1450:4008:c01::235])
 by dpdk.org (Postfix) with ESMTP id B37AD532D
 for <dev@dpdk.org>; Wed, 12 Jun 2013 16:46:04 +0200 (CEST)
Received: by mail-bk0-f53.google.com with SMTP id e11so4017329bkh.40
 for <dev@dpdk.org>; Wed, 12 Jun 2013 07:46:09 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=message-id:date:from:user-agent:mime-version:to:cc:subject
 :references:in-reply-to:content-type:content-transfer-encoding
 :x-gm-message-state;
 bh=dekY/F1rVxcp7wIhX9gnNNjFpxddwu05/RrHP3TtGyo=;
 b=OChdsq0/2zvmH002dK+kluztIgaQowE3i+gWCJ4gYsubFAKWkV7Jz8PVFYw0J0hc+u
 2FZ+Yw68XwDEoMgI6ptbsI5U6tBva6nfIJo79JqDmK9kKdakYQa+ED1bZb0PwXf/h/9Z
 l8XHKvai2lH+siQhkYYUuXDIVbJrB2wzUD7MD16YHAY2SlPPguFgiOP+M15NiaSJnmfG
 bhmLBvgpO6M9jZmKeNxLOx23nQ19debAeTwJJiQfFmL3o45lAjMwDalmdffqEiMkoNFi
 c3IOldm7CLJGijjV8a4ehHhKq3bR9+IF/9nE2zM+d1fNG98so6rBoH3uhhyUymqH0vmA
 vRag==
X-Received: by 10.205.41.70 with SMTP id tt6mr3129247bkb.171.1371048369139;
 Wed, 12 Jun 2013 07:46:09 -0700 (PDT)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id og1sm7905243bkb.16.2013.06.12.07.46.07
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 12 Jun 2013 07:46:08 -0700 (PDT)
Message-ID: <51B889B2.9050105@6wind.com>
Date: Wed, 12 Jun 2013 16:46:10 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:10.0.6esrpre) Gecko/20120817 Icedove/10.0.6
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <201306121539.49552.thomas.monjalon@6wind.com>
 <1371047405-29432-1-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1371047405-29432-1-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQnT59LyVIcK7C6LtgY5EXsqefl+JTK9RHO8FqhfesqQCqoO5lzqWZO357qy2/xU6YlHrx7U
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix empty struct rte_eth_txmode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jun 2013 14:46:05 -0000

On 06/12/2013 04:30 PM, Thomas Monjalon wrote:
> The previous fix was for g++ but is broken with gcc:
> 	error: flexible array member in otherwise empty struct
> See http://gcc.gnu.org/onlinedocs/gcc-4.2.2/gcc/Zero-Length.html
>
> Let's fix it with #ifdef __cplusplus.

Sorry Thomas for the previous one, I should have tested it.

This one looks good, I checked compilation and it works with
gcc-4.6.3 and g++-4.6.3