From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: Pascal Mazon <pascal.mazon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/tap: add support for fixed mac addresses
Date: Tue, 11 Apr 2017 13:41:13 +0000 [thread overview]
Message-ID: <51DB254E-F1A8-419F-B616-EBA1419CDD3B@intel.com> (raw)
In-Reply-To: <bc289d23-5c2a-2960-3ecc-9302a5499b45@intel.com>
> On Apr 11, 2017, at 8:39 AM, Yigit, Ferruh <ferruh.yigit@intel.com> wrote:
>
> On 4/11/2017 2:23 PM, Wiles, Keith wrote:
>>
>>> On Apr 11, 2017, at 2:18 AM, Pascal Mazon <pascal.mazon@6wind.com> wrote:
>>>
>>> Hi Keith,
>>>
>>> I have a few comments on your patch, see inline.
>>>
>>> On Mon, 10 Apr 2017 13:18:50 -0500
>>> Keith Wiles <keith.wiles@intel.com> wrote:
>>>
>>>> Support for a fixed MAC address for testing with the last octet
>>>> incrementing by one for each interface defined with the new 'mac=fixed'
>>>> string on the --vdev option. The default option is still to randomize
>>>> the MAC address for each tap interface.
>>>>
>>>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>
> <...>
>
>>>> +
>>>> +#ifdef IFF_MULTI_QUEUE
>>>> +#define RTE_PMD_TAP_MAX_QUEUES 16
>>>> +#else
>>>> +#define RTE_PMD_TAP_MAX_QUEUES 1
>>>> +#endif
>>>
>>> Remove this IFF_MULTI_QUEUE definition as it is done in rte_eth_tap.h now (needed for pmd_internals).
>>
>> This should have been removed in your patch
>
> That is already done, and patch is in main repo:
> Fixes: 947d949de7de ("net/tap: fix max queues redefinition")
>
>> and now that Ferruh wants you to submit a patch for the string at the bottom of the PMD, can you remove it?
>
> Pascal already send the patch and it is in next-net now:
> Fixes: f0e5085f4677 ("net/tap: update driver param string")
>
>>
>> I can do both in my patch, but Ferruh and you need to agree before I can submit my patch.
>
> There is no more updated expected, using latest next-net should be OK to
> submit your patch.
OK
>
> Thanks,
> ferruh
Regards,
Keith
next prev parent reply other threads:[~2017-04-11 13:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 18:18 Keith Wiles
2017-04-11 7:18 ` Pascal Mazon
2017-04-11 8:31 ` Ferruh Yigit
2017-04-11 13:23 ` Wiles, Keith
2017-04-11 13:25 ` Wiles, Keith
2017-04-11 13:39 ` Ferruh Yigit
2017-04-11 13:41 ` Wiles, Keith [this message]
2017-04-11 13:54 ` Pascal Mazon
2017-04-11 14:17 ` Wiles, Keith
2017-04-11 15:09 ` Pascal Mazon
2017-04-11 15:38 ` Wiles, Keith
2017-04-11 15:42 ` Wiles, Keith
2017-04-11 15:49 ` Ferruh Yigit
2017-04-11 16:16 ` Wiles, Keith
2017-04-12 7:30 ` [dpdk-dev] [PATCH v2] " Pascal Mazon
2017-04-14 9:45 ` Ferruh Yigit
2017-05-12 12:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DB254E-F1A8-419F-B616-EBA1419CDD3B@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pascal.mazon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).