From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 999BB2986 for ; Tue, 11 Apr 2017 15:41:15 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2017 06:41:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,185,1488873600"; d="scan'208";a="87746459" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 11 Apr 2017 06:41:14 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 11 Apr 2017 06:41:14 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.235]) by FMSMSX112.amr.corp.intel.com ([169.254.5.65]) with mapi id 14.03.0319.002; Tue, 11 Apr 2017 06:41:14 -0700 From: "Wiles, Keith" To: "Yigit, Ferruh" CC: Pascal Mazon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/tap: add support for fixed mac addresses Thread-Index: AQHSsib8ksIIBxsBsUq6QitCJudBlKHAOMeAgABl2oCAAASUAIAAAGWA Date: Tue, 11 Apr 2017 13:41:13 +0000 Message-ID: <51DB254E-F1A8-419F-B616-EBA1419CDD3B@intel.com> References: <20170410181850.44845-1-keith.wiles@intel.com> <20170411091851.62ab28ad@paques.dev.6wind.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.98.247] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: add support for fixed mac addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 13:41:16 -0000 > On Apr 11, 2017, at 8:39 AM, Yigit, Ferruh wrote= : >=20 > On 4/11/2017 2:23 PM, Wiles, Keith wrote: >>=20 >>> On Apr 11, 2017, at 2:18 AM, Pascal Mazon wrot= e: >>>=20 >>> Hi Keith, >>>=20 >>> I have a few comments on your patch, see inline. >>>=20 >>> On Mon, 10 Apr 2017 13:18:50 -0500 >>> Keith Wiles wrote: >>>=20 >>>> Support for a fixed MAC address for testing with the last octet >>>> incrementing by one for each interface defined with the new 'mac=3Dfix= ed' >>>> string on the --vdev option. The default option is still to randomize >>>> the MAC address for each tap interface. >>>>=20 >>>> Signed-off-by: Keith Wiles >=20 > <...> >=20 >>>> + >>>> +#ifdef IFF_MULTI_QUEUE >>>> +#define RTE_PMD_TAP_MAX_QUEUES 16 >>>> +#else >>>> +#define RTE_PMD_TAP_MAX_QUEUES 1 >>>> +#endif >>>=20 >>> Remove this IFF_MULTI_QUEUE definition as it is done in rte_eth_tap.h n= ow (needed for pmd_internals). >>=20 >> This should have been removed in your patch=20 >=20 > That is already done, and patch is in main repo: > Fixes: 947d949de7de ("net/tap: fix max queues redefinition") >=20 >> and now that Ferruh wants you to submit a patch for the string at the bo= ttom of the PMD, can you remove it? >=20 > Pascal already send the patch and it is in next-net now: > Fixes: f0e5085f4677 ("net/tap: update driver param string") >=20 >>=20 >> I can do both in my patch, but Ferruh and you need to agree before I can= submit my patch. >=20 > There is no more updated expected, using latest next-net should be OK to > submit your patch. OK >=20 > Thanks, > ferruh Regards, Keith