From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id F107AA2EEB
for <public@inbox.dpdk.org>; Tue, 10 Sep 2019 12:00:00 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id AED1E1ED8A;
Tue, 10 Sep 2019 11:59:59 +0200 (CEST)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 5EED61E554
for <dev@dpdk.org>; Tue, 10 Sep 2019 11:59:56 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
10 Sep 2019 02:59:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="184113627"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
by fmsmga008.fm.intel.com with ESMTP; 10 Sep 2019 02:59:54 -0700
Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by
FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Tue, 10 Sep 2019 02:59:54 -0700
Received: from lcsmsx155.ger.corp.intel.com (10.186.165.233) by
fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Tue, 10 Sep 2019 02:59:54 -0700
Received: from hasmsx113.ger.corp.intel.com ([169.254.13.177]) by
LCSMSX155.ger.corp.intel.com ([169.254.12.83]) with mapi id 14.03.0439.000;
Tue, 10 Sep 2019 12:59:52 +0300
From: "Zapolski, MarcinX A" <marcinx.a.zapolski@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from
public API
Thread-Index: AQHVZLYTzdmBMJkf+0y1UM2/wAYG6Kcksf5g
Date: Tue, 10 Sep 2019 09:59:51 +0000
Message-ID: <51FEE37A1339864DB0A4E34597F561E30D5D6FCC@HASMSX113.ger.corp.intel.com>
References: <20190730124950.1293-1-marcinx.a.zapolski@intel.com>
<20190906131813.1343-2-marcinx.a.zapolski@intel.com>
In-Reply-To: <20190906131813.1343-2-marcinx.a.zapolski@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2UwZTFjMTAtYzVmYS00ODgzLTgyNmQtZWE0ZmJhODA1Yzk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUmVhaSs4b2R5SjE3TlpObVV6c1J3RHh0R2dtYWlHTzRZUWZIMzYzOVhzNFdRR2JIQTFKSEJMRG8waUdXS2dHZCJ9
x-ctpclassification: CTP_NT
x-originating-ip: [10.184.70.11]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev
structures from public API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
<...>
> @@ -3994,7 +4054,55 @@ void *
> rte_eth_dev_get_sec_ctx(uint16_t port_id);
>=20
>=20
> -#include <rte_ethdev_core.h>
> +struct rte_eth_dev_callback;
> +/** Structure to keep track of registered callbacks */
> +TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);
> +
> +/**
> + * Structure used to hold information about the callbacks to be called f=
or a
> + * queue on RX and TX.
> + */
> +struct rte_eth_rxtx_callback {
> + struct rte_eth_rxtx_callback *next;
> + union{
> + rte_rx_callback_fn rx;
> + rte_tx_callback_fn tx;
> + } fn;
> + void *param;
> +};
> +
> +/**
> + * The generic data structure associated with each ethernet device.
> + *
> + * Pointers to burst-oriented packet receive and transmit functions are
> + * located at the beginning of the structure, along with the pointer to
> + * where all the data elements for the particular device are stored in s=
hared
> + * memory. This split allows the function pointer and driver data to be =
per-
> + * process, while the actual configuration data for the device is shared=
.
> + */
I would like to raise one more concern (maybe not the smartest thing to do
involving my own patch, but I will sleep better when this is resolved).
Does anyone know what the author of this comment had in mind? I could not f=
ind
any code that utilizes this split, and this patch clearly breaks it. If it =
is
obsolete, I guess this comment could be removed.