DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Rong, Leyi" <leyi.rong@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, dev <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path
Date: Tue, 27 Oct 2020 10:22:34 +0000
Message-ID: <51b0a34b-5732-ef5c-52d0-4ace74226304@intel.com> (raw)
In-Reply-To: <SN6PR11MB2621E22E8BA7B5DF60FD3047EC190@SN6PR11MB2621.namprd11.prod.outlook.com>

On 10/26/2020 7:12 AM, Rong, Leyi wrote:
> 
>> -----Original Message-----
>> From: David Marchand <david.marchand@redhat.com>
>> Sent: Monday, October 26, 2020 12:24 AM
>> To: Rong, Leyi <leyi.rong@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit,
>> Ferruh <ferruh.yigit@intel.com>
>> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev <dev@dpdk.org>; Richardson,
>> Bruce <bruce.richardson@intel.com>; Thomas Monjalon
>> <thomas@monjalon.net>
>> Subject: Re: [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path
>>
>> Hello Leyi, Qi, Ferruh,
>>
>> On Fri, Oct 23, 2020 at 6:37 AM Leyi Rong <leyi.rong@intel.com> wrote:
>>> diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build
>>> index 254595af85..85e8baf912 100644
>>> --- a/drivers/net/ice/meson.build
>>> +++ b/drivers/net/ice/meson.build
>>> @@ -34,6 +34,17 @@ if arch_subdir == 'x86'
>>>                                  c_args: [cflags, '-mavx2'])
>>>                  objs += ice_avx2_lib.extract_objects('ice_rxtx_vec_avx2.c')
>>>          endif
>>> +
>>> +       if dpdk_conf.has('RTE_MACHINE_CPUFLAG_AVX512F') or (not
>> machine_args.contains('-mno-avx512f') and cc.has_argument('-mavx512f'))
>>> +               cflags += ['-DCC_AVX512_SUPPORT']
>>> +               ice_avx512_lib = static_library('ice_avx512_lib',
>>> +                                     'ice_rxtx_vec_avx512.c',
>>> +                                     dependencies: [static_rte_ethdev,
>>> +                                       static_rte_kvargs, static_rte_hash],
>>> +                                     include_directories: includes,
>>> +                                     c_args: [cflags, '-march=skylake-avx512', '-mavx512f'])
>>> +               objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c')
>>> +       endif
>>>   endif
>>>
>>>   sources += files('ice_dcf.c',
>>> --
>>> 2.17.1
>>>
>>
>> RTE_MACHINE_CPUFLAG_AVX512F can be removed.
>> Worth fixing before hitting the main tree.
>>
>> Thanks.
>>
>> --
>> David Marchand
> 
> Hello David,
> 
> Would prefer using __AVX512F__ instead of RTE_MACHINE_CPUFLAG_AVX512F here rather than remove the RTE_MACHINE_CPUFLAG_ macro directly to check the CPU capability.
> So the judgment statement will be
> if cc.get_define('__AVX512F__', args: machine_args) != '' or (not machine_args.contains('-mno-avx512f') and cc.has_argument('-mavx512f'))
> 
> what do you think?
> 
> 
> Hello Ferruh,
> 
> As the patchset is already merged into dpdk-next-net, I'm going to make another patch for this if it's accepted?
> 

Hi Leyi,

Please make another patch, I can squash it in the next-net.

Thanks,
ferruh

  parent reply	other threads:[~2020-10-27 10:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  6:55 [dpdk-dev] [PATCH v1 0/2] AVX512 vPMD on ice Leyi Rong
2020-09-10  6:55 ` [dpdk-dev] [PATCH v1 1/2] net/ice: add AVX512 vector path Leyi Rong
2020-09-10  9:32   ` Bruce Richardson
2020-09-10  6:55 ` [dpdk-dev] [PATCH v1 2/2] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-09-15  1:17   ` Wang, Haiyue
2020-09-18  3:35 ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on ice Leyi Rong
2020-09-18  3:35   ` [dpdk-dev] [PATCH v2 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-09-18  3:35   ` [dpdk-dev] [PATCH v2 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-09-18  3:35   ` [dpdk-dev] [PATCH v2 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-20 10:51 ` [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on ice Leyi Rong
2020-10-20 10:51   ` [dpdk-dev] [PATCH v3 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-10-20 10:51   ` [dpdk-dev] [PATCH v3 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-10-20 10:51   ` [dpdk-dev] [PATCH v3 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-23  4:14 ` [dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice Leyi Rong
2020-10-23  4:14   ` [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-10-25 16:23     ` David Marchand
2020-10-26  7:12       ` Rong, Leyi
2020-10-26  8:09         ` David Marchand
2020-10-27 10:19           ` Bruce Richardson
2020-10-27 10:22         ` Ferruh Yigit [this message]
2020-10-27  8:32     ` Ali Alnubani
2020-10-27  8:42       ` Ali Alnubani
2020-10-23  4:14   ` [dpdk-dev] [PATCH v4 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-10-23  4:14   ` [dpdk-dev] [PATCH v4 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-23  9:39   ` [dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51b0a34b-5732-ef5c-52d0-4ace74226304@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=leyi.rong@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git