From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8EF7A04B5; Tue, 27 Oct 2020 11:22:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E98C02BD3; Tue, 27 Oct 2020 11:22:40 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1519C100C for ; Tue, 27 Oct 2020 11:22:37 +0100 (CET) IronPort-SDR: gzUJghhhIJSDoZ4RaUhJ0QN3NiZIoo1P7bZwb2kSFFsdW36E/kS337sooI1swBM4Guou3eHTwT CKTAQMkSamkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="155024935" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="155024935" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 03:22:37 -0700 IronPort-SDR: Zo/oI+/i6F1KKo3g/MbQrXXgKrY8IlQ5FIg5N8hAxwaRahRFZieyk0VVnGuGTBX8Gz1YII1kxo hl8JU5ElkY7Q== X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="468246275" Received: from ndelaney-mobl2.ger.corp.intel.com (HELO [10.251.87.204]) ([10.251.87.204]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 03:22:35 -0700 To: "Rong, Leyi" , David Marchand , "Zhang, Qi Z" Cc: "Lu, Wenzhuo" , dev , "Richardson, Bruce" , Thomas Monjalon References: <20200910065504.104217-1-leyi.rong@intel.com> <20201023041407.20442-1-leyi.rong@intel.com> <20201023041407.20442-2-leyi.rong@intel.com> From: Ferruh Yigit Message-ID: <51b0a34b-5732-ef5c-52d0-4ace74226304@intel.com> Date: Tue, 27 Oct 2020 10:22:34 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2020 7:12 AM, Rong, Leyi wrote: > >> -----Original Message----- >> From: David Marchand >> Sent: Monday, October 26, 2020 12:24 AM >> To: Rong, Leyi ; Zhang, Qi Z ; Yigit, >> Ferruh >> Cc: Lu, Wenzhuo ; dev ; Richardson, >> Bruce ; Thomas Monjalon >> >> Subject: Re: [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path >> >> Hello Leyi, Qi, Ferruh, >> >> On Fri, Oct 23, 2020 at 6:37 AM Leyi Rong wrote: >>> diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build >>> index 254595af85..85e8baf912 100644 >>> --- a/drivers/net/ice/meson.build >>> +++ b/drivers/net/ice/meson.build >>> @@ -34,6 +34,17 @@ if arch_subdir == 'x86' >>> c_args: [cflags, '-mavx2']) >>> objs += ice_avx2_lib.extract_objects('ice_rxtx_vec_avx2.c') >>> endif >>> + >>> + if dpdk_conf.has('RTE_MACHINE_CPUFLAG_AVX512F') or (not >> machine_args.contains('-mno-avx512f') and cc.has_argument('-mavx512f')) >>> + cflags += ['-DCC_AVX512_SUPPORT'] >>> + ice_avx512_lib = static_library('ice_avx512_lib', >>> + 'ice_rxtx_vec_avx512.c', >>> + dependencies: [static_rte_ethdev, >>> + static_rte_kvargs, static_rte_hash], >>> + include_directories: includes, >>> + c_args: [cflags, '-march=skylake-avx512', '-mavx512f']) >>> + objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c') >>> + endif >>> endif >>> >>> sources += files('ice_dcf.c', >>> -- >>> 2.17.1 >>> >> >> RTE_MACHINE_CPUFLAG_AVX512F can be removed. >> Worth fixing before hitting the main tree. >> >> Thanks. >> >> -- >> David Marchand > > Hello David, > > Would prefer using __AVX512F__ instead of RTE_MACHINE_CPUFLAG_AVX512F here rather than remove the RTE_MACHINE_CPUFLAG_ macro directly to check the CPU capability. > So the judgment statement will be > if cc.get_define('__AVX512F__', args: machine_args) != '' or (not machine_args.contains('-mno-avx512f') and cc.has_argument('-mavx512f')) > > what do you think? > > > Hello Ferruh, > > As the patchset is already merged into dpdk-next-net, I'm going to make another patch for this if it's accepted? > Hi Leyi, Please make another patch, I can squash it in the next-net. Thanks, ferruh