From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EEB5A00C3; Thu, 14 May 2020 09:02:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B0891D605; Thu, 14 May 2020 09:02:17 +0200 (CEST) Received: from dal3relay118.mxroute.com (dal3relay118.mxroute.com [64.40.27.118]) by dpdk.org (Postfix) with ESMTP id DE59A1D5F9 for ; Thu, 14 May 2020 09:02:14 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay118.mxroute.com (ZoneMTA) with ESMTPSA id 17211fd974100075bf.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 14 May 2020 07:02:11 +0000 X-Zone-Loop: 28d9b350a67ffbe0b33be57b37ee3b9069d49f62afe2 X-Originating-IP: [168.235.111.26] Received: from galaxy.mxroute.com (unknown [23.92.70.113]) by filter003.mxroute.com (Postfix) with ESMTPS id 6FD8F6002E; Thu, 14 May 2020 07:02:10 +0000 (UTC) Received: from [192.198.151.44] by galaxy.mxroute.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1jZ7RI-0006PM-BJ; Thu, 14 May 2020 02:33:52 -0400 To: pbhagavatula@marvell.com, jerinj@marvell.com, aostruszka@marvell.com, Neil Horman , Nithin Dabilpuram , Anoob Joseph Cc: thomas@monjalon.net, dev@dpdk.org References: <20200511100059.5035-1-pbhagavatula@marvell.com> <20200513010456.2863-1-pbhagavatula@marvell.com> From: Ray Kinsella Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <51cf0315-9460-c7bd-1c62-4b6bf51a7dec@ashroe.eu> Date: Thu, 14 May 2020 08:02:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200513010456.2863-1-pbhagavatula@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v2 1/2] common/octeontx2: move internal symbols to INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/05/2020 02:04, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Move the internal symbols to INTERNAL sections so that any > change in them is not reported as ABI breakage. > > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > - Sort version map alphabetically > - Add libabigail ignore tag for OCTEONTX2 > > devtools/libabigail.abignore | 4 +++ > drivers/common/octeontx2/otx2_common.h | 8 ++++++ > drivers/common/octeontx2/otx2_dev.h | 3 +++ > drivers/common/octeontx2/otx2_irq.h | 3 +++ > drivers/common/octeontx2/otx2_mbox.h | 6 +++++ > drivers/common/octeontx2/otx2_sec_idev.h | 6 +++++ > .../rte_common_octeontx2_version.map | 26 ++++++------------- > 7 files changed, 38 insertions(+), 18 deletions(-) > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index c9ee73cb3..dfe346db4 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -48,3 +48,7 @@ > changed_enumerators = RTE_CRYPTO_AEAD_LIST_END > [suppress_variable] > name = rte_crypto_aead_algorithm_strings > + > +; Ignore moving internal OCTEONTX2 stable functions to INTERNAL tag > +[suppress_file] > + soname_regexp = librte_common_octeontx2.* > diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h > index e62cdea07..174702687 100644 > --- a/drivers/common/octeontx2/otx2_common.h > +++ b/drivers/common/octeontx2/otx2_common.h > @@ -62,13 +62,21 @@ struct otx2_idev_cfg { > }; > }; > > +__rte_internal > struct otx2_idev_cfg *otx2_intra_dev_get_cfg(void); > +__rte_internal > void otx2_sso_pf_func_set(uint16_t sso_pf_func); > +__rte_internal > uint16_t otx2_sso_pf_func_get(void); > +__rte_internal > uint16_t otx2_npa_pf_func_get(void); > +__rte_internal > struct otx2_npa_lf *otx2_npa_lf_obj_get(void); > +__rte_internal > void otx2_npa_set_defaults(struct otx2_idev_cfg *idev); > +__rte_internal > int otx2_npa_lf_active(void *dev); > +__rte_internal > int otx2_npa_lf_obj_ref(void); > > /* Log */ > diff --git a/drivers/common/octeontx2/otx2_dev.h b/drivers/common/octeontx2/otx2_dev.h > index 13b75e118..cd4fe517d 100644 > --- a/drivers/common/octeontx2/otx2_dev.h > +++ b/drivers/common/octeontx2/otx2_dev.h > @@ -94,6 +94,7 @@ struct otx2_dev { > OTX2_DEV; > }; > > +__rte_internal > int otx2_dev_priv_init(struct rte_pci_device *pci_dev, void *otx2_dev); > > /* Common dev init and fini routines */ > @@ -116,7 +117,9 @@ otx2_dev_init(struct rte_pci_device *pci_dev, void *otx2_dev) > return otx2_dev_priv_init(pci_dev, otx2_dev); > } > > +__rte_internal > void otx2_dev_fini(struct rte_pci_device *pci_dev, void *otx2_dev); > +__rte_internal > int otx2_dev_active_vfs(void *otx2_dev); > > #define RVU_PFVF_PF_SHIFT 10 > diff --git a/drivers/common/octeontx2/otx2_irq.h b/drivers/common/octeontx2/otx2_irq.h > index 9d326276e..0683cf554 100644 > --- a/drivers/common/octeontx2/otx2_irq.h > +++ b/drivers/common/octeontx2/otx2_irq.h > @@ -16,10 +16,13 @@ typedef struct { > uint64_t bits[MAX_VFPF_DWORD_BITS]; > } otx2_intr_t; > > +__rte_internal > int otx2_register_irq(struct rte_intr_handle *intr_handle, > rte_intr_callback_fn cb, void *data, unsigned int vec); > +__rte_internal > void otx2_unregister_irq(struct rte_intr_handle *intr_handle, > rte_intr_callback_fn cb, void *data, unsigned int vec); > +__rte_internal > int otx2_disable_irqs(struct rte_intr_handle *intr_handle); > > #endif /* _OTX2_IRQ_H_ */ > diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeontx2/otx2_mbox.h > index 80778a0be..7fa4276e9 100644 > --- a/drivers/common/octeontx2/otx2_mbox.h > +++ b/drivers/common/octeontx2/otx2_mbox.h > @@ -1617,19 +1617,25 @@ struct tim_enable_rsp { > uint32_t __otx2_io currentbucket; > }; > > +__rte_internal > const char *otx2_mbox_id2name(uint16_t id); > int otx2_mbox_id2size(uint16_t id); > void otx2_mbox_reset(struct otx2_mbox *mbox, int devid); > int otx2_mbox_init(struct otx2_mbox *mbox, uintptr_t hwbase, uintptr_t reg_base, > int direction, int ndevsi, uint64_t intr_offset); > void otx2_mbox_fini(struct otx2_mbox *mbox); > +__rte_internal > void otx2_mbox_msg_send(struct otx2_mbox *mbox, int devid); > +__rte_internal > int otx2_mbox_wait_for_rsp(struct otx2_mbox *mbox, int devid); > int otx2_mbox_wait_for_rsp_tmo(struct otx2_mbox *mbox, int devid, uint32_t tmo); > +__rte_internal > int otx2_mbox_get_rsp(struct otx2_mbox *mbox, int devid, void **msg); > +__rte_internal > int otx2_mbox_get_rsp_tmo(struct otx2_mbox *mbox, int devid, void **msg, > uint32_t tmo); > int otx2_mbox_get_availmem(struct otx2_mbox *mbox, int devid); > +__rte_internal > struct mbox_msghdr *otx2_mbox_alloc_msg_rsp(struct otx2_mbox *mbox, int devid, > int size, int size_rsp); > > diff --git a/drivers/common/octeontx2/otx2_sec_idev.h b/drivers/common/octeontx2/otx2_sec_idev.h > index c681f5094..89cdaf66a 100644 > --- a/drivers/common/octeontx2/otx2_sec_idev.h > +++ b/drivers/common/octeontx2/otx2_sec_idev.h > @@ -22,16 +22,22 @@ struct otx2_sec_idev_cfg { > rte_spinlock_t tx_cpt_lock; > }; > > +__rte_internal > uint8_t otx2_eth_dev_is_sec_capable(struct rte_eth_dev *eth_dev); > > +__rte_internal > int otx2_sec_idev_cfg_init(int port_id); > > +__rte_internal > int otx2_sec_idev_tx_cpt_qp_add(uint16_t port_id, struct otx2_cpt_qp *qp); > > +__rte_internal > int otx2_sec_idev_tx_cpt_qp_remove(struct otx2_cpt_qp *qp); > > +__rte_internal > int otx2_sec_idev_tx_cpt_qp_put(struct otx2_cpt_qp *qp); > > +__rte_internal > int otx2_sec_idev_tx_cpt_qp_get(uint16_t port_id, struct otx2_cpt_qp **qp); > > #endif /* _OTX2_SEC_IDEV_H_ */ > diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map > index 01279c339..7621a59ad 100644 > --- a/drivers/common/octeontx2/rte_common_octeontx2_version.map > +++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map > @@ -1,13 +1,15 @@ > -DPDK_20.0 { > +INTERNAL { > global: > > otx2_dev_active_vfs; > otx2_dev_fini; > otx2_dev_priv_init; > otx2_disable_irqs; > + otx2_eth_dev_is_sec_capable; > otx2_intra_dev_get_cfg; > otx2_logtype_base; > otx2_logtype_dpi; > + otx2_logtype_ep; > otx2_logtype_mbox; > otx2_logtype_nix; > otx2_logtype_npa; > @@ -27,26 +29,14 @@ DPDK_20.0 { > otx2_npa_pf_func_get; > otx2_npa_set_defaults; > otx2_register_irq; > - otx2_sso_pf_func_get; > - otx2_sso_pf_func_set; > - otx2_unregister_irq; > - > - local: *; > -}; > - > -DPDK_21 { > - global: > - > - otx2_eth_dev_is_sec_capable; > otx2_sec_idev_cfg_init; > otx2_sec_idev_tx_cpt_qp_add; > - otx2_sec_idev_tx_cpt_qp_remove; > otx2_sec_idev_tx_cpt_qp_get; > otx2_sec_idev_tx_cpt_qp_put; > -} DPDK_20.0; > - > -EXPERIMENTAL { > - global: > + otx2_sec_idev_tx_cpt_qp_remove; > + otx2_sso_pf_func_get; > + otx2_sso_pf_func_set; > + otx2_unregister_irq; > > - otx2_logtype_ep; > + local: *; > }; > -- > 2.17.1 > Acked-by: Ray Kinsella