From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88325A0C47; Thu, 4 Nov 2021 15:56:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35D544272B; Thu, 4 Nov 2021 15:55:58 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2E6C5411A4 for ; Thu, 4 Nov 2021 15:55:57 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="230435605" X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="230435605" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 07:55:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="532289853" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 04 Nov 2021 07:55:56 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 07:55:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 07:55:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 07:55:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iDzmjzA4sfXXtf7qsYgSOhwJGYOU0fcTPwOngjDNrGMLORka+EF9CPn3tiUtQAmEGvhaRG6Jsq26DaLFb2Q70zNNMXsVY+0A54jnqvpAra8Y9SEX7fh65Pbee3uT2RPU8IdHE79E/Myb6Jdmcm104Ng7C0RFbdMu9yIuuhC79mhf7woXDA8Y/hozSPqEAgoWm78bJQjGqf/fbxF+cNUXbWmBIRO4p7EBKnrlrBGjdsUo/pOqcuzzOSBBzgMjULASmf35teTjc1vJwvxcjoT8rilhycik11k+nXYNefkekRYjWYkgdbE9g130APYmdLUfVZL8rSUsg5iEpEGsmz0gAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ze4k5YmjcSXyYWVqfyuXqgcQYwsWGHUKp37+er/eWC8=; b=byZHKi8THB496o77jMdyg7ccDpQs8nqLEQYet8cf/jKZdchVjv8MlpCHZkmsqRj6bszVnRgpPrKXv5RXMO4J2VcvURcmIK4zcxlgudzajRDvpGRMqEOQgoMDPYGQcXZTW8U4uz9UOALMAOQ3gWXi9cxIlanbAaWOWRPT1/gz1v12++/9q8lEX6nQRwiuP5RQBucJOlNPmlGU5N7OfZPcyRxZadouGKVU/ah61a83660yOLBMmmvOb4So5545O9Nj6S7MdM/0Zf0SWa0IQfmU3zDZWKMjUmU1Ik8kkxSvDzWtt7wOfyMqSdcdY9K7qp3X5MP8MXFz2v4r+g3Dvsy5hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ze4k5YmjcSXyYWVqfyuXqgcQYwsWGHUKp37+er/eWC8=; b=kgHtwhflOqSI+YcqjWjH2yzaQzHD9bMmnc11nAa6RPCLNABVlvczcHhuyuaOQbVzrqMq7F/Hl+hq28RFYpnkQFUGHhvGrRjSnskkIfYXD+GabCGXuMqW5CRIFyaAl6m6ZmYJImfooah1CqVHqFJBYJc/xPceF5JTDV/4rn/YeoU= Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5096.namprd11.prod.outlook.com (2603:10b6:510:3c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 14:55:54 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Thu, 4 Nov 2021 14:55:54 +0000 Message-ID: <51d6f048-5852-9191-029c-8c4bfaddb2a3@intel.com> Date: Thu, 4 Nov 2021 14:55:48 +0000 Content-Language: en-US To: "Min Hu (Connor)" , CC: References: <20211102031729.35536-1-humin29@huawei.com> <20211102031729.35536-10-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211102031729.35536-10-humin29@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0399.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0399.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Thu, 4 Nov 2021 14:55:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a0a6d0a-9e6f-4328-635c-08d99fa3334e X-MS-TrafficTypeDiagnostic: PH0PR11MB5096: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qKREA8fCI8WmeDVo1NKX044lBHiurUY1pk52BKco36XxG1Pr74XsbPtvotNl46MTE6z1mO9bih21SLuHlZ4kEKL3gwjCglqaJTtDJW8adOikePSBWx6C5durND+4j5Tr3ZAWNYMDfOSN4uEmBKoOAUrhqsHEnHX9yrrHLrx56H06MBcOcoQZsVcAg4JbHZWsgHKHVTwm6s+qTp+8paDui5UWuUN1CJ2Wqhp7zZRntXZBk3wmRcPEvLbEiCQ9lc4h8YnK1qDFLgWjV7FxqDzkoRMlK0vA93bHHrBuFpduzAzPa2cTxL5faqPY17AbUOaPqdtdDlAUfh3OnsgTwzXBbOeGUlj1zEKxrQS5cZARUVEtE3zvQsuephGACH78OUguqBSBwt/XoQg5EhVEGQmI3T7xcaY5H5nOSpEYRk1Mb8XAM3TqvEwaqMb7PGt2GIFl2jvkb/Fc0pgNk62qVh+jBhKvHKBZjRcvwJQsDhlCR8IzIXxILbdtcXsS42EJr+j3O65k9cFTd03sBZRjx2yb22sEPNs/f5RacfsmUNUjC7XG45z8DHfMuOidlTm7opy7CPXRkH0yeZzoZo1sVJGvOdsv4ruEmgBRx/rcEyAkxJepecu/hjP1Ac/R3uHCpkXiIFrPttd3JKq3lROtCX56OGHFW7xnvXNMxqRSbfKvHcxlaCgt3b23HOTFH/CagDgr4zBSMkHQE7fvJrnR0bDDBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(4326008)(16576012)(186003)(8936002)(2906002)(31686004)(38100700002)(53546011)(8676002)(66946007)(508600001)(26005)(36756003)(66556008)(44832011)(66476007)(956004)(6666004)(86362001)(82960400001)(316002)(31696002)(6486002)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHJscEpSWnUwYTZBSTkvSnUwdHJET2krTzJKRTNJNGpuTGx4ejh1ZDVCS3Yw?= =?utf-8?B?elZtZDF5SkQ2VGl3K3lHNStEMENRZXBucTRGRFBPWEUwWWFFeHFXUDA1cmRm?= =?utf-8?B?L3Z6Z25aRFYrTXpxQkZIeXhFZHlWMzhDd3VZcE5HTVdVVUpxQW9GalE5Qkkx?= =?utf-8?B?SFBWSlB5dUplQXJHbktGVWdVa0N6dW1ENEU0KzdoaGZ6Rktidi9heFBkSnlx?= =?utf-8?B?dGtOV3V6N3AyTlZNc0pYUWF6bnN0VmNNZ2xOcDFoN3ZJb3VpM3dTaUluQXdH?= =?utf-8?B?MnE2T21QS3VLSG5QTXMvTlBNYkkvbXg3ZEMrQk5jdXg4cGZOV0JoWDZuN3h3?= =?utf-8?B?N2NMakppQ3c2TzVsa2p0SWE3dmFXNXVLNzFtTVlKWmtIazU4N3gzdnVPZVJn?= =?utf-8?B?YS9BTWtFbXRLUXVpTStUcW9IbGhZaTJIaDhsc3J4a1FrM2V5bnR6ZEVQUjRi?= =?utf-8?B?MU9qbENIZ09UNmxGRGsrVkhObEpqb0M0d3VjYjhnYlhDdjYrcmk2MWN3K09M?= =?utf-8?B?NTF3ejJLYUVWTzdBWU5OdnNEcHd0WGo2NmIwRDRBWkVLS2k1OHVYQUw2aWRa?= =?utf-8?B?UXdQWHZGZjVUWUVSTW1tYUpWUDZxdGVCb1V2N2VYVkFyWWhTWDdHQzNaSjdr?= =?utf-8?B?R2hJYWJnaUwxeUtKQWdHRzVYR3R3azRTUVJNMVBDQnJoUVJ6Z25QWTg1dmVo?= =?utf-8?B?cUx5NTYrMzFUcVg4NHhpcEdxWkNaN1JqSXhOajdvOHdrNXlIRUx0RE1iZ24z?= =?utf-8?B?d3hNZ1B3Zlh3M2V6U2VTOExGcmgzK3lJVEt3bXdUZ3hFU0dxaml0T2d2a1NY?= =?utf-8?B?VjRxVWFhbVlsb3N4ZXZvTHNtbjVSVEh0cW5OUDFkQk5ESmpTSGNNeGllK2Iv?= =?utf-8?B?aFVobTRJSDhVZlptLzl5SmR3dXN1aDBjSEtKdlQ3VGtqRVAyZUViUSt4RDA0?= =?utf-8?B?eTFxWWlHRkpuRjFQK0I4V25DVURlcUhIcWxId2h3Z1puS2NDZEcvcys5RHM3?= =?utf-8?B?NWVhNmlQWitsNm5GdGxLdFY0bmRtWkpXWkpHdEV0N21JRzYrT2ZPOFhLcEFk?= =?utf-8?B?Y3ZneUtaYytCNDFlQVNRZmlWcHY2VVhCOElXTC8wYWNrQ1FZS1RSUVVZcnhm?= =?utf-8?B?YkpSNS9WeW8xb3MwdEdaUnNRTXlYUkpaMThORFJESk1tOXhPbGpSd3RFcnEw?= =?utf-8?B?UmVLUWtOWnNTNE1ZdFVqQnMxR0NsVyt2WTh3WVB2ZTIzVzNoRlVVRUVCYjZS?= =?utf-8?B?L2JybnBnQ0w3b28zT3l4dFhHK3FLRE1TS0MxSVhFRmtjUlh6TTNPNUI1dVYz?= =?utf-8?B?VVAxN0FqRkwySWV2a3NoKzFSNUpVa29wK2Rsamxoc2haYTNvaHFPQTdMaXZl?= =?utf-8?B?UG1uSmdzM3B5dkU1REJwV1hxckhRRmZnYkdVL1Jnc3BxUi96V1hlUFQ5bkF1?= =?utf-8?B?TE5iVGVSdnBXR1laVDVZY1pKR1NkQm9GUksrSjlWNnl3cVRkeW01emdrcktn?= =?utf-8?B?NU9Mc1dWOVNEN0oxZnhBaG5zVjJIRCsyY0ZUeEJuOXNXSit6d1RROEM1Y3B0?= =?utf-8?B?Z1YreHhFamNyamFiTFVFeStYRmdCMStCN1FDTzVhQ29wbGdkNWRHTzAzSEVM?= =?utf-8?B?cUxLM2NaQ2o2ZjVCMDdFMjJRSGRzOXZJV1lLTVpsQ0s3bjNSaC8yK0F1Wkp1?= =?utf-8?B?QkkwUnRkbnVnZ0YyQllmZlMrSGJHc3VsbVZJWjBLTGJKTi9DNU55NFcvMjVr?= =?utf-8?B?Q2xrTExKajVRczA2Zkg3MVFhMWcvVmwzaUFabFRlZDhyTERiQkNZRXNEdU5h?= =?utf-8?B?TmYraUVwMGVQZEpSMUNSL1owcDVJNE5ZWC9yS05JMVNyQnRjK1RVazJzTDE4?= =?utf-8?B?dnVQbU9CNElQTXBBamVDWHhXWitpQzIrdXhYMlZLdmsxV3U0ZG51QTloSDFz?= =?utf-8?B?VnVGWEs3RXdCMEE2UFNUeXQ3TEdNTUVUZFNzZGZsYThGVFAzY3E0QUwxZFRh?= =?utf-8?B?d2xlOCtjSWhmNHhLK3BBQ0puZ3FrelVXeFlrYjI5RDNFOGcwUUl4d0theUpL?= =?utf-8?B?cTNxU3psMUdabE5QdlpETC9Nck0yYjEvNC9tdS92VlRra1NDcWJDZ0hXSmV0?= =?utf-8?B?V3gzbFJOL0hlQS9HM1dQVE5ianV6UExSeXBRckRoaHZhdkZHWi9iVFJHUnVQ?= =?utf-8?Q?sOkywLuH6CQcQ4lNyb3HTUM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1a0a6d0a-9e6f-4328-635c-08d99fa3334e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 14:55:54.2391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kqxZqV5GaA11fSsYPXPn/njajwVxStKOKFNrvvrPUrGyhH+4cv9f6nX3tQ2br//wGkF5PKtJmGqvbz1k1PwsVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5096 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 9/9] net/hns3: remove PF/VF duplicate code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 3:17 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > This patch remove PF/VF duplicate code of: > 1. get firmware version. > 2. get device info. > 3. rx interrupt related functions. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) <...> > +int > +hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) > +{ > + struct hns3_adapter *hns = eth_dev->data->dev_private; > + struct hns3_hw *hw = &hns->hw; > + uint16_t queue_num = hw->tqps_num; > + > + /* > + * In interrupt mode, 'max_rx_queues' is set based on the number of > + * MSI-X interrupt resources of the hardware. > + */ > + if (hw->data->dev_conf.intr_conf.rxq == 1) > + queue_num = hw->intr_tqps_num; > + > + info->max_rx_queues = queue_num; > + info->max_tx_queues = hw->tqps_num; > + info->max_rx_pktlen = HNS3_MAX_FRAME_LEN; /* CRC included */ > + info->min_rx_bufsize = HNS3_MIN_BD_BUF_SIZE; > + info->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD; > + info->max_lro_pkt_size = HNS3_MAX_LRO_SIZE; > + info->rx_offload_capa = (DEV_RX_OFFLOAD_IPV4_CKSUM | > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_UDP_CKSUM | > + DEV_RX_OFFLOAD_SCTP_CKSUM | > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > + DEV_RX_OFFLOAD_OUTER_UDP_CKSUM | > + DEV_RX_OFFLOAD_SCATTER | > + DEV_RX_OFFLOAD_VLAN_STRIP | > + DEV_RX_OFFLOAD_VLAN_FILTER | > + DEV_RX_OFFLOAD_RSS_HASH | > + DEV_RX_OFFLOAD_TCP_LRO); > + info->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > + DEV_TX_OFFLOAD_IPV4_CKSUM | > + DEV_TX_OFFLOAD_TCP_CKSUM | > + DEV_TX_OFFLOAD_UDP_CKSUM | > + DEV_TX_OFFLOAD_SCTP_CKSUM | > + DEV_TX_OFFLOAD_MULTI_SEGS | > + DEV_TX_OFFLOAD_TCP_TSO | > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | > + DEV_TX_OFFLOAD_MBUF_FAST_FREE | > + DEV_TX_OFFLOAD_VLAN_INSERT); The function changed while moving, please be aware renamed macros in upsteram. Can you please rebase your patch on top of latest next-net?