From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3E99A04FD; Wed, 8 Jun 2022 14:52:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89BF64282D; Wed, 8 Jun 2022 14:52:46 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060.outbound.protection.outlook.com [40.107.94.60]) by mails.dpdk.org (Postfix) with ESMTP id A04DA40687; Wed, 8 Jun 2022 14:52:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kFd9QLMyfNRxNQiG43eMxwtDXmqtp/H1bWLoGKVqepBoLovIoNAQdJLCUAoxEgNe5k0tRh0BLgMogM1QnZbIIgoQhEjZtFsIc1YjRxOv2Es96kRjlOdeXvrgDueJCYHnrXm4SwP6ls/JBo9+fm8rPMtEcggUc5yj8EDPAuJF+L4rYcI1Ryhcd+P4peP5VZ2pgJUhnFlQELz5GLnQMZsqnWAqnjLdbw8UtPkdYG5lDcmPbqmht/ZVXfgAVS7vN8xPQpn+0WWfPixNP4yO/I/N++0fW00qbbWwTUM6LyhiRnIPaZzEIaFx7dVTAE5wFSvBC5ouE6qZ1DFy7G5fKVk3sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ereG0Se1d9rX4Py8/ygDAgCF31ZSdGnlufsWzjiDhHI=; b=oMuKGxEIVzprlNZ1joGlzhAlCmtjB9Oso3qIbQO3LZ2lB93x41ajSzcVv9oYgSAcX6WDIpNwS4BxpYzBXmudfFpIDKWNs555Ge25vGkcl6XaYXcrpMQSXT/RiqiFCqB0v7RYSdi4voqLrKqEYLlnSQ5Yf511T7iLAKz5BZoe2rWlqWJivXf7E4imfLBQ+nyXQSeHWjJC3Fqv4b4HxvfCAZfONgf99ZY+9cARziOBFuYZdwT9JSJGqKsnh/vWJIb53faRQ3RhWcT69P2gSce57lek/lTySBkka9kqinhYtuLvm3RrDCgq2m8EL8/h2Zdg1XzJkBgS2UEf5ounRRwppA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=oktetlabs.ru smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ereG0Se1d9rX4Py8/ygDAgCF31ZSdGnlufsWzjiDhHI=; b=c5YUom1srE4upnU+w21BK3Xe/oKzpMoLRbmoj2SCIk+rN5dS1MKO6I+KAXH7VqymyIcnxanUsHOSsrolL1tkinh0Q1y3YmjnHUthXU4YVemAkxQdoge0d15X3yPTgLT3BaWZx5KazuW0TODp72ucL4sb6BvQXFdbzpbgjWEUWs4= Received: from DM5PR21CA0011.namprd21.prod.outlook.com (2603:10b6:3:ac::21) by BY5PR02MB6275.namprd02.prod.outlook.com (2603:10b6:a03:1b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Wed, 8 Jun 2022 12:52:42 +0000 Received: from DM3NAM02FT039.eop-nam02.prod.protection.outlook.com (2603:10b6:3:ac:cafe::b3) by DM5PR21CA0011.outlook.office365.com (2603:10b6:3:ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.5 via Frontend Transport; Wed, 8 Jun 2022 12:52:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT039.mail.protection.outlook.com (10.13.5.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5332.12 via Frontend Transport; Wed, 8 Jun 2022 12:52:41 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 8 Jun 2022 13:52:40 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 8 Jun 2022 13:52:40 +0100 Envelope-to: andrew.rybchenko@oktetlabs.ru, stephen@networkplumber.org, dev@dpdk.org, humin29@huawei.com, ke1x.zhang@intel.com, stable@dpdk.org Received: from [10.71.117.247] (port=59727) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nyvAu-0001m9-LD; Wed, 08 Jun 2022 13:52:40 +0100 Message-ID: <51f154f9-0686-b602-5eec-69e37daa11c7@xilinx.com> Date: Wed, 8 Jun 2022 13:52:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 1/2] kni: use dedicated function to set random MAC address Content-Language: en-US To: Andrew Rybchenko , Stephen Hemminger CC: , Min Hu , Ke Zhang , References: <20220531091330.230715-1-ke1x.zhang@intel.com> <20220608121117.1445731-1-andrew.rybchenko@oktetlabs.ru> <20220608121117.1445731-2-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: <20220608121117.1445731-2-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f20aaa29-1f04-4f91-c052-08da494dc6a0 X-MS-TrafficTypeDiagnostic: BY5PR02MB6275:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aM/lbvCzwHktTqU/TJGnIAErh6lpAZSxOyib2yqj3WxcmEPN94i8n3/y42SvHkRvPlM0kaLZjaoLV+2rX2mPphWXJ9XYX2nMve4WQKwKEF55ObNAgo9/Jq+WiwPLz+i2wmzgYgaMNFow6oqr0UqzcK2uYPxLquNEpXaNmzoSUDmJYzfeZgrUvjm20mw6vRMOh+/3NUtMDrAw6yBvu9uLNRQsGn9Hgi7bhcxc9puF1I1BPY4XYmc58GPN3zHcjp7fHpFR+irw9NYwHEu4iv9EhI6Fye9qk2kN9UlYq/IB7pRTfGMG4b8LTj9pCJ76GF0c9w32NmYVQRGPCSVD9OUUtzFlkIyrmpnKEJlrYvBu6/t1cq+Bs+QXLUiUyFxNoUWTHmT+vlLxsp+TPc+xr81dxlUno77r/GdOcCN39WNtjJiaXQVEhcVrJ6+X/g2k7V/KGcZs8RnAIRW4Xxf2muDl6PnJmfHZS4UFWR6AHgJ2j/ahNiyKP0n3q+5YmNHcZb3ePqB67UFFbAby3LD8bD2WxfE/DH8a5uFmerl1jKjju7RDn0zFIPFvYwhyBkDsf9MXBaHNdustexsV6p46FW9txW5w/F9AJTOt3hLTMUZwXh5FnCy1ZVxN+jINEXjoVmEyOpNnUTHGQVwn9FS/4bGKEc6ezUMBQpWMgKadXK2EdIYav4/sDWfiBSCt4JWHUX/+ny4275KSJmQj6EneBUvuQA62Yhh4YCyRGN/dnTLhyks= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(7636003)(426003)(47076005)(36756003)(31686004)(336012)(36860700001)(26005)(53546011)(186003)(2616005)(110136005)(40460700003)(8936002)(83380400001)(44832011)(356005)(31696002)(316002)(508600001)(82310400005)(8676002)(4326008)(54906003)(70206006)(70586007)(5660300002)(2906002)(4744005)(9786002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 12:52:41.7892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f20aaa29-1f04-4f91-c052-08da494dc6a0 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT039.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6275 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: > From: Ke Zhang > > eth_hw_addr_random() sets address type correctly. > > eth_hw_addr_random() is available since Linux v3.4, so > no compat is required. > > Also fix the warning: > warning: passing argument 1 of ‘memcpy’ discards ‘const’ > qualifier from pointer target type > > Variable dev_addr is done const intentionally in Linux v5.17 to > prevent using it directly. > > Fixes: ea6b39b5b847 ("kni: remove ethtool support") > Cc: stable@dpdk.org > > Signed-off-by: Ke Zhang > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit