From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 5BD1E3977
 for <dev@dpdk.org>; Tue,  2 Oct 2018 12:41:42 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 5AAA4140061; Tue,  2 Oct 2018 10:41:41 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 2 Oct 2018
 11:41:32 +0100
To: Ferruh Yigit <ferruh.yigit@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, 
 Jingjing Wu <jingjing.wu@intel.com>, Bernard Iremonger
 <bernard.iremonger@intel.com>, John McNamara <john.mcnamara@intel.com>,
 "Marko Kovacevic" <marko.kovacevic@intel.com>, Beilei Xing
 <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Olivier Matz
 <olivier.matz@6wind.com>
CC: <dev@dpdk.org>, Hyong Youb Kim <hyonkim@cisco.com>, John Daley
 <johndale@cisco.com>
References: <20181002101759.10395-1-ferruh.yigit@intel.com>
 <20181002113642.83514-1-ferruh.yigit@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <51fe03da-b3b4-69fd-046a-c2c00ef6dfd5@solarflare.com>
Date: Tue, 2 Oct 2018 13:40:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20181002113642.83514-1-ferruh.yigit@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24130.003
X-TM-AS-Result: No-0.602000-8.000000-10
X-TMASE-MatchedRID: e/tT8EyIjJQOwH4pD14DsPHkpkyUphL9YQXxsZnRwoLK99fyOVK2z8Xp
 bYD07gYfKj876iIVrFEdF8BZ6EBXsE1+zyfzlN7ygxsfzkNRlfIRTILTyAA+ovoLR4+zsDTtjoc
 zmuoPCq0DUYv+4Bx/ARRliqYeX4zNDL+VK31OnW0Y3LcG7UWTl6Q0qE5CIx+AJQzGL/2TSvVaFJ
 FpVpVeJgPW4EeIiAgqMk/zB9Lac/ji+fTMx9KaNitss6PUa4/cD6GAt+UbooSj1CO4X0Eqeb0SA
 hXRHTr3lExlQIQeRG0=
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10-0.602000-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24130.003
X-MDID: 1538476902-jpSJhbYvwet4
Subject: Re: [dpdk-dev] [PATCH v2] mbuf: clarify QINQ flag usage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 10:41:42 -0000

On 10/2/18 2:36 PM, Ferruh Yigit wrote:
> Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags
> set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN
> should be also set.
>
> Clarify mbuf documentations that when PKT_RX_QINQ set PKT_RX_VLAN also
> should be set.
>
> So that appllication can rely on PKT_RX_QINQ flag to access both
> mbuf.vlan_tci & mbuf.vlan_tci_outer
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>