From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 389E5A0C4E; Mon, 25 Oct 2021 19:04:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 092BE40E32; Mon, 25 Oct 2021 19:04:51 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id B49A24003E for ; Mon, 25 Oct 2021 19:04:49 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4877C5C0214; Mon, 25 Oct 2021 13:04:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 25 Oct 2021 13:04:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= pqjvme3ROqksCbi1wQEPWqgvkaMBkHKk9u/ipq3GWtQ=; b=ibURI+P4RNPnwlBD 4klcaWqrTR7G6PoamZmAFzehb7cn3ZgdLjmOXfwRDEGcvUE8ZgeSFX0kD4kqvXK0 WLz8wUoFMM8c2VY+3vbgJEbTp0OZJy18YqSTnrwWY8MZy27zTfVc3U3dABSFIr4t hTwvKyflzUs68/ORzb+c4TVGIyZGd2T5e3fplreYMlYwkzje4LQsxa5ZlRbSl5CS GKszwbJjcS1/3YBkqZDYw23ZRt/wT2OAT00HO+PdOigid/ZVoi4obxR7T3ClkA7g rARafkrQc/8ssT+lf/jjbwsKXm0eWRc+hMRmEVzwpDY2UsLfnpc5qYpCDdthIxRg 4MMbOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=pqjvme3ROqksCbi1wQEPWqgvkaMBkHKk9u/ipq3GW tQ=; b=EZxnDBDZCPdMAt7DL2X2ra2hkU9YnXW5vrcldBmWX8Is+aB7EeXt1RPGs jHEFYhdRwWs1HIwz2alA+gzH98qN28jeGvyocqe+OnC9E/HGfPmdZ/SLYVtORoKZ 2+O1KJvcOobrLh53L5q1Hs/WLh3YDi2dKbS/NXs50U9oPDIKvxRlR8GbY1aCtQ+u 6fYnFaKA8+/HpmcJOrcj0pWPswcZFlCKPPjjIhWUDg6dnRQWLazxoifX0MsabhYj fUyBLYwTkM+GWlHZhlMBhLo/+tlif0NDV4C/AaF+cEt8BPcoQrPftd3jAew67EFU /xwOxyTOSaNhLl7wqVc6Ba000+WWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefhedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Oct 2021 13:04:47 -0400 (EDT) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, stephen@networkplumber.org Date: Mon, 25 Oct 2021 19:04:46 +0200 Message-ID: <5209665.h00cftjivt@thomas> In-Reply-To: <1634842469-27119-4-git-send-email-vladimir.medvedkin@intel.com> References: <1634842469-27119-1-git-send-email-vladimir.medvedkin@intel.com> <1634842469-27119-4-git-send-email-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 3/5] doc/hash: update documentation for the thash library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Vladimir, your patches are late and not perfect. You need reviews. Please ask other maintainers to help with reviews. 21/10/2021 20:54, Vladimir Medvedkin: > This patch adds documentation for the new optimized Toeplitz hash > implementation using GFNI. > > Signed-off-by: Vladimir Medvedkin > --- > doc/guides/prog_guide/toeplitz_hash_lib.rst | 37 +++++++++++++++++++++++++---- > doc/guides/rel_notes/release_21_11.rst | 4 ++++ > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/prog_guide/toeplitz_hash_lib.rst b/doc/guides/prog_guide/toeplitz_hash_lib.rst > index f916857..88b152e 100644 > --- a/doc/guides/prog_guide/toeplitz_hash_lib.rst > +++ b/doc/guides/prog_guide/toeplitz_hash_lib.rst > @@ -19,24 +19,53 @@ to calculate the RSS hash sum to spread the traffic among the queues. > Toeplitz hash function API > -------------------------- > > -There are two functions that provide calculation of the Toeplitz hash sum: > +There are four functions that provide calculation of the Toeplitz hash sum: > > * ``rte_softrss()`` > * ``rte_softrss_be()`` > +* ``rte_thash_gfni()`` > +* ``rte_thash_gfni_x2()`` The last function doesn't exist. I think it should be the _bulk one. Also please squash the doc and test with the relevant code addition. Maybe 2 patches for each implementation?