From: 孙越池 <sunyuechi@iscas.ac.cn>
To: "Stanisław Kardach" <stanislaw.kardach@gmail.com>
Cc: uk7b@foxmail.com, dev@dpdk.org,
"Bruce Richardson" <bruce.richardson@intel.com>
Subject: Re: Re: [PATCH v5 3/3] riscv: override machine_args only when default
Date: Fri, 27 Jun 2025 12:03:30 +0800 (GMT+08:00) [thread overview]
Message-ID: <5212ae9e.172bd.197af8e0a17.Coremail.sunyuechi@iscas.ac.cn> (raw)
In-Reply-To: <CAJcPQBra-tp_66-R8L7Yd0MFOZ5rG4tPv4kMVv3RhbNpLiiqCw@mail.gmail.com>
Okay, they have been updated in v6.
> -----原始邮件-----
> 发件人: "Stanisław Kardach" <stanislaw.kardach@gmail.com>
> 发送时间: 2025-06-27 10:31:15 (星期五)
> 收件人: uk7b@foxmail.com
> 抄送: dev@dpdk.org, "Sun Yuechi" <sunyuechi@iscas.ac.cn>, "Bruce Richardson" <bruce.richardson@intel.com>
> 主题: Re: [PATCH v5 3/3] riscv: override machine_args only when default
>
> On Wed, Jun 11, 2025 at 5:23 PM <uk7b@foxmail.com> wrote:
> >
> > From: Sun Yuechi <sunyuechi@iscas.ac.cn>
> >
> > Support using -Dcpu_instruction_set=rv64gcv to enable V extension.
> >
> > Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
> > ---
> > config/riscv/meson.build | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/config/riscv/meson.build b/config/riscv/meson.build
> > index e3694cf2e6..1036a86d05 100644
> > --- a/config/riscv/meson.build
> > +++ b/config/riscv/meson.build
> > @@ -111,6 +111,7 @@ arch_config = arch_config[arch_id]
> > # Concatenate flags respecting priorities.
> > dpdk_flags = flags_common + vendor_config['flags'] + arch_config.get('flags', [])
> >
> > +if (cpu_instruction_set == 'rv64gc')
> Perhaps instead of removing full flag customization, we should skip
> the -march flag within foreach if cpu_instruction_set!='rv64gc'.
> Reason being that just 'rv64gc' doesn't mean the default. Look at
> SiFive configs - they have -march=rv64gc but -mtune specific to those
> boards.
> > # apply supported machine args
> > machine_args = [] # Clear previous machine args
> > foreach flag: arch_config['machine_args']
> > @@ -118,6 +119,7 @@ foreach flag: arch_config['machine_args']
> > machine_args += flag
> > endif
> > endforeach
> > +endif
> Small nit - there's an indentation level missing around #if-#endif
>
> >
> > # check if we can do buildtime detection of extensions supported by the target
> > riscv_extension_macros = false
> > --
> > 2.49.0
> >
</sunyuechi@iscas.ac.cn></sunyuechi@iscas.ac.cn></uk7b@foxmail.com></bruce.richardson@intel.com></sunyuechi@iscas.ac.cn></stanislaw.kardach@gmail.com>
next prev parent reply other threads:[~2025-06-27 4:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 16:57 [PATCH 1/3] config/riscv: detect V extension uk7b
2025-06-04 11:49 ` [PATCH v2 0/3] Add RISC-V V extension detection and LPM optimization uk7b
2025-06-04 11:49 ` [PATCH v2 1/3] config/riscv: detect V extension uk7b
2025-06-04 19:54 ` Stephen Hemminger
2025-06-04 11:49 ` [PATCH v2 2/3] lib/lpm: R-V V rte_lpm_lookupx4 uk7b
2025-06-04 11:49 ` [PATCH v2 3/3] riscv: override machine_args only when default uk7b
2025-06-04 13:07 ` [PATCH v2 0/3] Add RISC-V V extension detection and LPM optimization uk7b
2025-06-04 13:16 ` 孙越池
2025-06-04 13:07 ` [PATCH v2 1/3] config/riscv: detect V extension uk7b
2025-06-04 13:07 ` [PATCH v2 2/3] lib/lpm: R-V V rte_lpm_lookupx4 uk7b
2025-06-04 13:07 ` [PATCH v2 3/3] riscv: override machine_args only when default uk7b
2025-06-04 15:47 ` [PATCH v3 0/3] Add RISC-V V extension detection and LPM optimization uk7b
[not found] ` <20250604154720.3078131-1-uk7b@foxmail.com>
2025-06-04 15:47 ` [PATCH v3 1/3] config/riscv: detect V extension uk7b
2025-06-04 15:47 ` [PATCH v3 2/3] lib/lpm: R-V V rte_lpm_lookupx4 uk7b
2025-06-04 15:47 ` [PATCH v3 3/3] riscv: override machine_args only when default uk7b
2025-06-05 10:58 ` [PATCH v4 0/3] [PATCH v4 0/3] Add RISC-V V extension detection and LPM optimization uk7b
2025-06-11 14:59 ` [PATCH v5 " uk7b
2025-06-27 3:58 ` [PATCH v6 " uk7b
[not found] ` <20250627035814.670775-1-uk7b@foxmail.com>
2025-06-27 3:58 ` [PATCH v6 1/3] config/riscv: detect V extension uk7b
2025-06-27 3:58 ` [PATCH v6 2/3] lib/lpm: R-V V rte_lpm_lookupx4 uk7b
2025-06-27 3:58 ` [PATCH v6 3/3] riscv: override machine_args only when default uk7b
[not found] ` <20250611145915.854026-1-uk7b@foxmail.com>
2025-06-11 14:59 ` [PATCH v5 1/3] config/riscv: detect V extension uk7b
2025-06-11 14:59 ` [PATCH v5 2/3] lib/lpm: R-V V rte_lpm_lookupx4 uk7b
2025-06-11 14:59 ` [PATCH v5 3/3] riscv: override machine_args only when default uk7b
2025-06-27 2:31 ` Stanisław Kardach
2025-06-27 4:03 ` 孙越池 [this message]
[not found] ` <20250605105844.3931758-1-uk7b@foxmail.com>
2025-06-05 10:58 ` [PATCH v4 1/3] config/riscv: detect V extension uk7b
2025-06-05 10:58 ` [PATCH v4 2/3] lib/lpm: R-V V rte_lpm_lookupx4 uk7b
2025-06-11 11:52 ` Medvedkin, Vladimir
2025-06-11 15:04 ` 孙越池
2025-06-05 10:58 ` [PATCH v4 3/3] riscv: override machine_args only when default uk7b
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212ae9e.172bd.197af8e0a17.Coremail.sunyuechi@iscas.ac.cn \
--to=sunyuechi@iscas.ac.cn \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stanislaw.kardach@gmail.com \
--cc=uk7b@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).