From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 879A841C5F; Fri, 10 Feb 2023 10:44:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3261040EE6; Fri, 10 Feb 2023 10:44:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 131F840687 for ; Fri, 10 Feb 2023 10:44:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676022244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ExET/biIh1z+ZXugssnXZFEBj6XGwA/8gCpkBEZewY=; b=MoJF5nW1le/KS+s11vTtQdx7K7NEooCOucgr9iwC0YsGic5ay0Ea5TI+c9d9tusRGzhkCV MLz50Js5slpFHMmurxJRB8EB5gCz8mLSXPMSirnnssUPQXtgvq+wKbcduA/Cvw4lRQwptA 1yJmK060lEUYTxxTW6wFTqWjM/nriXs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-128-5aBxkq66MbGSkanqQ-UcMg-1; Fri, 10 Feb 2023 04:43:59 -0500 X-MC-Unique: 5aBxkq66MbGSkanqQ-UcMg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3AD7F3810784; Fri, 10 Feb 2023 09:43:59 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7386C175A2; Fri, 10 Feb 2023 09:43:58 +0000 (UTC) Message-ID: <5214ad2d-62c1-3e5a-d856-d20e5e1295c8@redhat.com> Date: Fri, 10 Feb 2023 10:43:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 8/9] baseband/acc: add support for 4GUL CRC drop in VRB PMD To: Nicolas Chautru , dev@dpdk.org Cc: hernan.vargas@intel.com References: <20230209221929.265059-1-nicolas.chautru@intel.com> <20230209221929.265059-9-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20230209221929.265059-9-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/23 23:19, Nicolas Chautru wrote: > Adding support for the capability to drop the CRC24B > when using the turbo-decoder. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc/rte_vrb_pmd.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c > index 8fcb06b4ff..18b5dab25f 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -996,6 +996,7 @@ vrb_dev_info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info *dev_info) > .capability_flags = > RTE_BBDEV_TURBO_SUBBLOCK_DEINTERLEAVE | > RTE_BBDEV_TURBO_CRC_TYPE_24B | > + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP | > RTE_BBDEV_TURBO_EQUALIZER | > RTE_BBDEV_TURBO_SOFT_OUT_SATURATE | > RTE_BBDEV_TURBO_HALF_ITERATION_EVEN | > @@ -1408,8 +1409,12 @@ vrb_dma_desc_td_fill(struct rte_bbdev_dec_op *op, > } > > if ((op->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) > - && !check_bit(op->turbo_dec.op_flags, > - RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP)) > + && !check_bit(op->turbo_dec.op_flags, > + RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP)) > + crc24_overlap = 24; > + if ((op->turbo_dec.code_block_mode == RTE_BBDEV_CODE_BLOCK) > + && check_bit(op->turbo_dec.op_flags, > + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP)) > crc24_overlap = 24; > > /* Calculates circular buffer size. Normally only fixes should be proposed at this stage, but this is small enough: Reviewed-by: Maxime Coquelin Thanks, Maxime