From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 520FBA0C41; Thu, 18 Nov 2021 15:05:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1293440687; Thu, 18 Nov 2021 15:05:07 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id ADBB340395; Thu, 18 Nov 2021 15:05:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 193B65C01DF; Thu, 18 Nov 2021 09:05:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 18 Nov 2021 09:05:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= FfYtRtlLJwdh0z0KFxmObAOCie8m5XvIPhMqfC+U0z4=; b=ZdsOXUngILI5Dtgk uM6CqazP9k5pncak6gOFI11OFCmYOP5cf3zohfFSigRs+fCpxvKar+r8iGzz72g+ Rya6PJcVs20IjXO68qAmnMYxyc6DenBP8pQ185UiNniLrK7VJwoPbRt34B3z86VQ vyRnew+67ZxFJDsDzB53aK7FT/ZHwXqxacJMwwnql6UDpoy5NXCFREJTTOCMG9yD Pbqzzi3W0/boRyEdf3dxX1lLGZ+iHPXUEMRBC8t394krQdogB/WUFD6MzA6lB33U VoLPPAZHKTzN9EnRBa0NLIuntXE8cBgAA6RgEx7raVTGXUwdu2EE1sYIcJM7ruth VkAUZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FfYtRtlLJwdh0z0KFxmObAOCie8m5XvIPhMqfC+U0 z4=; b=QlpWfugTUnYZXvxgep+Bj/9jnnbm/eG2vCYSWXFGi1sbgBtm6cvhx1su/ lF7bMoQqFTE1EfoijQt72viVltq8jyhX4tN7yJ0jgd92HwFeBieYwNEkoYnhLYaO XfMKcXVwmbYYqQUz8x4ZIbn5pUgXHe6rMBQhKB8sYceAMkHAK+Uq3nx3uoJ5c1xZ aLort/pytBv3eTYzXNkLIqUnLcS/Ytu4gTCAR42ckHfI1SN+wuRdX9s1GMFPhZN3 UxCQLh/1iTxn8Ha86bzvtMCY6p6oYkT87pbv8QAvr4Dhi0agZf37yWl1KeBYXr3w WnOYcSCBS3YX9STx739vLKNipTBug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeigdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 18 Nov 2021 09:05:02 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Aman Kumar , David Marchand , "Song, Keesang" , techboard@dpdk.org, dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform Date: Thu, 18 Nov 2021 15:05:01 +0100 Message-ID: <5216156.SXqKmVLy82@thomas> In-Reply-To: References: <20211102145253.413467-1-aman.kumar@vvdntech.in> <4391381.llMs6SCV4p@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/11/2021 14:52, Bruce Richardson: > On Thu, Nov 18, 2021 at 01:25:38PM +0100, Thomas Monjalon wrote: > > I request a techboard decision for this patch. > > > > > > 02/11/2021 20:04, Thomas Monjalon: > > > 02/11/2021 19:45, David Marchand: > > > > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar wrote: > > > > > > > > > > -Dcpu_instruction_set=znverX meson option can be used > > > > > to build dpdk for AMD platforms. Supported options are > > > > > znver1, znver2 and znver3. > > > > > > > > > > Signed-off-by: Aman Kumar > > > > > --- > > > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > > > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > > > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > > > > + > > > > > +# AMD platform support > > > > > +if get_option('cpu_instruction_set') == 'znver1' > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 256) > > > > > +elif get_option('cpu_instruction_set') == 'znver2' > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > > +elif get_option('cpu_instruction_set') == 'znver3' > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > > +endif > > > > > > > > I already replied to a similar patch earlier in this release. > > > > https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/ > > > > > > > > So repeating the same: do you actually _need_ more than 128 lcores in > > > > a single DPDK application? > > > > We did not receive an answer to this question. > > > > > Yes I forgot this previous discussion concluding that we should not increase > > > more than 128 threads. > > > > We had a discussion yesterday in techboard meeting. > > The consensus is that we didn't hear for real need of more than 128 threads, > > except for configuration usability convenience. > > > > Now looking again at the code, this is how it is defined: > > > > option('max_lcores', type: 'string', value: 'default', description: > > 'Set maximum number of cores/threads supported by EAL; > > "default" is different per-arch, "detect" detects the number of cores on the build machine.') > > config/x86/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > config/ppc/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > config/arm/meson.build: it goes from 4 to 1280! > > > > So I feel it is not fair to reject this AMD patch if we allow Arm to go beyond. > > Techboard, let's have a quick decision please for 21.11-rc4. > > > I would support increasing the default value for x86 in this release. This patch is not increasing the default for all x86, only for some CPUs as given at compilation time. I think it is the same logic as Arm CPU-specific compilation. > I believe Dave H. had some patches to decrease the memory footprint > overhead of such a change. I don't believe that they were merged, and while > it's a bit late for 21.11 now, those should be considered for 22.03 release > and then maybe for backport.