From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECDFBA0521; Tue, 3 Nov 2020 15:28:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD192CB63; Tue, 3 Nov 2020 15:27:50 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D6BE1CAE3 for ; Tue, 3 Nov 2020 15:27:47 +0100 (CET) IronPort-SDR: 7w45DIqqerf02ZOj5f6AJUydcMZ9nXl7CygcRq8NCoHNy26LmaxWV6RTcpOLHm7Q0+bTzoEaQm kNjgY8Jw4R2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="169163736" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="169163736" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 06:27:46 -0800 IronPort-SDR: uYRuMwjTATyC5MaMp28Xxi82jYaTcaNDul86jnc4EZoGeFfY+gGMbyaSrw8xnpK/mhmEAVinTd lWDJgT2FyuZQ== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538507522" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 06:27:42 -0800 To: Xiaoyu Min , Ori Kam , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , "matan@nvidia.com" , Dekel Peled , Ajit Khaparde Cc: dev@dpdk.org, Xiaoyu Min , Andrew Rybchenko , Thomas Monjalon , Hyong Youb Kim , John Daley , Asaf Penso References: <20201103132022.14132-1-jackmin@mellanox.com> From: Ferruh Yigit Message-ID: <5218b9e5-68a8-085d-3336-ae1b4f0971a9@intel.com> Date: Tue, 3 Nov 2020 14:27:38 +0000 MIME-Version: 1.0 In-Reply-To: <20201103132022.14132-1-jackmin@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 1:20 PM, Xiaoyu Min wrote: > From: Xiaoyu Min > > The rte_flow_item_eth and rte_flow_item_vlan items are refined [1]. > The structs do not exactly represent the packet bits captured on the wire > anymore so set raw_encap/decap commands should only copy real header > instead of the whole struct. > > Replace the rte_flow_item_* with the existing corresponding rte_*_hdr. > > [1]: > commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN > items") > > Signed-off-by: Xiaoyu Min Hi Dekel, Ori, This is second fix [1] we get related to the "rte_flow_item_xxx" size changes [2] from you. The assumption that 'rte_flow_item_xxx' size is same as xxx header size seems implemented in multiple locations, and changing 'rte_flow_item_xxx' struct size breaking those usage. Can one of you guys spend some time to actively check all possible breakages? They may be very hard to find unless someone explicitly check for this. Thanks, ferruh [1] first one: https://patches.dpdk.org/patch/82863/ [2] Fixes: ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item") Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")