From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] malloc: respect SIZE_HINT_ONLY when looking for the biggest free elem
Date: Mon, 8 Oct 2018 10:02:53 +0100 [thread overview]
Message-ID: <522e80af-e19e-2e5c-f1f1-6fd34075cf76@intel.com> (raw)
In-Reply-To: <20181007193147.123868-1-dariusz.stojaczyk@intel.com>
On 07-Oct-18 8:31 PM, Darek Stojaczyk wrote:
> RTE_MEMZONE_SIZE_HINT_ONLY wasn't checked in any way,
> causing size hints to be parsed as hard requirements.
> This resulted in some allocations being failed prematurely.
>
> Fixes: 68b6092bd3c7 ("malloc: allow reserving biggest element")
> Cc: anatoly.burakov@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
> lib/librte_eal/common/malloc_heap.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c
> index ac7bbb3ba..d2a8bd8dc 100644
> --- a/lib/librte_eal/common/malloc_heap.c
> +++ b/lib/librte_eal/common/malloc_heap.c
> @@ -165,7 +165,9 @@ find_biggest_element(struct malloc_heap *heap, size_t *size,
> for (elem = LIST_FIRST(&heap->free_head[idx]);
> !!elem; elem = LIST_NEXT(elem, free_list)) {
> size_t cur_size;
> - if (!check_hugepage_sz(flags, elem->msl->page_sz))
> + if ((flags & RTE_MEMZONE_SIZE_HINT_ONLY) == 0 &&
> + !check_hugepage_sz(flags,
> + elem->msl->page_sz))
> continue;
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
Although to be frank, the whole concept of "reserving biggest available
memzone" is currently broken because of dynamic memory allocation. There
is currently no way to allocate "as many hugepages as you can", so we're
only looking at memory already allocated, which in the general case is
less than page size long (unless you use legacy mode or memory
preallocation switches).
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-10-08 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 19:31 Darek Stojaczyk
2018-10-08 9:02 ` Burakov, Anatoly [this message]
2018-10-28 10:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522e80af-e19e-2e5c-f1f1-6fd34075cf76@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).