From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AB12F201; Mon, 8 Oct 2018 11:02:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 02:02:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,356,1534834800"; d="scan'208";a="86580728" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.79]) ([10.237.220.79]) by FMSMGA003.fm.intel.com with ESMTP; 08 Oct 2018 02:02:57 -0700 To: Darek Stojaczyk , dev@dpdk.org Cc: stable@dpdk.org References: <20181007193147.123868-1-dariusz.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <522e80af-e19e-2e5c-f1f1-6fd34075cf76@intel.com> Date: Mon, 8 Oct 2018 10:02:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181007193147.123868-1-dariusz.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] malloc: respect SIZE_HINT_ONLY when looking for the biggest free elem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 09:03:00 -0000 On 07-Oct-18 8:31 PM, Darek Stojaczyk wrote: > RTE_MEMZONE_SIZE_HINT_ONLY wasn't checked in any way, > causing size hints to be parsed as hard requirements. > This resulted in some allocations being failed prematurely. > > Fixes: 68b6092bd3c7 ("malloc: allow reserving biggest element") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Darek Stojaczyk > --- > lib/librte_eal/common/malloc_heap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c > index ac7bbb3ba..d2a8bd8dc 100644 > --- a/lib/librte_eal/common/malloc_heap.c > +++ b/lib/librte_eal/common/malloc_heap.c > @@ -165,7 +165,9 @@ find_biggest_element(struct malloc_heap *heap, size_t *size, > for (elem = LIST_FIRST(&heap->free_head[idx]); > !!elem; elem = LIST_NEXT(elem, free_list)) { > size_t cur_size; > - if (!check_hugepage_sz(flags, elem->msl->page_sz)) > + if ((flags & RTE_MEMZONE_SIZE_HINT_ONLY) == 0 && > + !check_hugepage_sz(flags, > + elem->msl->page_sz)) > continue; Reviewed-by: Anatoly Burakov Although to be frank, the whole concept of "reserving biggest available memzone" is currently broken because of dynamic memory allocation. There is currently no way to allocate "as many hugepages as you can", so we're only looking at memory already allocated, which in the general case is less than page size long (unless you use legacy mode or memory preallocation switches). -- Thanks, Anatoly