From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 975421B2D4 for ; Sun, 22 Oct 2017 09:21:45 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id r68so4413486wmr.3 for ; Sun, 22 Oct 2017 00:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev-mellanox-co-il.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=k5zgwOkjF7gfokMgR9QKo4DZnKY6OHGbEM49J1pKTcY=; b=H9eS5wBj89ztGqWJWqsipXM2SDLUbYIaf06opFVucqgvN2LO/BwL/N+A58gsZCpjDk HobJ+7ANeCgWPePwgNbaq/h5VmZwk/tUSJDrI5Dk3LCx1nF+6YfbMEX0VhK7KR/bSeDl YRCcNb7aeipLxZgo71LmZ8sD1GjUCl1RE61gBqz8VgRqVCL7qmwwkcIOeepdjhfVh52F pgbAfjTu//vKZuLt/lm3WD8H25Xc0sGX/RqgLCVhC0phEtA+9iHq0k1WWAnIN3NJP2oq /+YuLGgKnGN/Dq122xrcz/KjxsMVR2zPSTW4pJZBx9cnj4MeYczgrNzVlgaZCcP5Jn8D XWLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=k5zgwOkjF7gfokMgR9QKo4DZnKY6OHGbEM49J1pKTcY=; b=pxbjzqI+l44R/mdApWa8bzvZ/oXMmF7WK2cz6xTx4FUEE7vW5N/L6ojkLmgFSW6sbq 3k9inEFBdUg6howGOwOicSiG7xHxGUv59CpVHaFmyG+2rSzpsboqmJhhXNlOqZmNypNe cnjJUAIDqQs2A9xiomstlK1mqnNewCOp2sFtwt0lp8pgCkqcX5w8MQFp8KvXINd95mKq v/D4CbejI2boEUe22+j6/HXWZmrJML/W8YxgUEcfeB2UKhRr+qCMIIdZNgprxC2GUkkW UJ0Fj7jmS0phcgoBmt2gvLGt9c5EBm9cfXQP0vjm/PEGBo29CBz2MQ/adwtJXV4eTtI8 3fIg== X-Gm-Message-State: AMCzsaWglu5EM6GwZH7MOOKxEnrL5YbZ7iT+L45c2w5FzXw7bXjcr4YO 7gQYb6JIh+nebu04GYL05P8YcQ== X-Google-Smtp-Source: ABhQp+Q5bKXcuTTYQasUB00CyoMUTve6WLsLLVhuegBjYxWod25L9aq73l4tw7DsqdC8ZgP914q7kw== X-Received: by 10.28.24.7 with SMTP id 7mr2922270wmy.78.1508656905345; Sun, 22 Oct 2017 00:21:45 -0700 (PDT) Received: from [10.0.38.219] ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id w79sm5795576wrb.86.2017.10.22.00.21.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Oct 2017 00:21:44 -0700 (PDT) To: "De Lara Guarch, Pablo" , "dev@dpdk.org" , "Gonzalez Monroy, Sergio" , "aviadye@mellanox.com" Cc: "borisp@mellanox.com" , "akhil.goyal@nxp.com" , "hemant.agrawal@nxp.com" , "Nicolau, Radu" , "Doherty, Declan" , "liranl@mellanox.com" , "nelio.laranjeiro@6wind.com" , "thomas@monjalon.net" References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il> <1508439184-17893-1-git-send-email-aviadye@dev.mellanox.co.il> From: Aviad Yehezkel Message-ID: <522e9051-1390-f0b3-9796-8f4e8c323c62@dev.mellanox.co.il> Date: Sun, 22 Oct 2017 10:21:42 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/6] examples/ipsec-secgw: fix initialization of aead crypto devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2017 07:21:45 -0000 On 10/20/2017 12:50 PM, De Lara Guarch, Pablo wrote: > >> -----Original Message----- >> From: aviadye@dev.mellanox.co.il [mailto:aviadye@dev.mellanox.co.il] >> Sent: Thursday, October 19, 2017 7:53 PM >> To: dev@dpdk.org; Gonzalez Monroy, Sergio >> ; De Lara Guarch, Pablo >> ; aviadye@mellanox.com >> Cc: borisp@mellanox.com; akhil.goyal@nxp.com; >> hemant.agrawal@nxp.com; Nicolau, Radu ; >> Doherty, Declan ; aviadye@dev.mellanox.co.il; >> liranl@mellanox.com; nelio.laranjeiro@6wind.com; thomas@monjalon.net >> Subject: [dpdk-dev][PATCH v2 1/6] examples/ipsec-secgw: fix initialization >> of aead crypto devices >> >> From: Aviad Yehezkel >> >> Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") >> Cc: pablo.de.lara.guarch@intel.com > You should CC stable here. You referred me to http://dpdk.org/doc/guides/contributing/patches.html I followed the documentation: " When fixing a regression, it is required to reference the id of the commit which introduced the bug, and put the original author of that commit on CC. Yiu can generate the required lines using the following git alias, which print the commit SHA and the author of the original code: git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" " Please explain when to use above alias and when to put stable or something else. Thanks! >> Issue: None > What does this mean? This is a fix to an existing issue, > so this doesn't make sense. This is leftovers from my internal git continuous integration system. It refers to internal bug in my local bugzilla. Will remove that and automate next patches not to include it. Thanks! > > Apart from this: > > Acked-by: Pablo de Lara