DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: pallavi.kadam@intel.com
Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,
	bruce.richardson@intel.com, ferruh.yigit@intel.com,
	beilei.xing@intel.com, jia.guo@intel.com,
	Narcisa.Vasile@microsoft.com, talshn@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v3 0/2] Support i40e PMD on Windows
Date: Thu, 14 Jan 2021 23:55:32 +0100
Message-ID: <5230444.hLBB0F48ad@thomas> (raw)
In-Reply-To: <20201222004511.12948-1-pallavi.kadam@intel.com>

22/12/2020 01:45, Pallavi Kadam:
> Pallavi Kadam (2):
>   eal: add rte_random.c file on windows
>   build: i40e PMD on Windows

Applied, thanks

For info, I've fixed an additional warning in i40e compilation on Windows:
	drivers/net/i40e/i40e_hash.c:357:22: warning:
	comparison of integers of different signs:
	'enum rte_flow_item_type' and 'unsigned long long'

--- a/drivers/net/i40e/i40e_hash.c
+++ b/drivers/net/i40e/i40e_hash.c
@@ -354,9 +354,10 @@ i40e_hash_get_pattern_type(const struct rte_flow_item pattern[],
                }
 
                /* Check the previous item allows this sub-item. */
-               if (prev_item_type >= RTE_DIM(pattern_next_allow_items) ||
+               if (prev_item_type >= (enum rte_flow_item_type)
+                               RTE_DIM(pattern_next_allow_items) ||
                    !(pattern_next_allow_items[prev_item_type] &
-                   BIT_ULL(pattern->type)))
+                               BIT_ULL(pattern->type)))
                        goto not_sup;
 
                /* For VLAN item, it does no matter about to pattern type
@@ -372,7 +373,8 @@ i40e_hash_get_pattern_type(const struct rte_flow_item pattern[],
                }
 
                prev_item_type = last_item_type;
-               assert(last_item_type < RTE_DIM(pattern_item_header));
+               assert(last_item_type < (enum rte_flow_item_type)
+                               RTE_DIM(pattern_item_header));
                item_hdr = pattern_item_header[last_item_type];
                assert(item_hdr);




  parent reply	other threads:[~2021-01-14 22:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05  1:10 [dpdk-dev] [PATCH 0/3] " Pallavi Kadam
2020-12-05  1:10 ` [dpdk-dev] [PATCH 1/3] eal/windows: add some interrupt functions stub Pallavi Kadam
2020-12-05  1:10 ` [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows Pallavi Kadam
2020-12-05 13:52   ` Dmitry Kozlyuk
2020-12-09  0:09     ` Kadam, Pallavi
2020-12-06 15:49   ` Thomas Monjalon
2020-12-07  9:14     ` Bruce Richardson
2020-12-09  0:14       ` Kadam, Pallavi
2020-12-09  0:21     ` Kadam, Pallavi
2020-12-09  8:59       ` Thomas Monjalon
2020-12-17 23:17         ` Kadam, Pallavi
2020-12-05  1:10 ` [dpdk-dev] [PATCH 3/3] config/build: ignore enum forward reference warning Pallavi Kadam
2020-12-05 13:51   ` Dmitry Kozlyuk
2020-12-10  0:53   ` Narcisa Ana Maria Vasile
2020-12-17 23:15     ` Kadam, Pallavi
2020-12-17 22:59 ` [dpdk-dev] [PATCH v2 0/2] Support i40e PMD on Windows Pallavi Kadam
2020-12-17 22:59   ` [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows Pallavi Kadam
2020-12-18 11:29     ` Thomas Monjalon
2020-12-18 18:49       ` Kadam, Pallavi
2020-12-17 22:59   ` [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows Pallavi Kadam
2020-12-18 11:27     ` Thomas Monjalon
2020-12-18 18:42       ` Kadam, Pallavi
2020-12-22  0:45   ` [dpdk-dev] [PATCH v3 0/2] Support " Pallavi Kadam
2020-12-22  0:45     ` [dpdk-dev] [PATCH v3 1/2] eal: add rte_random.c file on windows Pallavi Kadam
2020-12-22  0:45     ` [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows Pallavi Kadam
2021-01-08 22:58       ` Jie Zhou
2021-01-13 22:52       ` Thomas Monjalon
2021-01-13 22:55         ` Ranjit Menon
2021-01-13 23:10           ` Thomas Monjalon
2021-01-14  1:51             ` Tal Shnaiderman
2021-01-14 22:55     ` Thomas Monjalon [this message]
2021-01-14 23:06       ` [dpdk-dev] [PATCH v3 0/2] Support " Ranjit Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5230444.hLBB0F48ad@thomas \
    --to=thomas@monjalon.net \
    --cc=Narcisa.Vasile@microsoft.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=ferruh.yigit@intel.com \
    --cc=jia.guo@intel.com \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git