From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f43.google.com (mail-bk0-f43.google.com [209.85.214.43]) by dpdk.org (Postfix) with ESMTP id 09EDF6831 for ; Mon, 16 Sep 2013 11:43:15 +0200 (CEST) Received: by mail-bk0-f43.google.com with SMTP id mz13so1433659bkb.30 for ; Mon, 16 Sep 2013 02:43:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=BH4BLpin/++JHuvAh+lHm9JhrQUR/yNqFaTIT9IRe7o=; b=i+OD21H8bZw2b5nDJ4gMTbx6CVTifUPBOmxtzfEOe+OGxbonY+GR8HomXbI+hJJUaW 8k1IyRBbPQirq3GhI+exw/6X5zxOaBwbdytkrRLgFpqCHjm4LjtzIa3btmSwJiD7WVio 0bcyJzvJOPqwiOM6MRix7mgrbfSiR0LilkZAlIaQnlFsAnoJPP2JqVPXbvvh/SgXVehO aciAEFF662jdXU3jpM8zDNnvLTspUZu8yC6wBl6sHsFcOzIQs9Hl5KK7PvXxl4j7FVdw CVSmdOqFkGkWqGm95dHEm0L3ercAN6vVzQT9kXnjeYVItpmnd7zjl4pBqVQqiEAqcMB7 3hjQ== X-Gm-Message-State: ALoCoQn9IG1vwToeMMpDfZB1LEC85Sv8rPmmEGlFEDoPknR1olcm6GerEd10o+AT3d/gi6kM6J3W X-Received: by 10.204.102.136 with SMTP id g8mr980199bko.34.1379324633807; Mon, 16 Sep 2013 02:43:53 -0700 (PDT) Received: from [10.16.0.189] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id qg7sm7055211bkb.6.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Sep 2013 02:43:53 -0700 (PDT) Message-ID: <5236D2D7.6000103@6wind.com> Date: Mon, 16 Sep 2013 11:43:51 +0200 From: Ivan Boule User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130827 Icedove/17.0.8 MIME-Version: 1.0 To: Thomas Monjalon References: <1379079521-28859-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1379079521-28859-1-git-send-email-thomas.monjalon@6wind.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: fix non-reconfigurable pmd init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2013 09:43:16 -0000 On 09/13/2013 03:38 PM, Thomas Monjalon wrote: > Some Poll-Mode Drivers (PMD) are not reconfigurable and, > thus, do not implement (rx|tx)_queue_release functions. > For these drivers, the functions rte_eth_dev_(rx|tx)_queue_config > must return an ENOTSUP error only when reconfiguring, > but not at initial configuration. > > Move the FUNC_PTR_OR_ERR_RET check into the case of reconfiguration. > > Signed-off-by: Thomas Monjalon > Acked-by: Ivan Boule -- Ivan Boule 6WIND Development Engineer