From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com [209.85.214.46]) by dpdk.org (Postfix) with ESMTP id 5B55E1F3 for ; Tue, 17 Sep 2013 13:25:45 +0200 (CEST) Received: by mail-bk0-f46.google.com with SMTP id 6so2057735bkj.5 for ; Tue, 17 Sep 2013 04:26:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=1d0/Xg21J4KgS8jHycX6b/t9w5NzDenHcLrAs0Xma7Y=; b=ShivO71D76Y47V3rgWStwciNEmaPRVyp4HZ25R5pHYDNAsMZSCUzZoohvgeJYFPqcu 6FjHBQvzajI2Nia24fjapKUS+Bdq6QS7bAKHWLv3/3KN+7XSgZFVB+CRn1Ox55whFFBo cCgSd7RbRWM2f13LCIm/XOSH7gLM9IKDNAUwZ5huu5SBCp0c09H0exHZoawgTfoiqjQL v8ZoxLyldpVzEJdD+y55xcTSPcX9KiKmEFIQxz2fI3P1UmOHPRE1ejDAHDK19wHgGAmi 24Vp1iJP8Ri+MeiDboervha69X8Bvvp+NppnV4bMM2U571vQq0HeUmIIrhFpEIo9aZHP C0jw== X-Gm-Message-State: ALoCoQlIBR5peetUtlgf+yYVNdtzhdxjOBvFJSxCYaO9fI8CsTWPvZNragAayOGTEB3o5IwZlAuF X-Received: by 10.205.65.17 with SMTP id xk17mr28459336bkb.19.1379417183427; Tue, 17 Sep 2013 04:26:23 -0700 (PDT) Received: from [10.16.0.97] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id l5sm4438670bko.7.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 17 Sep 2013 04:26:22 -0700 (PDT) Message-ID: <52383C5F.6010903@6wind.com> Date: Tue, 17 Sep 2013 13:26:23 +0200 From: Damien Millescamps User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: dev@dpdk.org References: <1379363340-20870-1-git-send-email-thomas.monjalon@6wind.com> <6d68788d4315a3c2e13e244b0658429334df2572.1379413101.git.thomas.monjalon@6wind.com> In-Reply-To: <6d68788d4315a3c2e13e244b0658429334df2572.1379413101.git.thomas.monjalon@6wind.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] pci: do not check BAR0 mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2013 11:25:45 -0000 On 09/17/2013 12:21 PM, Thomas Monjalon wrote: > From: David Marchand > > Since DPDK 1.4, bars mapping is checked and prevent from initializing > drivers which do not use igb_uio mapping. > There is no need to check for bars mapping, especially BAR0 is not required. > If bars mapping failed, then pci_uio_map_resource will fail and we won't reach > this check. So get rid of BAR0 check. > > Signed-off-by: David Marchand > Acked-by: Stephen Hemminger Acked-by: Damien Millescamps