From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DFD5943874;
Tue, 9 Jan 2024 17:58:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B3E714021F;
Tue, 9 Jan 2024 17:58:15 +0100 (CET)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam12on2060.outbound.protection.outlook.com [40.107.244.60])
by mails.dpdk.org (Postfix) with ESMTP id DE1984013F
for <dev@dpdk.org>; Tue, 9 Jan 2024 17:58:13 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=e0hS0d7s28CnoqCi+6hbWyA+Qnslnl6MvyXO9n3OjWA/Hkxgpwk0bC0SQnC8l+aVYIF/gLocP+PEneKuckOH+Z3WHg8bQOOoiKe+3sRGE8A5kYtp7ljTowVCOfGowfFE2+Y3TTIGb+dKG5N2A2vkOJxMmlN6YP9mMlqT1XOOsHzaH8TXT+zk70xoH94zj5a8S41KlDM6TfOztI+C7PWa6ZPetwHG0VzBOl8q5e67cJn16yjaTaM1s5PtUYLRuBIwLFE5rHQVlXr7cOXK2uyGhLJFAZLbZ935pO2qZI/nBEpBTSom3RD1b2f6rg2szIql87BZmuzUdHEX/NuBMSgptQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=NVWazpgHhFg4no7dsxjzlDtH1HcwHBdVxfMoE/Lu4Hk=;
b=TkqG6gW9I6McKcljYbn9bnyH0DRAL/taHSZa0tizwn83g1I4wxtALyj1kMKli967w/h6E8wRl6z9mTR08dU3WMvixaIWU3BUrREOgjNPjMStCW8cwVvkkYGdT4GMZH998bhn1Y7Ap4H5sTwKgZIv4oeT/GE4SPQ1Oy8fxeUt2AAYMtRUR/qfzPGDovmtajnAe/rhxmm9tlYezIjzrZ1NV144wycb3mrY8kmUAaQpfmjcAGjkD7LfB008FTVrGWQPozvEJAc8dFz3OHSCVchqAt/qrLqshyTya3A12i7BfOBStB1fadX+sGwMIkUYNJ02VhfMgmH7Ci9gxvDzi2N1RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=NVWazpgHhFg4no7dsxjzlDtH1HcwHBdVxfMoE/Lu4Hk=;
b=bgykaqiZTDW6JAsUFJcDPutHDjYeT2R9mtcp3/E0MQ8yXKynnGiKeuRq/2luxCMt3/01UJVxrCXBYZRVgY+HHampx3lC3bgyXX8NQsZvS+MEfUhWhbM39xrRM4OP/1QVOruYivCwz/9I4RkTnE+XPJHE3xkzuP3fbH09R+gipYc=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
by SJ2PR12MB9113.namprd12.prod.outlook.com (2603:10b6:a03:560::15)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan
2024 16:58:11 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024
16:58:11 +0000
Message-ID: <524262ad-9394-4879-a5e3-2e780df975cd@amd.com>
Date: Tue, 9 Jan 2024 16:58:04 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: rte_eth_dev_data reorganization needed
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
References: <20240108091440.4f8e25fb@hermes.local>
From: Ferruh Yigit <ferruh.yigit@amd.com>
Autocrypt: addr=ferruh.yigit@amd.com; keydata=
xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9
4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J
eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg
B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9
RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ
N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ
vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S
3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum
CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA
XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln
aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID
AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK
Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3
tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU
58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs
cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD
VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg
Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc
GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV
gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW
VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD
DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG
CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe
WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi
6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl
90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv
VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA
fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr
ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC
IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk
1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak
oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq
b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ
Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX
W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW
honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA
g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn
GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ
NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs
SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe
cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH
dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk=
Cc: Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Qi Z Zhang <qi.z.zhang@intel.com>
In-Reply-To: <20240108091440.4f8e25fb@hermes.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0245.DEUP281.PROD.OUTLOOK.COM
(2603:10a6:d10:af::6) To CH2PR12MB4294.namprd12.prod.outlook.com
(2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB9113:EE_
X-MS-Office365-Filtering-Correlation-Id: 8a055aa7-38ea-4136-fd4a-08dc113428f2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: m6H23LHWeaCTaUr0VOSFkJoy1LF62yzz5kGR6z4wbp5RErZLSMH0bNPeJGYV1gThub8z73wCdwIt06X38iMZzdXcEN+ITesNjynh0lNJH5Aln0FkqnjnzfTDZuntVN6PkVKz8+SzK0CZ51WFFu4xsgXi3Z2W7fYXX3QZR7nIrj6UF6SFJ8YplqI5kJiTbRI81Ig0Byy7sLFUIx17IMF/0SMtHtk8bRfSkIZOXccJEfO1JO0L1e6LbhdmIz1BwYQBOyU1Og6pYjHaxtC89f89wCW1P/t/c3TMCMrCJlioGStM+iyCu9L9O6xd13O/DKO/NwsSl4amuU07kVRsYyXNfm6y7MBt+cp/zbsLmdO4Y+bIOM/4OKKjG+ukxPsOLxmRTb2d+8eh0SdpcP9FpoBJQ9nqwJc9T7uoyD80oIqqhcIY29l9vlIz0u7pii0u6W1hFTGUaCpTWtJZDiiSpjYSFXXEGz+G+h8GhJlXu5hG9UeRUBBTwszzEMim8koyO1m8SJaKtCn7CYaJrjTFz0wV1pFi02ivd96T+OgQynDlQZthdDxmGVlDcWikrRbEelIVdu9uCmmg4YcY0I2ouXJqVwagXRg7lNd+uE/gIdiAVNmgMC7kqzKdY6egBJOq60sGcOELLBg1zG0Vnuv+gFb4/Jq3A90R53mVplPZVvmbgPM=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230031)(376002)(39860400002)(346002)(396003)(366004)(136003)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(31686004)(83380400001)(41300700001)(66946007)(36756003)(31696002)(86362001)(38100700002)(316002)(26005)(6512007)(2616005)(53546011)(6486002)(478600001)(66556008)(2906002)(66476007)(6666004)(54906003)(6506007)(44832011)(8936002)(8676002)(4326008)(7116003)(5660300002)(21314003)(43740500002)(45980500001);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHBGak0xWjZsSnNqTzlLQklpVm90dWN2bkpYeS83VTZkWWNEaUxqQXUwNmFu?=
=?utf-8?B?MlA1dmhseG9Hak4vQVVoSWg0Rkh6WnhGMmxNR3R6QnoxaGJYSk9meEZxVkl2?=
=?utf-8?B?NVo2MnlTTStySjR6SDg2aWNrcmIvUVY4MmlGTFM3UmJUMlozYTdTZEpheTdJ?=
=?utf-8?B?allsTEQ0dENQSzlQSWZhdFRYU01PTFFXdGNQNVBFaFhqLytTbWVrcU4vcWt1?=
=?utf-8?B?NUd6d3lCanRlN1lReERJSkt4bGVJb1lydk9LZVlMTW5mVHhXai9WMGNoMG4r?=
=?utf-8?B?WjlHRW4yWEtoQ1B2bzZzbzNkc1VWWjBOQm1taDJFRmNBU2hIU0ZnVCtKdVFl?=
=?utf-8?B?a1lLcVFsMkxrNXpsT1Q5aEUwVk9HaUJEL0grM0t3NlB1TTBpNnY5OVhYbGoy?=
=?utf-8?B?bnNCekJVYWI3ajFJT2ZiaFFhL29BR29keGxtRkM4K2ZxUVljWHdaM3JETTVh?=
=?utf-8?B?Smk4L2FzbHFLM2RQa0t1anRlVjIwUWl0bFFNbjFzRVFpUDc1bG1kajQ4N3Iv?=
=?utf-8?B?SnQzQnZ6YmdZRjJhVEZmSzlQcFFyeUVyOVpxSjNaL2JzN21HRzltV2JjckhR?=
=?utf-8?B?MWVOOEhweHVPNWpNRGNybFJIS2dPcm11VHI5WkQ4aEVBeGF0bmU4Yll1dTVx?=
=?utf-8?B?SGVuU0pCOVdGcUNGbjE0aW53aDl4UXBPU2FPQVlib21JV2VteWZaSkU0TGls?=
=?utf-8?B?NTFFRFlmOXc1Vkwvc0VPS1BGWXBsd2JsZ1Q3SEpyY00reFdmdE8xQ3BkcDE3?=
=?utf-8?B?dUg1MGMyNVpkc2JGRzFReFhsbkJHclQvL3FGRjFzWXBURVhiMFNOeDVOUGx6?=
=?utf-8?B?a1hjdXcxQ3hMTG1zV2grZDYrc09DTGd6Ym00U0RNdkdFZENIdzhtYXoyb21M?=
=?utf-8?B?VHFtTE9XMUE5WURKcFYvV0xpNTIvU3NOaE9ibTBIdC9BcGNQVzNXS3puY21o?=
=?utf-8?B?TUVXeFBnOFVYOUpYQVRkckwrcXZ2Qy8vRWk1SE5aNjc2c0w4cEdaaldiMllk?=
=?utf-8?B?S2JhSFhVTUQzY09Ea2hDN3NYeHR2SVd6Rit5dnBkRjdHalN3R0pTK1V1Q29W?=
=?utf-8?B?cWdqZ2MzeDY1V2pYbkJBZmdzbnBpYkY2Wm9URUUxYkJ2eTU4bm5sT1M3Z0o5?=
=?utf-8?B?eXJZZ3RQNzRjdlppWTlFazFzRUwyZi81bmp0SElZV3Z0c2REWGZNa3pMcUYz?=
=?utf-8?B?ZWRNSEhzaGEvRUswL21qd3l0LzBkdWtwL1JKQkRlTzhPdWlHQVJyZTh6dDBa?=
=?utf-8?B?QnEvSUh3c1ZHWE5XZnBEWHBjeUxkTmZKekgzNklVbUtkcWNCRzl2WWMwVnhS?=
=?utf-8?B?NGNUZ3NUVTltYVQyU0FtcnhHTG16YW4rdGJkb09Sbk1vRlh6VE05RnRPZHFr?=
=?utf-8?B?YmxWVVQzQjdQQm9yNE13SDB1Mjd0RVB6SHdsZnRDci9SWllvZXRLZTR6cjJk?=
=?utf-8?B?bzEvQVUyS1c4aE5WaUVGeGFXRFhjSDR3VFNkYlJzazVuRXJhbHdzTFF1SStV?=
=?utf-8?B?blNVclk1d1lKc2JKRGtnWTVxTjdic0I2b0R2R2ZuUVRYbVpMbjBjQmN5UGZh?=
=?utf-8?B?b2U4TnhHRzBWZStNR3U3QkxnelJxcUNiZUp4M2VVMmtBY2RhSFBJdm8rV3dB?=
=?utf-8?B?eGpSMXZ3VUQxN3RSaVp3V1hHaG5OdWRWZmlhdmNpNHlaNVpMWVc0Y1RLU2Vm?=
=?utf-8?B?L1pRNlBnVXc2cDJndnJ0Q0M0M3dIUVdGRUtqd1BVZkFpemwralE4M2tERXdW?=
=?utf-8?B?MzBXT2pBVTVFWU5uSi9SVnloYncwbWVkT096WTI0Q3VOYVhnem9PeExwbnVN?=
=?utf-8?B?anlveWNuNHVwVEswa2FLWWpMVW9zVGdmYXlWc05nZnhXeDY2V2wxNmpXb2Na?=
=?utf-8?B?a0xiMlNWeFcremFLQjJieWtmdm81WUZGM090MnFCcWM1aWhNUGhoRTJtUisy?=
=?utf-8?B?eG1OVlhIeGVEaUxlUm9zQXgvWXFFSmFUT2R0WWhSa25CcTlhcSs4c3pRZ2JU?=
=?utf-8?B?SnRJcHJKZ0kxZU1RcHhBQzFwR2tLZXRMdEZBcytiU1JMQnl3TWVCRTllT3BW?=
=?utf-8?B?TW0veE9mMlNuc3plVklEMkdtaWkxWGJqK2tQL0VoRDVPYzhFTTVWcXVzZGho?=
=?utf-8?Q?Hm1I=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a055aa7-38ea-4136-fd4a-08dc113428f2
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 16:58:10.9429 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0POpu7TQHrJ/YTdhIcj9dVWbATsRyMblFTk7T+rT2CHT8NjjCRUjYiuihv47bjE3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9113
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 1/8/2024 5:14 PM, Stephen Hemminger wrote:
> While looking at ethdev (for pdump issues) noticed.
> The rte_eth_dev_data structure layout is unorganized.
> Lots of holes, fields not arranged in logical groups
> and usage could be localized for better cache access.
>
For reference following is structure layout [1].
Agree that it can benefit from reorganization.
> Obviously, any reorg is ABI break. We should do this for 24.11
>
It may not be an ABI break, since structure moved to ethdev_driver.h
with recent changes, it is not exposed to user directly anymore.
eth_dev_data is device data and it is not directly involved in the
datapath, although I can see 'rx_mbuf_alloc_failed' stats is updated in
datapath, and some drivers access 'dev_private' in datapath, most of
other fields are configuration related.
So, although I expect changes in eth_dev_data doesn't impact the
performance it needs to be tested and verified.
As this release looks mostly quite, perhaps it can be good time to try
this kind of change, what do you think to start reorg in this release?
[1]
struct rte_eth_dev_data {
char name[64]; /* 0 64 */
/* --- cacheline 1 boundary (64 bytes) --- */
void * * rx_queues; /* 64 8 */
void * * tx_queues; /* 72 8 */
uint16_t nb_rx_queues; /* 80 2 */
uint16_t nb_tx_queues; /* 82 2 */
struct rte_eth_dev_sriov sriov; /* 84 6 */
/* XXX 6 bytes hole, try to pack */
void * dev_private; /* 96 8 */
struct rte_eth_link dev_link __attribute__((__aligned__(8))); /*
104 8 */
/* XXX last struct has 2 bytes of padding */
struct rte_eth_conf dev_conf; /* 112 2280 */
/* XXX last struct has 4 bytes of padding */
/* --- cacheline 37 boundary (2368 bytes) was 24 bytes ago --- */
uint16_t mtu; /* 2392 2 */
/* XXX 2 bytes hole, try to pack */
uint32_t min_rx_buf_size; /* 2396 4 */
uint64_t rx_mbuf_alloc_failed; /* 2400 8 */
struct rte_ether_addr * mac_addrs; /* 2408 8 */
uint64_t mac_pool_sel[128]; /* 2416 1024 */
/* --- cacheline 53 boundary (3392 bytes) was 48 bytes ago --- */
struct rte_ether_addr * hash_mac_addrs; /* 3440 8 */
uint16_t port_id; /* 3448 2 */
uint8_t promiscuous:1; /* 3450: 0 1 */
uint8_t scattered_rx:1; /* 3450: 1 1 */
uint8_t all_multicast:1; /* 3450: 2 1 */
uint8_t dev_started:1; /* 3450: 3 1 */
uint8_t lro:1; /* 3450: 4 1 */
uint8_t dev_configured:1; /* 3450: 5 1 */
uint8_t flow_configured:1; /* 3450: 6 1 */
/* XXX 1 bit hole, try to pack */
uint8_t rx_queue_state[1024]; /* 3451 1024 */
/* --- cacheline 69 boundary (4416 bytes) was 59 bytes ago --- */
uint8_t tx_queue_state[1024]; /* 4475 1024 */
/* XXX 1 byte hole, try to pack */
/* --- cacheline 85 boundary (5440 bytes) was 60 bytes ago --- */
uint32_t dev_flags; /* 5500 4 */
/* --- cacheline 86 boundary (5504 bytes) --- */
int numa_node; /* 5504 4 */
/* XXX 4 bytes hole, try to pack */
struct rte_vlan_filter_conf vlan_filter_conf; /* 5512 512 */
/* --- cacheline 94 boundary (6016 bytes) was 8 bytes ago --- */
struct rte_eth_dev_owner owner; /* 6024 72 */
/* --- cacheline 95 boundary (6080 bytes) was 16 bytes ago --- */
uint16_t representor_id; /* 6096 2 */
uint16_t backer_port_id; /* 6098 2 */
/* XXX 4 bytes hole, try to pack */
pthread_mutex_t flow_ops_mutex; /* 6104 40 */
/* size: 6144, cachelines: 96, members: 32 */
/* sum members: 6126, holes: 5, sum holes: 17 */
/* sum bitfield members: 7 bits, bit holes: 1, sum bit holes: 1 bits */
/* paddings: 2, sum paddings: 6 */
/* forced alignments: 1 */
} __attribute__((__aligned__(64)));