From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DBEDA0545; Mon, 3 Aug 2020 20:51:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CA322BD8; Mon, 3 Aug 2020 20:51:11 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 382502952 for <dev@dpdk.org>; Mon, 3 Aug 2020 20:51:10 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A49858041D; Mon, 3 Aug 2020 14:51:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 03 Aug 2020 14:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= hUkb+0F8E1I7gSaWZdj7SuoOqP6Gd9goJdTug2OE4ZE=; b=IY08A3uRjJMadFmU YF+zyIu/AqkCaKSSCZRYoQdvXMKa3EPsWELqDTs0VGlKTkH5d70yiv3J798Ergtk LNIBdNjtzuq6g28ZGNzLZSWMEUQMTpF6C6vMTMtOjSgxUipmvY0+FEQX0MvRH8EO +vfWkAhVSgCi060z9lsyHbXuUD3BVWdKz+qb+3wZTq0pH+JdXLuQuRD/Bu9FirQO 4S6Rdb9C5Riku5kBSkPHJPJXGe3LkqpEx/rJREScQ7y/9Hk0eUGNF1xb2LKuaXwP QB9e1HtpmISHYXhKAVyaUwzFHAkIdfa2YPvm6kfmOio74DtEyXkhjclm1F7ev534 jQKsIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=hUkb+0F8E1I7gSaWZdj7SuoOqP6Gd9goJdTug2OE4 ZE=; b=KNO1/a9hrTNqNtCylPnetHGfZd6PZ4Rsuq3NCd3LFmMZjJ1N4s5KZXgvz nPm+bQtV5hwXwSjU49K04ZLavDJ64YGaJWg94Gon2a2YzbHUIvZBVkJLPK6UDJAJ CYYO11jhaocTxBtSoeR6Nh/aNBtBGdm2aKaXso2AAhbMHKHobCYzFI/uKXMCgtfj hDt27RUkydgTLS5OSuPEkqeR6SyDIKNoEKSrxWs4vn7QD/8sVWKMvsx9WNJK5kAm e+eN7XV2Q/92pNgG62UgfMQiF64FZBn1wQ3EI8kW05nZTAl1ZhYc/kYRUC8lM2da QBm7buO4AgFc1NTye4/lAgY3Wh8pg== X-ME-Sender: <xms:mlwoX4NSeq1iPzebCT03j7YdALyCV9oK3QwcrKToSwQtdU4k5v2gEQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeeggddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:mlwoX-_v8LU_xxMZvrLBxUM_aebzPjQw4Ka3mg8jqb_rw5ta2yEtKg> <xmx:mlwoX_Q621h_mmsw6ytcgc18IfW_wKj9fvChTyhrUNpEznLvmC3ANA> <xmx:mlwoXwu-IgKubciLuokhz9FXKN6YjsNw1SVkAB70w2ZMaacEVIPvbA> <xmx:nVwoX3tW7q_fbbwxugbhBjjT68rXYU9ul5m7oV2MBWGih1ANAg19UQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 17E0C3280066; Mon, 3 Aug 2020 14:51:00 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "John W. Linville" <linville@tuxdriver.com>, Qi Zhang <qi.z.zhang@intel.com>, Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>, Igor Russkikh <igor.russkikh@aquantia.com>, Pavel Belous <pavel.belous@aquantia.com>, Matt Peters <matt.peters@windriver.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>, Gagandeep Singh <g.singh@nxp.com>, John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, Gaetan Rivet <grive@u256.net>, Xiao Wang <xiao.w.wang@intel.com>, Qiming Yang <qiming.yang@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Shijith Thotton <sthotton@marvell.com>, Srisivasubramanian Srinivasan <srinivasan@marvell.com>, Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>, Stephen Hemminger <sthemmin@microsoft.com>, "K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Jerin Jacob <jerinj@marvell.com>, Bruce Richardson <bruce.richardson@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Jasvinder Singh <jasvinder.singh@intel.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Keith Wiles <keith.wiles@intel.com>, Maciej Czekaj <mczekaj@marvell.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, Zhihong Wang <zhihong.wang@intel.com>, Yong Wang <yongwang@vmware.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Beilei Xing <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com> Cc: Rosen Xu <rosen.xu@intel.com>, dev@dpdk.org, Ciara Loftus <ciara.loftus@intel.com>, Steven Webster <steven.webster@windriver.com>, Somalapuram Amaranath <asomalap@amd.com>, xavier.huwei@huawei.com, Sachin Saxena <sachin.saxena@nxp.com>, Wei Zhao <wei.zhao1@intel.com>, Jeff Guo <jia.guo@intel.com>, Igor Chauskin <igorch@amazon.com>, Ziyang Xuan <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>, Guoyang Zhou <zhouguoyang@huawei.com>, "Min Hu (Connor)" <humin29@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, Alfredo Cardigliano <cardigliano@ntop.org>, Jakub Grajciar <jgrajcia@cisco.com>, Viacheslav Ovsiienko <viacheslavo@mellanox.com>, Long Li <longli@microsoft.com>, Martin Spinler <spinler@cesnet.cz>, Heinrich Kuhn <heinrich.kuhn@netronome.com>, Harman Kalra <hkalra@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Akhil Goyal <akhil.goyal@nxp.com> Date: Mon, 03 Aug 2020 20:50:58 +0200 Message-ID: <5248162.j6AOsuQRmx@thomas> In-Reply-To: <30528485.5cHeq7CNxZ@xps> References: <30528485.5cHeq7CNxZ@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 18/04/2019 12:59, Thomas Monjalon: > Hi all, > > Since DPDK 18.11, the behaviour of the close operation is changed > if RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: > port is released (i.e. totally freed and data erased) on close. > This new behaviour is enabled per driver for a migration period. > > Looking at the code, you can see these comments: > /* old behaviour: only free queue arrays */ > RTE_ETHDEV_LOG(DEBUG, "Port closing is using an old behaviour.\n" > "The driver %s should migrate to the new behaviour.\n", > /* new behaviour: send event + reset state + free all data */ > > You can find an advice in the commit: > http://git.dpdk.org/dpdk/commit/?id=23ea57a2a > " > When enabling RTE_ETH_DEV_CLOSE_REMOVE, > the PMD must free all its private resources for the port, > in its dev_close function. > It is advised to call the dev_close function in the remove function > in order to support removing a device without closing its ports. > " > > It would be great to complete this migration for the next LTS > version, which will be 19.11. For the record, it did not happen in 19.11. > It means the work should be ideally finished during the summer. > > The migration to the new behaviour is done in 4 drivers: > git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 > ena > enic > mlx5 > vmxnet3 > > Following drivers should be migrated: > ( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 ) | sort | uniq -u [...] The progress in April 2019 was 4 of 46 (9%). > Please let's progress smoothly on this topic, thanks. More than one year later, the progress is 26 of 53 (49%). > The concerned maintainers (Cc) can be found with the following command: > devtools/get-maintainer.sh $(( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f-3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers ) | sort | uniq -u) We cannot wait forever. Temporary cannot be longer than 2 years. I am going to send a deprecation notice to remove the "temporary" flag RTE_ETH_DEV_CLOSE_REMOVE. It will break drivers which are not migrated. It will probably help to find motivation in new priorities. More details on what to do can be found in this mail thread: http://inbox.dpdk.org/dev/1748144.UFpUr2FPnr@xps/