From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 196CF2A5E for ; Wed, 23 Mar 2016 11:39:56 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id p65so227581459wmp.1 for ; Wed, 23 Mar 2016 03:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=nKP1qf+guXZSuUvI0BcAFzY8p1y1M2ms15ZNuBbKRaA=; b=d8J/X2KIP2i68UD0A8Ve1TjA23E1AJgiGAFFVfymnbnXgyjVjdw9Iw/2HcWplZkPfP nEETftgUCnhuaLysu3OaFxmE6CNkg3O+5n/Ma/nDUna0B0pGLjGai77OG+iVksUAXh3v dXrHY9NDEvihooqQHRArthqDBGvoH9YkzKk00PgdLQq08l7vE4euT9rfhmdUlpwo7lat GIFs7Kb1EDg3IE2lHg4xIni4ajmSZPU5pCNFAaQeFSwBx03zo+o6nJte1R7JFp1ZzvUn 0qBnV/70amIU78C8hQ+PUIhqKLnxQ25qepTpLZloaVB6TaAWImfv0xzfXsAsm2uIyU3Z EWDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=nKP1qf+guXZSuUvI0BcAFzY8p1y1M2ms15ZNuBbKRaA=; b=Oz2LzwwKno1aVINtYrd7w7rmb13OocqMq5vPKBRP36FV3wh2tmBsTSHvXjLrladL0T /fEMy6r9wQz4fT+lgOjJpFebKkiqo/Uib3RO7TBncm0IZ6jHJ8CvKzkwzRmeuQOcPsHa cIyDJSk1m9Dc/63ehCYZk8EKFOm3At/Y8KmPjQawhYS5K2kDFFDRfo8C7tfZp8NGFMIm HUFXXj7HeoiYZtSB9KReYwgCal6uh1okdX3S5U/Qn426byDPWt8RJJWyW7VamAzjMLiZ 7sCAr32vhZ3XiZxU6Ai04UfXpyQa2/nNPmby4qXdjQOR10WyVFL1wzb/quwuFvmjMZ4i uoYg== X-Gm-Message-State: AD7BkJLx1PpsNpzWKZR72Anixgu8VYjG5qAlooNaFbDm8q7D1L7KWfS+b3ZhKDiTtEZ9F7HW X-Received: by 10.28.23.70 with SMTP id 67mr2962009wmx.70.1458729595968; Wed, 23 Mar 2016 03:39:55 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id h67sm2271924wmf.15.2016.03.23.03.39.55 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Mar 2016 03:39:55 -0700 (PDT) From: Thomas Monjalon To: Wenzhuo Lu Cc: Aaron Conole , dev@dpdk.org Date: Wed, 23 Mar 2016 11:38:14 +0100 Message-ID: <5248499.WRMHcbhMjp@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458682638-28378-3-git-send-email-aconole@redhat.com> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <1458682638-28378-3-git-send-email-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 10:39:56 -0000 2016-03-22 17:37, Aaron Conole: > The register read/write mphy functions have misleading whitespace around > the locked check. This cleanup merely preserves the existing functionality > while improving the ready check. > > Fixes commit 38db3f7f50bd ("e1000: update base driver") > > Signed-off-by: Aaron Conole > --- > v2: > * Changed from "whitespace-only" fix to a functional change > moving the phy writes into protection of the `if (locked)` > code > * Added "Fixes" line. Wenzhuo, do you agree to fix the base driver here?