From: Akhil Goyal <akhil.goyal@nxp.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix queue pair free
Date: Mon, 12 Nov 2018 12:50:08 +0000 [thread overview]
Message-ID: <524d4669-d726-d97d-c0f4-3cef6883ff0c@nxp.com> (raw)
In-Reply-To: <20181016094554.36422-1-roy.fan.zhang@intel.com>
On 10/16/2018 3:15 PM, Fan Zhang wrote:
> This patch fixes the queue pair free for AESNI-MB PMD. Originally
> the queue pair ring name are different than the object name,
> caused the aesni_mb_pmd_qp_release() cannot find the ring to
> release. This patch uses the same name between queue pair object
> name and ring name.
>
> Fixes: a831c318c54d ("crypto/aesni_mb: free ring memory on queue release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index 43f6c26ed..f3eff2685 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -535,14 +535,12 @@ aesni_mb_pmd_qp_set_unique_name(struct rte_cryptodev *dev,
> /** Create a ring to place processed operations on */
> static struct rte_ring *
> aesni_mb_pmd_qp_create_processed_ops_ring(struct aesni_mb_qp *qp,
> - const char *str, unsigned int ring_size, int socket_id)
> + unsigned int ring_size, int socket_id)
> {
> struct rte_ring *r;
> char ring_name[RTE_CRYPTODEV_NAME_MAX_LEN];
>
> - unsigned int n = snprintf(ring_name, sizeof(ring_name),
> - "%s_%s",
> - qp->name, str);
> + unsigned int n = snprintf(ring_name, sizeof(ring_name), "%s", qp->name);
>
> if (n >= sizeof(ring_name))
> return NULL;
> @@ -600,7 +598,7 @@ aesni_mb_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
> qp->op_fns = &job_ops[internals->vector_mode];
>
> qp->ingress_queue = aesni_mb_pmd_qp_create_processed_ops_ring(qp,
> - "ingress", qp_conf->nb_descriptors, socket_id);
> + qp_conf->nb_descriptors, socket_id);
> if (qp->ingress_queue == NULL) {
> ret = -1;
> goto qp_setup_cleanup;
Applied to dpdk-next-crypto
Thanks.
prev parent reply other threads:[~2018-11-12 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 9:45 Fan Zhang
2018-11-12 12:50 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524d4669-d726-d97d-c0f4-3cef6883ff0c@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).