From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A918B3572
 for <dev@dpdk.org>; Sun, 27 May 2018 21:47:23 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 2B91721ABB;
 Sun, 27 May 2018 15:47:23 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 27 May 2018 15:47:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Hm+1WMV9PEsxnoIVfDsp7KOVls
 PEwmov7J1pMUto+bs=; b=AKaKwbYTIDYIN0cmv8gXokIzPI+RPqSskQ0UBNh58F
 bTFT+GsPJmMGP2JdeIPCBKG3/6pzu4abcD/Jx47g9BIqTGQ66wTzZg7s2fb5rzbs
 OEzPqFIb1JeJVv9veIfMSDY2zN1DQNQHWLCeNv0fzncogfU6CgMYK3ylsrDJwJzt
 c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Hm+1WM
 V9PEsxnoIVfDsp7KOVlsPEwmov7J1pMUto+bs=; b=nwznunGFbDAP7ETcAJNKVJ
 JLN3P8woy1a2Zrq313Thy8/Nq6XA7/NbIL8ei4dtOwar0r0T8B01odV47kKgp/aM
 zQnuubdpaAD8vZQfM8HjCgbyyTAhOyEY+171gvrARsbogQUin+Rvps+VuS7prQW4
 Up1sRRZ2Dt9z/w8qguvwWAf7A9czpdkd194J6rvXqjsbkeZBlIFcr68TqEAncc48
 uzMmvQHMcsinpro1aN8VTOnJGZwh3HhW+PSMjNZsEa2EDI3wlfAaoa60+nQMOtg8
 U2zbdUmepouyMpPqkwXZS6XgJFh/QA80YeSdOp/WBYgiDPbaHqelIifUq1as50Fw
 ==
X-ME-Proxy: <xmx:SgsLW_qbhCoz-dFtL-zDrPK-Ge_eoQlqh2PsHVAZafvXAdsc4VQYSQ>
X-ME-Proxy: <xmx:SgsLW9BZFGLmToI7q6RJR9YLSwtdZGuMLkOYJGVrJFaOp5p8xdmJXQ>
X-ME-Proxy: <xmx:SwsLW3cwImj3ALZOWYZYcs3MDi0PRLSOONjfZkNxpC4spJXZo4r1xQ>
X-ME-Proxy: <xmx:SwsLW0b8iSSOcGsaUG5Wyf2HbYe4Qm1jdJ12ogBsMq43Wv4slfRvsQ>
X-ME-Proxy: <xmx:SwsLW_utO64f5zluQ87FSQLg08uGPXKj5lLvYxkFvh0APMoN9Dj-cA>
X-ME-Proxy: <xmx:SwsLW0vEPqZGgm76q4g_Ym_egGOkqHAbPrFEmo7JLnELWeq2tasmhw>
X-ME-Sender: <xms:SgsLWx-6PY-HnWe9SZV8_28E9MDsEm3Wiggyp26z0gCeZu19PXHaTw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id DF971E427A;
 Sun, 27 May 2018 15:47:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, wenzhuo.lu@intel.com,
 declan.doherty@intel.com, jerin.jacob@caviumnetworks.com,
 bruce.richardson@intel.com, ferruh.yigit@intel.com,
 Neil Horman <nhorman@tuxdriver.com>
Date: Sun, 27 May 2018 21:47:20 +0200
Message-ID: <5254321.ZC84c43z8L@xps>
In-Reply-To: <1525070752-21085-1-git-send-email-arnon@qwilt.com>
References: <1524723664-30510-11-git-send-email-arnon@qwilt.com>
 <1525070752-21085-1-git-send-email-arnon@qwilt.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v10] devtools: alert on new instances of
	rte_panic and rte_exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 27 May 2018 19:47:23 -0000

Hi,

30/04/2018 08:45, Arnon Warshavsky:
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> +		check_forbidden_additions -

This is consuming stdin.
I guess the checkpatch.pl will have nothing to check in the next step.
We should merge Neil's patch first, because he is adding a tmpfile
to solve the issue of stdin read only once.

> +		[ $? -eq 0 ] || return 0

This test looks reversed: if the result is not 0, we should not return 0.
And by the way, I think it is better to continue with other checks.
Neil's patch is setting ret=1, continue and return at the end.

>  		report=$($DPDK_CHECKPATCH_PATH $options - 2>/dev/null)