From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70187A04F0; Mon, 16 Dec 2019 18:45:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C16B42B86; Mon, 16 Dec 2019 18:45:35 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E3A631F5 for ; Mon, 16 Dec 2019 18:45:33 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 43DAE220C9; Mon, 16 Dec 2019 12:45:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Dec 2019 12:45:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SCN7meHN5QS2bECpNKhcRLts12yeVZTVlxvjdCma6gw=; b=ZUq81aTffNbW D0D3Splc+E81DIDd0Y0jq2f8+hOjz3/oBKjYml7EqxspZEqHVee+rDPhSFMYoK/b TSknSbi1eEfHcv3QMIF6tIyLWdwyug7iDGuarAEpIdWUzU3oZS7nhF4CvRp+0ZfZ TzOOY77KQHaTqj2cuevJJz8+vuXGnpE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=SCN7meHN5QS2bECpNKhcRLts12yeVZTVlxvjdCma6 gw=; b=BEIlaCxxBH79HEyRfxgAAAG2cWASmyLDzOIz/qSGfraB3jo3RrO+WpHDY xI8A/+2XJJQLapJPaziRfvfA9a/puTq3MiZY+yoWMwPuldr+/qFETwQKc7PKwQTi gOl3QPT4fel4Cz019UY9vx3gLEwCUf/5KncUQgnZ3/PPH1NyUH9RuhyuSZe34+8Q hYRx4jvh7CAPsMuSPlL3Jz18X1TOoGVn2fz+pGgTv/kXEcKy6JPiJooVlA3rPjk8 3BkEEPqvXtby6cNent6S//iuyOIEgQoe5AjZpm7BW0h+lfqT4fS9+ZRl18DXWYXT h3QjGzgF/79kC2HjXRjsc8u86RUTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddthedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhepfhhrvggvsghsugdrohhrghenucfkphepjeejrddufeegrddvtdefrddu keegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AFC388005C; Mon, 16 Dec 2019 12:45:31 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, olivier.matz@6wind.com, Ali Alnubani , David Marchand Date: Mon, 16 Dec 2019 18:45:30 +0100 Message-ID: <52551437.QWM23urDZO@xps> In-Reply-To: <20191216165910.GA452@bricha3-MOBL.ger.corp.intel.com> References: <20191216162242.1898285-1-thomas@monjalon.net> <1692365.TPV5GobrPX@xps> <20191216165910.GA452@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: avoid config backup during test build setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/12/2019 17:59, Bruce Richardson: > On Mon, Dec 16, 2019 at 05:47:03PM +0100, Thomas Monjalon wrote: > > 16/12/2019 17:40, Bruce Richardson: > > > On Mon, Dec 16, 2019 at 05:22:42PM +0100, Thomas Monjalon wrote: > > > > The config options are updated with sed and the short inline option. > > > > In FreeBSD, the suffix argument of the inline option is mandatory. > > > > In order to avoid creating a backup file when using sed inline, > > > > the argument is set as an empty suffix. > > > > > > > > The short option '-i' does not expect '=' before the suffix argument, > > > > so it understands '=' as the file suffix. > > > > As a consequence, a backup file named '.config=' was created > > > > in the build directory. > > > > > > > > Removing the '=' sign while keeping an empty suffix > > > > avoids creating a backup file. > > > > > > > > Fixes: 4a4a20c4775b ("devtools: support FreeBSD") > > > > Cc: olivier.matz@6wind.com > > > > Cc: stable@dpdk.org > > > > > > > > Reported-by: Ali Alnubani > > > > Signed-off-by: Thomas Monjalon > > > > --- > > > > > > > > This patch does not work on FreeBSD. > > > > Does it mean the equal sign is required on FreeBSD? > > > > This is not what I see on the documentation: > > > > https://www.freebsd.org/cgi/man.cgi?query=sed&sektion=&n=1 > > > > > > > > --- > > > > > > It appears it is needed, which is why the "=" was added in the first place. > > > See commit: 4a4a20c4775b ("devtools: support FreeBSD"), by Olivier > > > > > > Is having the backup file a big issue? > > > > No it's not a big issue. > > But I really would like to know how to have a common behaviour on BSD an Linux > > for a thing as simple as "sed -i" ! > > And why the mandatory "=" is not documented on FreeBSD? > > > > It cannot be so much broken. We probably miss something... > > > I think FreeBSD just requires a space between the -i and the ''. Testing > that seems to work for me on BSD. I assume it also should work on Linux. Thanks Bruce, I will send a v2.