From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DA1DA0A05; Tue, 19 Jan 2021 15:31:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5E2A140EAF; Tue, 19 Jan 2021 15:31:52 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 94A37140EA1; Tue, 19 Jan 2021 15:31:49 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 423245C0118; Tue, 19 Jan 2021 09:31:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 09:31:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= p/5buNXJlFTem/4kDXw3mGAc/7v32sh+tbJgwjqkEe0=; b=tJbnLsDIhkgW4Wa6 TZ9zSJOBNtjRPNUNm4ZqxJphLF6asVscIdDfVni74JKnvzhGpc/R597/On60uTa4 A3zyd06+ykNCityM0yiGdYvZiuBKi5Ecmnv4a8bVNp9jbRulzX0pv81E/Sp4PV2D aGxdTlO1nf6wsZUuqqlZeQKJsSx4p0MEC0UdD6ReAzA0VEKzlZIkmydwz7aJ9Cr5 It2NSchcqCd+JUPBqE+HV5FvExpiEireCXjmuCxqCdaw5Hyk7ZVqmAxvSZlOYkaf VNnFwA+p+2iOMhq/z5ZIiNiyYWHE0U4qMlAR4bSEYdQTtZBZ+hhenHgPULnk8MEM nN7ifg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=p/5buNXJlFTem/4kDXw3mGAc/7v32sh+tbJgwjqkE e0=; b=kp7d0GujndlozIzj9td6s++2ZQDFjyOZsW3TC7+hyI8HdzE4q0hf583qE rG8GZ/V3FJKOEb0Vb5mnbJuLNF6JDpJ24tLhPbzJT8fAZvEX6WJ5v1gXC7T+DOHB ejg7QBAvT6UGAsYqdFY+P6OskQZ1nH4fX9RbXcsOqeGYRdcxA68FtHknIHamwxN/ 2e+QPa823umkp2y9NMQvAiIklrT6Ea+MgFKmLr3g7wFfstczebqf5XOlwvJaG88s Lj+6qENZxTrECMtiKUI+vr/o4Qex/2EP1N+/lxF78MgKyXtDW2qrISUwO7/q+ix3 k6PhtzoHJr4MXYZ2t1+itXdvPj1ew== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4B472240066; Tue, 19 Jan 2021 09:31:48 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , David Hunt Cc: dev@dpdk.org, stable@dpdk.org, anatoly.burakov@intel.com Date: Tue, 19 Jan 2021 15:31:47 +0100 Message-ID: <5259190.4FFyF7rmBE@thomas> In-Reply-To: <20210108143048.23755-3-david.hunt@intel.com> References: <20201217113656.28884-1-david.hunt@intel.com> <20210108143048.23755-1-david.hunt@intel.com> <20210108143048.23755-3-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/6] power: make channel msg functions public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/01/2021 15:30, David Hunt: > From: Bruce Richardson > > Move the 2 public functions into rte_power_guest_channel.h [...] > +/** > + * Send a message contained in pkt over the Virtio-Serial to the host endpoint. > + * > + * @param pkt > + * Pointer to a populated struct channel_packet > + * > + * @param lcore_id > + * lcore_id. > + * > + * @return > + * - 0 on success. > + * - Negative on error. > + */ > +int rte_power_guest_channel_send_msg(struct channel_packet *pkt, > + unsigned int lcore_id); > + > +/** > + * Receive a message contained in pkt over the Virtio-Serial > + * from the host endpoint. > + * > + * @param pkt > + * Pointer to channel_packet or > + * channel_packet_freq_list struct. > + * > + * @param pkt_len > + * Size of expected data packet. > + * > + * @param lcore_id > + * lcore_id. > + * > + * @return > + * - 0 on success. > + * - Negative on error. > + */ > +__rte_experimental > +int > +rte_power_guest_channel_receive_msg(void *pkt, > + size_t pkt_len, > + unsigned int lcore_id); Why only the second one is experimental? Given the uncertainty of this API, I think it should be all experimental.