From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D88E3A04DD; Tue, 20 Oct 2020 11:17:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08203BCE9; Tue, 20 Oct 2020 11:11:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 6B9D5BCE0 for ; Tue, 20 Oct 2020 11:11:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603185079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U2+wnudrALkttGesZfMgj4Z1vgMlwVSncHsIDozQ9ZA=; b=KbvaVWym7a+OZ2itpPcoyESQCOFplNJrpayVUKRE5xYZafnBzb9WekUVjFWs7KVsbsUeB3 i0VOCHz5k4GPYNuPjiqw3Pmx/veJdOYFSx06mIHExfTfGlhxyjzzgQ2fgQlxEX7X69BweT Uk/zHIvZrJAfV2FqKBqY79yokokSe90= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-N9JC7c_MN7SGPHszOSKHZg-1; Tue, 20 Oct 2020 05:11:15 -0400 X-MC-Unique: N9JC7c_MN7SGPHszOSKHZg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C12E8108597C; Tue, 20 Oct 2020 09:11:13 +0000 (UTC) Received: from [10.36.110.40] (unknown [10.36.110.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F9951A92D; Tue, 20 Oct 2020 09:11:09 +0000 (UTC) To: Kevin Traynor , Adrian Moreno , dev@dpdk.org Cc: yinan.wang@intel.com, patrick.fu@intel.com, stable@dpdk.org, Chenbo Xia , Zhihong Wang References: <20201020071628.323641-1-amorenoz@redhat.com> From: Maxime Coquelin Message-ID: <525cba16-8f46-fc7e-47ec-1f0ec45c00e2@redhat.com> Date: Tue, 20 Oct 2020 11:11:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/20/20 11:01 AM, Kevin Traynor wrote: > On 20/10/2020 08:16, Adrian Moreno wrote: >> If stat fails it means the backend must be vhost-user in server mode >> >> Bugzilla ID: 559 >> Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") >> Cc: stable@dpdk.org >> >> Signed-off-by: Adrian Moreno >> --- >> drivers/net/virtio/virtio_user_ethdev.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c >> index 042665bc0..ce74d08ab 100644 >> --- a/drivers/net/virtio/virtio_user_ethdev.c >> +++ b/drivers/net/virtio/virtio_user_ethdev.c >> @@ -560,9 +560,10 @@ virtio_user_backend_type(const char *path) >> struct stat sb; >> >> if (stat(path, &sb) == -1) { >> - PMD_INIT_LOG(ERR, "Stat fails: %s (%s)\n", path, >> + PMD_INIT_LOG(INFO, "Stat fails: %s (%s)\n", path, >> strerror(errno)); > > It may be accurate, but a 'fail' in the logs can be confusing for users > when it is an INFO log and normal operation. Suggest to reword to > something softer like 'Unable to stat' or 'Not able to get file status' We may want to: - only return VIRTIO_USER_BACKEND_VHOST_USER if -ENOENT, and log that we assume this is Vhost-user backend in server mode at INFO level. - return VIRTIO_USER_BACKEND_UNKNOWN otherwise and print an error message with the strerror(errno). What do you think? >> - return VIRTIO_USER_BACKEND_UNKNOWN; >> + /* Must be vhost-user in server mode */ >> + return VIRTIO_USER_BACKEND_VHOST_USER; >> } >> >> if (S_ISSOCK(sb.st_mode)) { >> >