From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_
Date: Tue, 5 Apr 2016 16:45:29 +0000 [thread overview]
Message-ID: <526020DD-F265-4E88-B7D3-3FD6F6367AAD@intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B2E5A6@irsmsx105.ger.corp.intel.com>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
>> Sent: Tuesday, April 05, 2016 2:29 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_
>>
>> I'd like people opinion of Thomas proposal to have all new libraries use
>> a dpdk_ prefix instead of rte_*. Although I agree that dpdk_ would
>> probably make sense, I don't like the ascetics of inconsistent prefixes
>> on dpdk libraries. Any comments?
>
>I suppose it is a bit strange to have rte_ prefix for one set of libraries,
>and dpdk_ prefix for others.
>If we'd decide to change the prefix, then my vote would be to do
>that for all dpdk libraries at once.
>BTW, why do we need to change it at all?
>'rte_' is probably not the best one, but at least it is well known/used.
>Konstantin
I agree with Thomas as a Type One like person I would like to change it too, but think Konstantin’s point is very valid and we do not need to change existing APIs. I could live with changing the new libraries only, but then we get into the multiple prefixes problem :-(
>
>
>>
>>
>>
>>
>> 2016-04-05 09:48, Trahe, Fiona:
>> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>> > > 2016-04-05 08:53, Fiona Trahe:
>> > > > The cryptodev API was introduced in the DPDK 2.2 release.
>> > > > Since then it has
>> > > > - been reviewed and iterated for the DPDK 16.04 release
>> > > > - had extensive use by the l2fwd-crypto app,
>> > > > the ipsec-secgw example app,
>> > > > the test app.
>> > > > We believe it is now stable and the EXPERIMENTAL label should be removed.
>> > >
>> > > Are you sure sure? :)
>> > > It means you will try hard to not change the API anymore or you'll need a
>> > > deprecation notice strongly agreed (outside of your team).
>> >
>> > We're sure sure :)
>>
>> I think we could change the namespace before making this API stable.
>> What about using a dpdk_ prefix instead of rte_ ?
>> (and some macros have CRYPTODEV or CDEV prefixes)
>>
>
>
Regards,
Keith
next prev parent reply other threads:[~2016-04-05 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 7:53 [dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label Fiona Trahe
2016-04-05 8:47 ` Thomas Monjalon
2016-04-05 9:48 ` Trahe, Fiona
2016-04-05 10:11 ` Thomas Monjalon
2016-04-05 13:29 ` [dpdk-dev] Change new libraries to have dpdk_ prefix instead of rte_ Declan Doherty
2016-04-05 14:03 ` Ananyev, Konstantin
2016-04-05 14:22 ` Thomas Monjalon
2016-04-05 16:45 ` Wiles, Keith [this message]
2016-04-06 11:05 ` [dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label Fiona Trahe
2016-04-06 16:37 ` Thomas Monjalon
2016-04-06 16:46 ` Trahe, Fiona
2016-04-06 16:49 ` Thomas Monjalon
2016-04-06 17:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526020DD-F265-4E88-B7D3-3FD6F6367AAD@intel.com \
--to=keith.wiles@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).