DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
	jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
	anoob.joseph@caviumnetworks.com
Cc: dev@dpdk.org, "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support
Date: Fri, 21 Sep 2018 13:14:53 +0530	[thread overview]
Message-ID: <5261bae8-0842-849e-b95a-67ee851ee7f8@intel.com> (raw)
In-Reply-To: <20180905134554.25243-1-pbhagavatula@caviumnetworks.com>

On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote:
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>   This patch depends on the following series:
>   http://patches.dpdk.org/project/dpdk/list/?series=1121
> 
>   examples/eventdev_pipeline/main.c             |  62 ++--
>   examples/eventdev_pipeline/pipeline_common.h  |  31 +-
>   .../pipeline_worker_generic.c                 | 273 +++++-------------
>   .../eventdev_pipeline/pipeline_worker_tx.c    | 130 +++++----
>   4 files changed, 186 insertions(+), 310 deletions(-)
> 
> --- a/examples/eventdev_pipeline/pipeline_worker_generic.c
> +++ b/examples/eventdev_pipeline/pipeline_worker_generic.c
> @@ -119,153 +119,13 @@ worker_generic_burst(void *arg)
>   	return 0;
>   }
> 

>   static void
> -init_rx_adapter(uint16_t nb_ports)
> +init_adapters(uint16_t nb_ports)
>   {
>   	int i;
>   	int ret;
> +	uint8_t tx_port_id = 0;
>   	uint8_t evdev_id = 0;
>   	struct rte_event_dev_info dev_info;
> 
>   	ret = rte_event_dev_info_get(evdev_id, &dev_info);
> 
> -	struct rte_event_port_conf rx_p_conf = {
> +	struct rte_event_port_conf adptr_p_conf = {
>   		.dequeue_depth = 8,
>   		.enqueue_depth = 8,
>   		.new_event_threshold = 1200,
>   	};
> 

We should restore the dequeue_depth to 128 for the port config passed to 
the Tx adapter. Doing so takes the performance from 5.8 mpps to 11.7 
mpps for on my test setup (test setup uses the SW PMD). Restoring 
enqueue_depth and new_event_threshold (64 and 4096 respectively) had
no noticeable effect.

Thanks,
Nikhil

  parent reply	other threads:[~2018-09-21  7:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 13:45 Pavan Nikhilesh
2018-09-17 14:17 ` Jerin Jacob
2018-09-19  2:54 ` Rao, Nikhil
2018-09-19 10:42   ` Pavan Nikhilesh
2018-09-20  2:18     ` Rao, Nikhil
2018-09-21  7:44 ` Rao, Nikhil [this message]
2018-09-24  9:51   ` Pavan Nikhilesh
2018-09-24 10:12 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
2018-09-26 12:56   ` Rao, Nikhil
2018-09-28 11:15     ` Jerin Jacob
2018-10-03  8:47       ` Rao, Nikhil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5261bae8-0842-849e-b95a-67ee851ee7f8@intel.com \
    --to=nikhil.rao@intel.com \
    --cc=anoob.joseph@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=pbhagavatula@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).