From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id C9D605F72 for ; Tue, 27 Jan 2015 13:06:47 +0100 (CET) Received: by mail-wi0-f181.google.com with SMTP id fb4so4483466wid.2 for ; Tue, 27 Jan 2015 04:06:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hJdgPdN8R923g0reKBse57tiR5v1EJkwkYxnnZTyLbY=; b=GY6vXxKu0x1QwGcrGguFM4zHDi7ZYy8EBYBlKdANhP7a2/B1VsaQ8Jw974kKtERQiz hrJkKxrHSpyAJKhcUTC8vN+Q80FeVpyXDWYTVQzwv0urSIdhtOgTxXxKmnfyU0s2Op8I 611eGn2lhUu6at8IQg7L39ok3M0ZPfcnDz1tWT9w/mRiw1zhyKI31H56E/s1Wbj2DorZ Xdf2VbbbwUrp5Q4jHxsvPN/WmBqgzGzCOADqvCivkxfwv1rxkBc9M/IgadHngBk8nuxv 5uob7PpiK3r6YFoH2uTBxPtrnE87etP+5GgT1XfaaMMFM3l1TzLa2qMym8lQKDpKryml 46SQ== X-Gm-Message-State: ALoCoQnnhrbKoVk3hobN4q3zXy/0G/CR7BxZv7Mi7L1KEgx76rXwLbfaaynFsiF79jNGa8puwSTJ X-Received: by 10.194.219.68 with SMTP id pm4mr1931447wjc.71.1422360407512; Tue, 27 Jan 2015 04:06:47 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id 18sm1532352wjr.46.2015.01.27.04.06.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 04:06:46 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Tue, 27 Jan 2015 13:06:20 +0100 Message-ID: <5262681.X6Q2U5C1BV@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1421813818-2354-1-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Neil Horman , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] stats: remove useless memset's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 12:06:48 -0000 2015-01-21 14:08, David Marchand: > Hello Stephen, > > > From: Stephen Hemminger > > > > The rte_eth_stats_get is the only API that should call the device > > statistics function directly, and it already does a memset of the > > resulting structure. Therefore doing memset() in the driver is > > redundant and should be removed. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 2 -- > > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 4 ---- > > lib/librte_pmd_enic/enic_main.c | 1 - > > lib/librte_pmd_i40e/i40e_ethdev_vf.c | 1 - > > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 - > > lib/librte_pmd_ring/rte_eth_ring.c | 1 - > > 6 files changed, 10 deletions(-) > > > > I think you missed some : > - lib/librte_pmd_e1000/igb_ethdev.c function eth_igbvf_stats_get() > - lib/librte_pmd_pcap/rte_eth_pcap.c function eth_stats_get() > > With these fixed : > Acked-By: David Marchand Applied with above fixes. Thanks -- Thomas